[GitHub] [beam] reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders

2020-03-27 Thread GitBox
reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders
URL: https://github.com/apache/beam/pull/10883#issuecomment-605320135
 
 
   run sql postcommit


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [beam] reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders

2020-03-27 Thread GitBox
reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders
URL: https://github.com/apache/beam/pull/10883#issuecomment-605316228
 
 
   run sql postcommit


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [beam] reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders

2020-03-27 Thread GitBox
reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders
URL: https://github.com/apache/beam/pull/10883#issuecomment-605167235
 
 
   @alexvanboxel I would rather not in this PR, because the RowUtils API wasn't 
designed for public usage. If we were to make it public, I would prefer to 
spend a lot more time on the API design, and I would also want to understand 
the use cases a bit better.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [beam] reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders

2020-03-26 Thread GitBox
reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders
URL: https://github.com/apache/beam/pull/10883#issuecomment-604738743
 
 
   run sql postcommit


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [beam] reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders

2020-03-26 Thread GitBox
reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders
URL: https://github.com/apache/beam/pull/10883#issuecomment-604726387
 
 
   @alexvanboxel rebased and fixed bugs. Previously I was blocked on getting 
logical types to work, but now that we natively store logical types in Row, 
it's become much easier.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [beam] reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders

2020-03-25 Thread GitBox
reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders
URL: https://github.com/apache/beam/pull/10883#issuecomment-604235650
 
 
   Run Java PreCommit


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services