[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-23 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r493764967 ## File path: sdks/python/apache_beam/transforms/environments.py ## @@ -252,6 +254,13 @@ def from_runner_api_parameter(payload, capabilities, artifacts,

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-23 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r493764637 ## File path: sdks/python/apache_beam/options/pipeline_options.py ## @@ -1003,6 +1003,13 @@ def _add_argparse_args(cls, parser): 'environment.

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-23 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r493760627 ## File path: sdks/python/apache_beam/runners/portability/sdk_container_builder.py ## @@ -0,0 +1,279 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-22 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r492888461 ## File path: sdks/python/apache_beam/runners/portability/sdk_container_builder.py ## @@ -0,0 +1,274 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-22 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r493106053 ## File path: sdks/python/apache_beam/options/pipeline_options.py ## @@ -1003,6 +1003,13 @@ def _add_argparse_args(cls, parser): 'environment.

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-22 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r493105561 ## File path: sdks/python/apache_beam/runners/portability/sdk_container_builder.py ## @@ -0,0 +1,279 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-22 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r493104239 ## File path: sdks/python/apache_beam/runners/portability/sdk_container_builder.py ## @@ -0,0 +1,279 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-22 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r493104158 ## File path: sdks/python/apache_beam/runners/portability/stager.py ## @@ -136,6 +137,8 @@ def create_job_resources(options, # type: PipelineOptions

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-22 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r492888461 ## File path: sdks/python/apache_beam/runners/portability/sdk_container_builder.py ## @@ -0,0 +1,274 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-21 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r492220801 ## File path: sdks/python/apache_beam/transforms/environments.py ## @@ -252,6 +254,14 @@ def from_runner_api_parameter(payload, capabilities, artifacts,

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-21 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r492290645 ## File path: sdks/python/apache_beam/runners/portability/stager.py ## @@ -119,6 +119,7 @@ def create_job_resources(options, # type: PipelineOptions

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-21 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r492221892 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py ## @@ -473,10 +474,19 @@ def run_pipeline(self, pipeline, options):

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-21 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r492221619 ## File path: sdks/python/apache_beam/runners/portability/stager.py ## @@ -119,6 +119,7 @@ def create_job_resources(options, # type: PipelineOptions

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-21 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r492220801 ## File path: sdks/python/apache_beam/transforms/environments.py ## @@ -252,6 +254,14 @@ def from_runner_api_parameter(payload, capabilities, artifacts,

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r491178572 ## File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py ## @@ -473,10 +474,19 @@ def run_pipeline(self, pipeline, options):

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r491077972 ## File path: sdks/python/container/boot.go ## @@ -283,3 +306,51 @@ func multiProcessExactlyOnce(actionFunc func(), completeFileName string) {

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-18 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r491077501 ## File path: sdks/python/container/boot.go ## @@ -61,11 +66,22 @@ const ( sdkSrcFile= "dataflow_python_sdk.tar" extraPackagesFile =