Re: [PR] [yaml] Add Beam YAML Examples [beam]
eder001 commented on PR #32519: URL: https://github.com/apache/beam/pull/32519#issuecomment-2483810461 No, it is not... please just disregard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
eder001 closed pull request #32519: [yaml] Add Beam YAML Examples URL: https://github.com/apache/beam/pull/32519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
claudevdm commented on PR #32519: URL: https://github.com/apache/beam/pull/32519#issuecomment-2483402933 @Polber @eder001 is this waiting on a next round of reviews? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
eder001 commented on code in PR #32519: URL: https://github.com/apache/beam/pull/32519#discussion_r1769219550 ## sdks/python/apache_beam/yaml/examples/test_read_mysql_write_postgres.yaml: ## Review Comment: @Polber Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
github-actions[bot] commented on PR #32519: URL: https://github.com/apache/beam/pull/32519#issuecomment-2364540132 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
Polber commented on code in PR #32519: URL: https://github.com/apache/beam/pull/32519#discussion_r1769147826 ## sdks/python/apache_beam/yaml/examples/test_read_mysql_write_postgres.yaml: ## @@ -0,0 +1,48 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads data from a Mysql database +# then load the results back to a Postgre database +pipeline: + transforms: +- type: ReadFromJdbc + name: ReadFromMysql + config: +driver_class_name: 'com.mysql.cj.jdbc.Driver' +jdbc_url: 'jdbc:mysql://database_ip:3306/database_name' +username: 'username' +password: 'password' +read_query: 'select * from table;' +driver_jars: 'mysql-connector-j-9.0.0.jar' Review Comment: You can use the `ReadFromMySql` transform to be less verbose and not require staging a driver JAR ```suggestion - type: ReadFromMySql config: url: 'jdbc:mysql://database_ip:3306/database_name' username: 'username' password: 'password' query: 'select * from table;' ``` ## sdks/python/apache_beam/yaml/examples/test_read_mysql_write_postgres.yaml: ## @@ -0,0 +1,48 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads data from a Mysql database +# then load the results back to a Postgre database +pipeline: + transforms: +- type: ReadFromJdbc + name: ReadFromMysql + config: +driver_class_name: 'com.mysql.cj.jdbc.Driver' +jdbc_url: 'jdbc:mysql://database_ip:3306/database_name' +username: 'username' +password: 'password' +read_query: 'select * from table;' +driver_jars: 'mysql-connector-j-9.0.0.jar' +- type: WriteToJdbc + name: WriteToJdbc + input: ReadFromMysql + config: +driver_class_name: 'org.postgresql.Driver' +jdbc_url: 'jdbc:postgresql://database_ip:5432/database_name' +username: 'username' +password: 'password' +table: 'table_name' +driver_jars: 'postgresql-42.7.4.jar' Review Comment: Same here ```suggestion - type: WriteToPostgres input: ReadFromMysql config: url: 'jdbc:postgresql://database_ip:5432/database_name' username: 'username' password: 'password' table: 'table_name' ``` ## sdks/python/apache_beam/yaml/examples/test_read_mysql_write_postgres.yaml: ## @@ -0,0 +1,48 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version
[PR] [yaml] Add Beam YAML Examples [beam]
eder001 opened a new pull request, #32519: URL: https://github.com/apache/beam/pull/32519 1x Example: MapToFields and Combine using SQL 1x Example: MapToFields using SQL and the SQL type command 1x Example: Using JDBC connection to read (Mysql) and write (Postgre) in a database -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
eder001 closed pull request #32436: [yaml] Add Beam YAML Examples URL: https://github.com/apache/beam/pull/32436 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
eder001 commented on code in PR #32436: URL: https://github.com/apache/beam/pull/32436#discussion_r1756745631 ## sdks/python/apache_beam/yaml/examples/aggregation_using_sqlstatement.yaml: ## @@ -0,0 +1,59 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". +pipeline: + transforms: +- type: ReadFromCsv + name: ReadInputFile + config: +path: gs://apache-beam-samples/beam-yaml-blog/products.csv +delimiter: "," +- type: MapToFields + name: MapToFields + input: ReadInputFile + config: +language: sql +fields: + transaction_id: "transaction_id" + product_name: "product_name" + category: "category" + prices: "price" Review Comment: I was thinking of demonstrating a scenario of allowing users to rename their fields. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
Polber commented on code in PR #32436: URL: https://github.com/apache/beam/pull/32436#discussion_r1755859736 ## sdks/python/apache_beam/yaml/examples/aggregation_using_sqlstatement.yaml: ## @@ -0,0 +1,59 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". +pipeline: + transforms: +- type: ReadFromCsv + name: ReadInputFile + config: +path: gs://apache-beam-samples/beam-yaml-blog/products.csv +delimiter: "," +- type: MapToFields + name: MapToFields + input: ReadInputFile + config: +language: sql +fields: + transaction_id: "transaction_id" + product_name: "product_name" + category: "category" + prices: "price" +- type: Sql + name: SqlCommand + config: +query: "select category, count(*) as cnt,sum(prices) as sum_prices, max(prices) as max_prices from PCOLLECTION group by category" + input: MapToFields +- type: WriteToCsv + name: WriteOutputFile + input: SqlCommand + config: +path: output + +# Expected: +# Row(category='Apparel', cnt=1, sum_prices=109.99, price=109.99) +# Row(category='Kitchen', cnt=1, sum_prices=29.99, price=29.99) +# Row(category='Electronics', cnt=3, sum_prices=369.97, price=249.99) Review Comment: ```suggestion # Row(category='Apparel', num_sold =1, revenue =109.99, max_price=109.99) # Row(category='Kitchen', num_sold =1, revenue =29.99, max_price=29.99) # Row(category='Electronics', num_sold =3, revenue =369.97, max_price=249.99) ``` ## sdks/python/apache_beam/yaml/examples/aggregation_using_sqlstatement.yaml: ## @@ -0,0 +1,59 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +#http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +# This examples reads from a public file stored on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# The following example reads mock transaction data from resources/products.csv +# then performs a simple filter for "Electronics". +pipeline: + transforms: +- type: ReadFromCsv + name: ReadInputFile + config: +path: gs://apache-beam-samples/beam-yaml-blog/products.csv +delimiter: "," +- type: MapToFields + name: MapToFields + input: ReadInputFile + config: +language: sql +fields: + transaction_id: "transaction_id" + product_name: "product_name" + category: "category" + prices: "price" +- type: Sql + name: SqlCommand + config: +query: "select category, count(*) as cnt,sum(prices) as sum_prices, max(prices) as max_prices from PCOLLECTION group by category" + input: MapToFields +- type: WriteToCsv + name: WriteOutputFile + input: SqlCommand + config: +path: output Review Co
Re: [PR] [yaml] Add Beam YAML Examples [beam]
github-actions[bot] commented on PR #32436: URL: https://github.com/apache/beam/pull/32436#issuecomment-2344872992 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [yaml] Add Beam YAML Examples [beam]
eder001 opened a new pull request, #32436: URL: https://github.com/apache/beam/pull/32436 1x Example: MapToFields and Combine using SQL 1x Example: MapToFields using SQL and the SQL type command -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
eder001 closed pull request #32435: [yaml] Add Beam YAML Examples URL: https://github.com/apache/beam/pull/32435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [yaml] Add Beam YAML Examples [beam]
eder001 opened a new pull request, #32435: URL: https://github.com/apache/beam/pull/32435 [yaml] Add Beam YAML Examples -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
eder001 closed pull request #32422: [yaml] Add Beam YAML Examples URL: https://github.com/apache/beam/pull/32422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
github-actions[bot] commented on PR #32422: URL: https://github.com/apache/beam/pull/32422#issuecomment-2342010237 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [yaml] Add Beam YAML Examples [beam]
eder001 opened a new pull request, #32422: URL: https://github.com/apache/beam/pull/32422 [yaml] Add Beam YAML Examples -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
eder001 closed pull request #32421: [yaml] Add Beam YAML Examples URL: https://github.com/apache/beam/pull/32421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [yaml] Add Beam YAML Examples [beam]
eder001 closed pull request #32420: [yaml] Add Beam YAML Examples URL: https://github.com/apache/beam/pull/32420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
