Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
scwhittle merged PR #37964: URL: https://github.com/apache/beam/pull/37964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
scwhittle commented on code in PR #37964:
URL: https://github.com/apache/beam/pull/37964#discussion_r3087216323
##
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateFetchingIterators.java:
##
@@ -299,29 +356,47 @@ public static Block mutatedBlock(WeightedList
values) {
}
public static Block fromValues(List values, @Nullable
ByteString nextToken) {
-return fromValues(WeightedList.of(values, Caches.weigh(values)),
nextToken);
+long listWeight = values.size() * Caches.REFERENCE_SIZE;
Review Comment:
It seems a little safer just here since we know the lists. A possible
concern with it in Caches.weigh is that it could remove counting of bytes for
custom lists/collections which are more expensive than when iterated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
arunpandianp commented on code in PR #37964:
URL: https://github.com/apache/beam/pull/37964#discussion_r3086772821
##
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateFetchingIterators.java:
##
@@ -299,29 +356,47 @@ public static Block mutatedBlock(WeightedList
values) {
}
public static Block fromValues(List values, @Nullable
ByteString nextToken) {
-return fromValues(WeightedList.of(values, Caches.weigh(values)),
nextToken);
+long listWeight = values.size() * Caches.REFERENCE_SIZE;
Review Comment:
Will it be useful to move this logic inside `Caches.weigh`? `Caches.weigh`
could check if the object is an list/collection and compute weights using this
logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
github-actions[bot] commented on PR #37964: URL: https://github.com/apache/beam/pull/37964#issuecomment-4251785171 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
scwhittle commented on PR #37964: URL: https://github.com/apache/beam/pull/37964#issuecomment-4251778105 R: @arunpandianp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
github-actions[bot] commented on PR #37964: URL: https://github.com/apache/beam/pull/37964#issuecomment-4201909616 Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment `assign to next reviewer`. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) The PR bot will only process comments in the main thread (not review comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
scwhittle commented on PR #37964: URL: https://github.com/apache/beam/pull/37964#issuecomment-4201903293 assign set of reviewers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
scwhittle commented on PR #37964: URL: https://github.com/apache/beam/pull/37964#issuecomment-4201901008 failures appear unrelated direct runner tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
scwhittle closed pull request #37964: [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks URL: https://github.com/apache/beam/pull/37964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
scwhittle commented on PR #37964: URL: https://github.com/apache/beam/pull/37964#issuecomment-4143213374 Verified that with this change and a Weighted object in state fields, there are no more measureDeep calls. Here is the fromBlocks stacks with the change: https://screenshot.googleplex.com/4YgpCpgPS4iVF9u.png -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
github-actions[bot] commented on PR #37964: URL: https://github.com/apache/beam/pull/37964#issuecomment-4136442409 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] [Java Harness] Reapply optimization to use Caches.weigh on objects within cached blocks [beam]
gemini-code-assist[bot] commented on PR #37964: URL: https://github.com/apache/beam/pull/37964#issuecomment-4135069889 ## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request re-enables a critical optimization for cache weighing within the Java Harness, which was previously rolled back. The core improvement involves refactoring the underlying data structures to properly handle null values, a limitation of the prior implementation. This change enhances the efficiency of cache management and improves the robustness of state fetching iterators by ensuring correct weight calculations and null safety. ### Highlights * **Reapplied Cache Optimization**: Reintroduced an optimization to use `Caches.weigh` on objects within cached blocks, which was previously reverted due to issues with `ImmutableList` not supporting null elements. * **Null Value Support**: Resolved the `ImmutableList` issue by switching to an array-backed list for `Block` values, allowing null elements, and added a dedicated unit test to ensure null values are correctly handled. * **Improved Weight Calculation**: Replaced custom arithmetic overflow handling with `LongMath::saturatedAdd` for weight accumulation in `WeightedList` and `BlocksPrefix`, preventing `ArithmeticException` and ensuring weights cap at `Long.MAX_VALUE`. * **Nullness Annotations and Suppressions**: Cleaned up nullness suppressions and added `@Nullable` annotations across `Caches.java` and `StateFetchingIterators.java` for improved type safety and clarity. * **Refactored Block Class**: Converted the `StateFetchingIterators.Block` from an `AutoValue` class to a concrete class with a builder pattern, providing more control over its construction and weight calculation. 🧠**New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** Using Gemini Code Assist The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either `/gemini ` or `@gemini-code-assist `. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
