Re: [PR] Add Worker hashes for Golang [beam]
Abacn merged PR #38754: URL: https://github.com/apache/beam/pull/38754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Worker hashes for Golang [beam]
github-actions[bot] commented on PR #38754: URL: https://github.com/apache/beam/pull/38754#issuecomment-4594764759 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Worker hashes for Golang [beam]
tarun-google commented on PR #38754: URL: https://github.com/apache/beam/pull/38754#issuecomment-4594753154 R: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Worker hashes for Golang [beam]
github-actions[bot] commented on PR #38754: URL: https://github.com/apache/beam/pull/38754#issuecomment-4588555716 Assigning reviewers: R: @jrmccluskey for label go. Note: If you would like to opt out of this review, comment `assign to next reviewer`. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) The PR bot will only process comments in the main thread (not review comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Worker hashes for Golang [beam]
codecov[bot] commented on PR #38754: URL: https://github.com/apache/beam/pull/38754#issuecomment-4588448838 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/38754?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `50.0%` with `1 line` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.80%. Comparing base ([`1b261f0`](https://app.codecov.io/gh/apache/beam/commit/1b261f0a39915eebb9e53f384d59cba8fa726d8a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d1f595f`](https://app.codecov.io/gh/apache/beam/commit/d1f595fa865aeacfc4561aaf935cb9abe6f6a333?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 40 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/beam/pull/38754?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [...o/pkg/beam/runners/dataflow/dataflowlib/execute.go](https://app.codecov.io/gh/apache/beam/pull/38754?src=pr&el=tree&filepath=sdks%2Fgo%2Fpkg%2Fbeam%2Frunners%2Fdataflow%2Fdataflowlib%2Fexecute.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9wa2cvYmVhbS9ydW5uZXJzL2RhdGFmbG93L2RhdGFmbG93bGliL2V4ZWN1dGUuZ28=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/38754?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #38754 +/- ## - Coverage 55.82% 55.80% -0.02% Complexity 2111 2111 Files 1102 1102 Lines172482 172590 +108 Branches 1357 1357 + Hits 9628296319 +37 - Misses7380673875 +69 - Partials 2394 2396 +2 ``` | [Flag](https://app.codecov.io/gh/apache/beam/pull/38754/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [go](https://app.codecov.io/gh/apache/beam/pull/38754/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `28.73% <50.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/38754?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] Add Worker hashes for Golang [beam]
gemini-code-assist[bot] commented on code in PR #38754:
URL: https://github.com/apache/beam/pull/38754#discussion_r3331039197
##
sdks/go/pkg/beam/runners/dataflow/dataflowlib/job_test.go:
##
@@ -312,6 +313,14 @@ func TestTranslate(t *testing.T) {
if wp.DiskProvisionedThroughputMibps != 200 {
t.Errorf("DiskProvisionedThroughputMibps = %v, want 200",
wp.DiskProvisionedThroughputMibps)
}
+
+ // Verify worker package has Sha256
+ if len(wp.Packages) != 1 {
+ t.Fatalf("len(wp.Packages) = %v, want 1", len(wp.Packages))
+ }
+ if wp.Packages[0].Name != "worker" || wp.Packages[0].Sha256 !=
"worker-sha256-hash" {
+ t.Errorf("wp.Packages[0] = {Name: %q, Sha256: %q}, want {Name:
%q, Sha256: %q}", wp.Packages[0].Name, wp.Packages[0].Sha256, "worker",
"worker-sha256-hash")
+ }
Review Comment:
The current test assertion assumes that the worker package is the only
package in `wp.Packages` and that it is always at index 0. To make the test
more robust against future changes (such as adding default packages or
artifacts), it is better to iterate through the packages to find the one named
`"worker"` and verify its hash.
```go
// Verify worker package has Sha256
found := false
for _, pkg := range wp.Packages {
if pkg.Name == "worker" {
found = true
if pkg.Sha256 != "worker-sha256-hash" {
t.Errorf("worker package Sha256 = %q, want %q",
pkg.Sha256, "worker-sha256-hash")
}
break
}
}
if !found {
t.Fatalf("worker package not found in wp.Packages")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] Add Worker hashes for Golang [beam]
gemini-code-assist[bot] commented on PR #38754: URL: https://github.com/apache/beam/pull/38754#issuecomment-4588401330 ## Summary of Changes Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for passing worker binary hashes to the Dataflow runner in the Go SDK. By including the SHA-256 hash in the worker package metadata, the system can better verify worker integrity and ensure consistency during pipeline execution. ### Highlights * **Worker Hash Support**: Added a new WorkerHash field to JobOptions to track the SHA-256 hash of the worker binary. * **Metadata Integration**: Updated the Dataflow runner to include the worker binary's SHA-256 hash in the package metadata during job translation. * **Testing**: Added unit tests to verify that the worker package correctly includes the expected SHA-256 hash. New Features 🧠 You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.** Using Gemini Code Assist The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either `/gemini ` or `@gemini-code-assist `. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
