Re: [PR] Add python array example [beam]

2026-03-30 Thread via GitHub


damccorm commented on code in PR #37960:
URL: https://github.com/apache/beam/pull/37960#discussion_r3010447898


##
website/www/site/content/en/documentation/programming-guide.md:
##
@@ -4259,6 +4268,15 @@ selected, the result is an array of the selected 
subfield type. For example
 Support for Array fields hasn't been developed for the Python SDK yet.
 {{< /paragraph >}}
 
+{{< paragraph class="language-py" >}}
+example of selecting a nested field inside an array:
+{{< /paragraph >}}
+
+<< highlight py >>
+input_pc = ...
+output_pc = input_pc | beam.Select("transactions[].bank")
+<< /highlight py >>
+

Review Comment:
   This has the same problem as https://github.com/apache/beam/pull/37959 - 
none of these are supported today



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add python array example [beam]

2026-03-30 Thread via GitHub


damccorm closed pull request #37960: Add python array example
URL: https://github.com/apache/beam/pull/37960


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add python array example [beam]

2026-03-26 Thread via GitHub


github-actions[bot] commented on PR #37960:
URL: https://github.com/apache/beam/pull/37960#issuecomment-4133186846

   Assigning reviewers:
   
   R: @Abacn for label website.
   
   
   Note: If you would like to opt out of this review, comment `assign to next 
reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any 
comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review 
comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Add python array example [beam]

2026-03-26 Thread via GitHub


gemini-code-assist[bot] commented on PR #37960:
URL: https://github.com/apache/beam/pull/37960#issuecomment-4132846188

   ## Summary of Changes
   
   Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request 
and will post my feedback shortly. In the meantime, here's a summary to help 
you and other reviewers quickly get up to speed!
   
   This pull request improves the Apache Beam programming guide by adding new 
Python code examples. These examples demonstrate how to select nested fields 
using wildcards and how to select fields within arrays, bringing the Python 
documentation closer to the existing Java examples and making it more 
comprehensive for Python developers.
   
   ### Highlights
   
   * **Python Documentation**: Added Python examples for array field selection 
and wildcard usage in the Apache Beam programming guide, enhancing 
documentation completeness for Python users.
   
   🧠 **New Feature in Public Preview:** You can now enable **Memory** to help 
**Gemini Code Assist** learn from your team's feedback. This makes future code 
reviews more consistent and personalized to your project's style. **Click 
[here](https://codeassist.google/code-review/login) to enable Memory in your 
admin console.**
   
   
   Using Gemini Code Assist
   
   
   The full guide for Gemini Code Assist can be found on our [documentation 
page](https://developers.google.com/gemini-code-assist/docs/review-github-code),
 here are some quick tips.
   
   Invoking Gemini
   
   You can request assistance from Gemini at any point by creating a comment 
using either `/gemini ` or `@gemini-code-assist `. Below is a 
summary of the supported commands on the current page.
   
   Feature | Command | Description
   --- | --- | ---
   Code Review | `/gemini review` | Performs a code review for the current pull 
request in its current state.
   Pull Request Summary | `/gemini summary` | Provides a summary of the current 
pull request in its current state.
   Comment | @gemini-code-assist | Responds in comments when explicitly tagged, 
both in pull request comments and review comments.
   Help | `/gemini help` | Displays a list of available commands.
   
   Customization
   
   To customize Gemini Code Assist for GitHub experience, repository 
maintainers can create a configuration file and/or provide a custom code review 
style guide (such as PEP-8 for Python) by creating and adding files to a 
`.gemini/` folder in the base of the repository. Detailed instructions can be 
found 
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
   
   Limitations & Feedback
   
   Gemini Code Assist may make mistakes. Please leave feedback on any instances 
where its feedback is incorrect or counter productive. You can react with 
:thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're 
interested in giving your feedback about your experience with Gemini Code 
Assist for GitHub and other Google products, sign up 
[here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
   
   
   
   [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), 
[Generative AI Prohibited Use 
Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of 
Service](https://policies.google.com/terms), and learn how to configure Gemini 
Code Assist in GitHub 
[here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
 Gemini can make mistakes, so double check it and [use code with 
caution](https://support.google.com/legal/answer/13505487).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]