Re: [PR] Revert #30533: Automatically execute unbounded pipelines in streaming mode. [beam]

2024-04-09 Thread via GitHub
kennknowles commented on PR #30706: URL: https://github.com/apache/beam/pull/30706#issuecomment-2045466784 The tests are entirely internal to Google so there is no externally tracked failure. You would have to write a pipeline with unbounded data and then insist on running it in batch

Re: [PR] Revert #30533: Automatically execute unbounded pipelines in streaming mode. [beam]

2024-04-09 Thread via GitHub
kennknowles commented on PR #30706: URL: https://github.com/apache/beam/pull/30706#issuecomment-2045464303 The description is not accurate - we have an underlying bug in dataflow and some erroneous tests. The original commit was a correct change. This is reverted while we fix our tests and

Re: [PR] Revert #30533: Automatically execute unbounded pipelines in streaming mode. [beam]

2024-03-22 Thread via GitHub
damondouglas merged PR #30706: URL: https://github.com/apache/beam/pull/30706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Revert #30533: Automatically execute unbounded pipelines in streaming mode. [beam]

2024-03-22 Thread via GitHub
damccorm commented on PR #30706: URL: https://github.com/apache/beam/pull/30706#issuecomment-2015315124 My understanding is that this has caused some Dataflow tests to fail, but has it actually had negative impact on real pipelines? Is the problem here or is it with the tests themselves?

Re: [PR] Revert #30533: Automatically execute unbounded pipelines in streaming mode. [beam]

2024-03-22 Thread via GitHub
riteshghorse commented on PR #30706: URL: https://github.com/apache/beam/pull/30706#issuecomment-2015280947 Do we have any issue tracking this or failure run we can link? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Revert #30533: Automatically execute unbounded pipelines in streaming mode. [beam]

2024-03-21 Thread via GitHub
github-actions[bot] commented on PR #30706: URL: https://github.com/apache/beam/pull/30706#issuecomment-2014007401 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @riteshghorse for label python. Available commands: -