Re: [PR] Upgrade Apache Beam to use Cython 3.x. [beam]
robertwb merged PR #32112: URL: https://github.com/apache/beam/pull/32112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade Apache Beam to use Cython 3.x. [beam]
github-actions[bot] commented on PR #32112: URL: https://github.com/apache/beam/pull/32112#issuecomment-2276882099 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @shunping for label python. Available commands: - `stop reviewer notifications` - opt out of the automated review tooling - `remind me after tests pass` - tag the comment author after tests pass - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers) The PR bot will only process comments in the main thread (not review comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade Apache Beam to use Cython 3.x. [beam]
robertwb commented on PR #32112: URL: https://github.com/apache/beam/pull/32112#issuecomment-2276763308 Good call. I did take a pass over the pxd files, but forgot about the nogil caveat. Looks like we don't use that much, but added the one case I found. (Most of the time we were either explicitly using except or returning a Python object, and even where not it's numeric so should be fast.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade Apache Beam to use Cython 3.x. [beam]
tvalentyn commented on PR #32112: URL: https://github.com/apache/beam/pull/32112#issuecomment-2276729021 @robertwb Does your recommendation in https://github.com/apache/beam/pull/27536/files#r1267273865 still apply? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade Apache Beam to use Cython 3.x. [beam]
github-actions[bot] commented on PR #32112: URL: https://github.com/apache/beam/pull/32112#issuecomment-2276521186 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade Apache Beam to use Cython 3.x. [beam]
robertwb commented on PR #32112: URL: https://github.com/apache/beam/pull/32112#issuecomment-2276472197 I think the `Could not retrieve licences for packages ['scikit-learn'] ` errors are irrelevant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
