Re: [PR] fix: Make `serialize_to_file` test cross platform [datafusion]

2026-02-04 Thread via GitHub 


adriangb merged PR #20147:
URL: https://github.com/apache/datafusion/pull/20147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix: Make `serialize_to_file` test cross platform [datafusion]

2026-02-04 Thread via GitHub 


nuno-faria commented on PR #20147:
URL: https://github.com/apache/datafusion/pull/20147#issuecomment-3849404574

   > Makes sense. Obviously we can't get an exhaustive list of error messages 
for all platforms. I guess we just need to add more cases here if someone shows 
up with a platform that doesn't match any of these... Could you leave a comment 
on each case explaining what platforms it covers?
   
   Added.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

[PR] fix: Make `serialize_to_file` test cross platform [datafusion]

2026-02-04 Thread via GitHub 


nuno-faria opened a new pull request, #20147:
URL: https://github.com/apache/datafusion/pull/20147

   ## Which issue does this PR close?
   
   - N/A.
   
   ## Rationale for this change
   
   Make the `serialize_to_file` substrait test work on different platforms.
   
   ## What changes are included in this PR?
   
   - Updated `serialize_to_file`.
   
   ## Are these changes tested?
   
   Yes.
   
   ## Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]