Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
adriangb commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3954435268 Yeah let's skip this one šš» -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
nuno-faria commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3954323414 @alamb I wouldn't mind having #20192 in branch-52, but mostly because of the plan optimization. However, since this is a performance improvement/new feature (and also I don't think the bug itself is a regression, it was probably there ever since dynamic filters were added), I would say to disregard it for the next minor release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
alamb commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3953109363 > [@alamb](https://github.com/alamb) we always have the option of not backporting this. I'll let [@jackkleeman](https://github.com/jackkleeman) decide but my gut feeling is it may be risky to backport a partial version of this change (fix one thing, break two...) Yeah, I agree the change in https://github.com/apache/datafusion/pull/20192 seems much more than just a bug fix (it is like the bug got fixed as a side effect of a new feature) I suppose we can also investigate just a fix for this issue (but I am not sure if we have anyone who is willing to do that) @nuno-faria do you have any insight / suggestion on how to proceed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
adriangb commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3947328943 @alamb we always have the option of not backporting this. I'll let @jackkleeman decide but my gut feeling is it may be risky to backport a partial version of this change (fix one thing, break two...) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
alamb commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3947306676 This issue is flagged as needing a backport to branch-52 (this commend by @adriangb : https://github.com/apache/datafusion/issues/20287#issuecomment-3884413096) However, the corresponding PR seems to contain some non trivial changes beyond just a bugfix (and doesn't backport cleanly). Can somone help be backport this to the branch-52 line? - https://github.com/apache/datafusion/pull/20192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
nuno-faria closed issue #20213: Dynamic filter applied to the wrong table when using subqueries URL: https://github.com/apache/datafusion/issues/20213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
nuno-faria commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3914128798 Fixed by #20192. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
aryash45 commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3888620827 well that's convincing hope you and the team find the bug soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
adriangb commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3888480732 I'm not 100% sure what the bug is - figuring that out is the hard part and so if I have to figure out the bug and then tell you what it is that's not very helpful. I'm just being honest. This is probably too hard of an issue for someone not familiar with the codebase to pick up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
aryash45 commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3888473850 Hey @adriangb can I still work on this .Your response would be beneficial also can you clarify what exact Bug is causing this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
adriangb commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3887558754 Weird. Iām not sure off the top of my head why this is happening. Iād have to dig into the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
nuno-faria commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3887409342 Thanks for your interest @aryash45. However, this might require deep knowledge of the codebase to solve. I think it's better to wait for @adriangb's input first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
aryash45 commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3883361522 can i work on this @nuno-faria -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [I] Dynamic filter applied to the wrong table when using subqueries [datafusion]
Zakir032002 commented on issue #20213: URL: https://github.com/apache/datafusion/issues/20213#issuecomment-3879720048 Heyy @nuno-faria , Since this is unassigned, I'd like to work on a fix for it. Please let me know if you intended to handle it as part of your other PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
