Re: [PR] Deprecate invoke and invoke_no_args in favor of invoke_batch [datafusion]
alamb merged PR #13174: URL: https://github.com/apache/datafusion/pull/13174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Deprecate invoke and invoke_no_args in favor of invoke_batch [datafusion]
alamb commented on PR #13174: URL: https://github.com/apache/datafusion/pull/13174#issuecomment-2455508500 Looks good -- thanks @findepi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Deprecate invoke and invoke_no_args in favor of invoke_batch [datafusion]
findepi commented on PR #13174: URL: https://github.com/apache/datafusion/pull/13174#issuecomment-2455178661 cc @comphead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Deprecate invoke and invoke_no_args in favor of invoke_batch [datafusion]
findepi commented on PR #13174: URL: https://github.com/apache/datafusion/pull/13174#issuecomment-2454644334 Pushed a commit fixing logical conflict with https://github.com/apache/datafusion/pull/13130 that was merged recently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Deprecate invoke and invoke_no_args in favor of invoke_batch [datafusion]
findepi commented on PR #13174: URL: https://github.com/apache/datafusion/pull/13174#issuecomment-2453554138 > I think we could file a ticket (good first issue) for migrating the rest of the built in functions (removing the #allow_deprecated) https://github.com/apache/datafusion/issues/13238 please add a label -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Deprecate invoke and invoke_no_args in favor of invoke_batch [datafusion]
alamb commented on code in PR #13174:
URL: https://github.com/apache/datafusion/pull/13174#discussion_r1826968605
##
datafusion/expr/src/udf.rs:
##
@@ -489,19 +493,40 @@ pub trait ScalarUDFImpl: Debug + Send + Sync {
/// Invoke the function with `args` and the number of rows,
/// returning the appropriate result.
+///
+/// The function will be invoked with the slice of [`ColumnarValue`]
Review Comment:
❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Deprecate invoke and invoke_no_args in favor of invoke_batch [datafusion]
findepi commented on PR #13174: URL: https://github.com/apache/datafusion/pull/13174#issuecomment-2453139285 https://github.com/apache/datafusion/pull/13179 deprecated functions in ScalarUDF, this PR deprecates equivalent functions in ScalarUDFImpl trait. @comphead please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] Deprecate invoke and invoke_no_args in favor of invoke_batch [datafusion]
findepi commented on PR #13174: URL: https://github.com/apache/datafusion/pull/13174#issuecomment-2446097197 This requires lots of changes, so let's do this incrementally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
