Re: [PR] Revert "fix: create file for empty stream" [datafusion]

2025-07-08 Thread via GitHub


alamb commented on PR #16682:
URL: https://github.com/apache/datafusion/pull/16682#issuecomment-3050188171

   > @alamb @brunal sorry for inconvenience, revert it is ok. I'm trying to 
find a new way to implement this feature.
   
   Thank you @brunal and @chenkovsky 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Revert "fix: create file for empty stream" [datafusion]

2025-07-08 Thread via GitHub


alamb merged PR #16682:
URL: https://github.com/apache/datafusion/pull/16682


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Revert "fix: create file for empty stream" [datafusion]

2025-07-08 Thread via GitHub


chenkovsky commented on PR #16682:
URL: https://github.com/apache/datafusion/pull/16682#issuecomment-3049753756

   @alamb @brunal  sorry for inconvenience, revert it is ok. I'm trying to find 
a new way to implement this feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Revert "fix: create file for empty stream" [datafusion]

2025-07-07 Thread via GitHub


brunal commented on PR #16682:
URL: https://github.com/apache/datafusion/pull/16682#issuecomment-3047584092

   Apologies for that; it's now fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Revert "fix: create file for empty stream" [datafusion]

2025-07-07 Thread via GitHub


alamb commented on PR #16682:
URL: https://github.com/apache/datafusion/pull/16682#issuecomment-3046616782

   The CI tests seem to have some problems unfortunately


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Revert "fix: create file for empty stream" [datafusion]

2025-07-07 Thread via GitHub


brunal commented on PR #16682:
URL: https://github.com/apache/datafusion/pull/16682#issuecomment-3046224891

   Indeed! I have just updated the revert commit with this test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]



Re: [PR] Revert "fix: create file for empty stream" [datafusion]

2025-07-07 Thread via GitHub


alamb commented on PR #16682:
URL: https://github.com/apache/datafusion/pull/16682#issuecomment-3044670474

   Looks like there may be a test in 
   
   
https://github.com/brunal/datafusion/commit/aed5316583ecae7901d9596039ca4bfe7cd48811


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]