Re: [PR] Test Duration in aggregation `fuzz` tests [datafusion]
alamb commented on PR #16111: URL: https://github.com/apache/datafusion/pull/16111#issuecomment-2897830636 Thank you @zhuqi-lucas and @2010YOUY01 for the reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Test Duration in aggregation `fuzz` tests [datafusion]
alamb merged PR #16111: URL: https://github.com/apache/datafusion/pull/16111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Test Duration in aggregation `fuzz` tests [datafusion]
zhuqi-lucas commented on code in PR #16111:
URL: https://github.com/apache/datafusion/pull/16111#discussion_r2097915073
##
test-utils/src/array_gen/random_data.rs:
##
@@ -100,6 +106,15 @@ impl RandomNativeData for IntervalMonthDayNanoType {
}
}
+// Restrict Duration(Seconds) to i64::MIN / 1000 to i64::MAX / 1000 to
+// avoid panics on pretty printing. See
+// https://github.com/apache/arrow-rs/issues/7533
Review Comment:
A good doc for it, thanks @alamb .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
