Re: [PR] Use single file write when an extension is present in the path. [datafusion]

[via GitHub]

sergiimk commented on PR #13079:
URL: https://github.com/apache/datafusion/pull/13079#issuecomment-2465986284

   I suspect this introduced a regression - would appreciate your opinion on 
#13323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] Use single file write when an extension is present in the path. [datafusion]

[via GitHub]

alamb commented on code in PR #13079:
URL: https://github.com/apache/datafusion/pull/13079#discussion_r1826031568


##
datafusion/core/src/datasource/file_format/parquet.rs:
##
@@ -2338,6 +2298,140 @@ mod tests {
 Ok(())
 }
 
+#[tokio::test]

Review Comment:
   This is really nice too



##
datafusion/core/src/datasource/listing/url.rs:
##
@@ -493,4 +506,54 @@ mod tests {
 "path not ends with / - fragment ends with / - not collection",
 );
 }
+
+#[test]
+fn test_file_extension() {

Review Comment:
   Really nice tests 👏 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] Use single file write when an extension is present in the path. [datafusion]

[via GitHub]

alamb commented on PR #13079:
URL: https://github.com/apache/datafusion/pull/13079#issuecomment-2452205664

   Here is a small follow on PR to add some more docs 
https://github.com/apache/datafusion/pull/13216 (really get the great writeup 
you did on this PR into the code0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] Use single file write when an extension is present in the path. [datafusion]

[via GitHub]

alamb merged PR #13079:
URL: https://github.com/apache/datafusion/pull/13079


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Re: [PR] Use single file write when an extension is present in the path. [datafusion]

[via GitHub]

alamb commented on PR #13079:
URL: https://github.com/apache/datafusion/pull/13079#issuecomment-2447795380

   Thanks @dhegberg  -- I plan to review this later today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org