Re: [PR] WIP: Update to sqlparser-rs 0.52.0 pre-release [datafusion]
alamb commented on PR #13282: URL: https://github.com/apache/datafusion/pull/13282#issuecomment-2473730157 Closing in favor of https://github.com/apache/datafusion/pull/13373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] WIP: Update to sqlparser-rs 0.52.0 pre-release [datafusion]
alamb closed pull request #13282: WIP: Update to sqlparser-rs 0.52.0 pre-release URL: https://github.com/apache/datafusion/pull/13282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
Re: [PR] WIP: Update to sqlparser-rs 0.52.0 pre-release [datafusion]
alamb commented on code in PR #13282:
URL: https://github.com/apache/datafusion/pull/13282#discussion_r1831787428
##
datafusion/sqllogictest/test_files/distinct_on.slt:
##
@@ -153,7 +153,7 @@ b 1 29 -18218 994303988 5983957848665088916 204 9489
3275293996 1485709125918647
c 2 1 18109 2033001162 -6513304855495910254 25 43062 1491205016
5863949479783605708 0.110830784 0.929409733247 6WfVFBVGJSQb7FhA7E0lBwdvjfZnSW
# can't distinct on *
-query error DataFusion error: SQL error: ParserError\("Expected: an
expression:, found: \*"\)
+query error DataFusion error: SQL error: ParserError\("Expected: an
expression, found: \*"\)
Review Comment:
error messages improved wiht
https://github.com/apache/datafusion-sqlparser-rs/pull/1434
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
