Re: [PR] chore: Enable Spark SQL tests for auto scan mode [WIP] [datafusion-comet]
andygrove commented on PR #1885: URL: https://github.com/apache/datafusion-comet/pull/1885#issuecomment-2986043502 The fix for the test failure is in https://github.com/apache/datafusion-comet/pull/1910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Enable Spark SQL tests for auto scan mode [WIP] [datafusion-comet]
andygrove commented on PR #1885: URL: https://github.com/apache/datafusion-comet/pull/1885#issuecomment-2985133841 There is one failing test now: ``` 2025-06-18T03:17:40.7898969Z [info] - SPARK-17091: Convert IN predicate to Parquet filter push-down *** FAILED *** (235 milliseconds) 2025-06-18T03:17:40.7901568Z [info] 1 was not greater than 1 (ParquetFilterSuite.scala:1810) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Enable Spark SQL tests for auto scan mode [WIP] [datafusion-comet]
andygrove commented on PR #1885: URL: https://github.com/apache/datafusion-comet/pull/1885#issuecomment-2981585283 The failing tests are already ignored when the scan is explicitly set to native, but this does not work with `auto`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Enable Spark SQL tests for auto scan mode [WIP] [datafusion-comet]
andygrove commented on PR #1885: URL: https://github.com/apache/datafusion-comet/pull/1885#issuecomment-2981283418 Current failures: Some assertions failing in filter pushdown tests: - Filters should be pushed down for vectorized Parquet reader at row group level - filter pushdown - StringPredicate - SPARK-17091: Convert IN predicate to Parquet filter push-down - SPARK-34562: Bloom filter push down One correctness issue: - SPARK-26677: negated null-safe equality comparison should not filter matched row groups *** FAILED *** ``` !== Correct Answer - 3 == == Spark Answer - 1 ==[0m[0m struct struct[0m[0m ![A][null] ![A][0m[0m ![null] (QueryTest.scala:244)[0m[0m ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Enable Spark SQL tests for auto scan mode [WIP] [datafusion-comet]
codecov-commenter commented on PR #1885: URL: https://github.com/apache/datafusion-comet/pull/1885#issuecomment-2971547836 ## [Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1885?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report All modified and coverable lines are covered by tests :white_check_mark: > Project coverage is 33.22%. Comparing base [(`f09f8af`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/f09f8af64c6599255e116a376f4f008f2fd63b43?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`ae23bee`)](https://app.codecov.io/gh/apache/datafusion-comet/commit/ae23bee91679cb2754ff852c53015566314ecdd7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 258 commits behind head on main. Additional details and impacted files ```diff @@ Coverage Diff @@ ## main#1885 +/- ## = - Coverage 56.12% 33.22% -22.91% + Complexity 976 803 -173 = Files 119 130 +11 Lines 1174312789 +1046 Branches 2251 2403 +152 = - Hits 6591 4249 -2342 - Misses 4012 7586 +3574 + Partials 1140 954 -186 ``` [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/datafusion-comet/pull/1885?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
