Re: [PR] chore: Enable Spark SQL tests for auto scan mode [datafusion-comet]
andygrove merged PR #1885: URL: https://github.com/apache/datafusion-comet/pull/1885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] chore: Enable Spark SQL tests for auto scan mode [datafusion-comet]
andygrove commented on code in PR #1885:
URL: https://github.com/apache/datafusion-comet/pull/1885#discussion_r2165064746
##
.github/workflows/spark_sql_test_native_auto.yml:
##
@@ -35,7 +45,7 @@ jobs:
matrix:
os: [ubuntu-24.04]
java-version: [11]
-spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full:
'3.5.5'}]
+spark-version: [{short: '3.5', full: '3.5.6'}]
Review Comment:
I was concerned with adding more overhead in CI testing for each PR, but I
will revert this change, and we can monitor the situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] chore: Enable Spark SQL tests for auto scan mode [datafusion-comet]
kazuyukitanimura commented on code in PR #1885:
URL: https://github.com/apache/datafusion-comet/pull/1885#discussion_r2165034490
##
.github/workflows/spark_sql_test_native_auto.yml:
##
@@ -35,7 +45,7 @@ jobs:
matrix:
os: [ubuntu-24.04]
java-version: [11]
-spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full:
'3.5.5'}]
+spark-version: [{short: '3.5', full: '3.5.6'}]
Review Comment:
Hmmm but there is a 3.4.3 diff change with this PR? Should we just keep it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] chore: Enable Spark SQL tests for auto scan mode [datafusion-comet]
andygrove commented on code in PR #1885:
URL: https://github.com/apache/datafusion-comet/pull/1885#discussion_r2162321152
##
.github/workflows/spark_sql_test_native_auto.yml:
##
@@ -35,7 +45,7 @@ jobs:
matrix:
os: [ubuntu-24.04]
java-version: [11]
-spark-version: [{short: '3.4', full: '3.4.3'}, {short: '3.5', full:
'3.5.5'}]
+spark-version: [{short: '3.5', full: '3.5.6'}]
Review Comment:
We run tests for `native_comet` and `native_iceberg_compat` with Spark 3.4.3
and 3.5.6 already. When running in `auto` mode we will pick either
`native_comet` or `native_iceberg_compat`, so it seems redundant to also run
these tests with both Spark versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
