Re: [PR] [compress] Add an option to do not compress partial object [trafficserver]
cmcfarlen commented on PR #12121: URL: https://github.com/apache/trafficserver/pull/12121#issuecomment-2936602032 This was added to milestone 10.1.x via #12258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [compress] Add an option to do not compress partial object [trafficserver]
masaori335 merged PR #12121: URL: https://github.com/apache/trafficserver/pull/12121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [compress] Add an option to do not compress partial object [trafficserver]
masaori335 commented on PR #12121: URL: https://github.com/apache/trafficserver/pull/12121#issuecomment-2791527444 [approve ci autest 1of4] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [compress] Add an option to do not compress partial object [trafficserver]
masaori335 commented on PR #12121: URL: https://github.com/apache/trafficserver/pull/12121#issuecomment-2784972772 Rebased on the latest master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [compress] Add an option to do not compress partial object [trafficserver]
masaori335 commented on code in PR #12121:
URL: https://github.com/apache/trafficserver/pull/12121#discussion_r2032215967
##
plugins/compress/configuration.cc:
##
@@ -270,16 +270,22 @@ HostConfiguration::compression_algorithms()
return compression_algorithms_;
}
+/**
+ "true" and "false" are compatibility with old version, will be removed
+ */
void
HostConfiguration::set_range_request(const std::string &token)
{
- // "true" and "false" are compatibility with old version, will be removed
- if (token == "false" || token == "ignore-range") {
-range_request_ctl_ = RangeRequestCtrl::IGNORE_RANGE;
- } else if (token == "true" || token == "none") {
+ if (token == "true" || token == "none") {
range_request_ctl_ = RangeRequestCtrl::NONE;
- } else if (token == "no-compression") {
+ } else if (token == "false" || token == "no-compression") {
Review Comment:
It's introduced by https://github.com/apache/trafficserver/pull/11975
recently and not released yet. ( only master and 10.1.x branch have it ). So no
compatibility issue yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [compress] Add an option to do not compress partial object [trafficserver]
bryancall commented on code in PR #12121:
URL: https://github.com/apache/trafficserver/pull/12121#discussion_r2028978473
##
plugins/compress/configuration.cc:
##
@@ -270,16 +270,22 @@ HostConfiguration::compression_algorithms()
return compression_algorithms_;
}
+/**
+ "true" and "false" are compatibility with old version, will be removed
+ */
void
HostConfiguration::set_range_request(const std::string &token)
{
- // "true" and "false" are compatibility with old version, will be removed
- if (token == "false" || token == "ignore-range") {
-range_request_ctl_ = RangeRequestCtrl::IGNORE_RANGE;
- } else if (token == "true" || token == "none") {
+ if (token == "true" || token == "none") {
range_request_ctl_ = RangeRequestCtrl::NONE;
- } else if (token == "no-compression") {
+ } else if (token == "false" || token == "no-compression") {
Review Comment:
Should you still support `ignore-range` for compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [compress] Add an option to do not compress partial object [trafficserver]
masaori335 commented on code in PR #12121:
URL: https://github.com/apache/trafficserver/pull/12121#discussion_r2009524055
##
plugins/compress/compress.cc:
##
@@ -733,6 +737,26 @@ transformable(TSHttpTxn txnp, bool server,
HostConfiguration *host_configuration
return 0;
}
+ // check Partial Object is transformable
+ if (host_configuration->range_request_ctl() ==
RangeRequestCtrl::NO_COMPRESSION) {
Review Comment:
This block restores code prior to the PR #11975 and add another check of
`Content-Range` header in server response. Because `cache_range_request` might
remove `Range` header from client request.
https://github.com/apache/trafficserver/pull/11975/files#diff-a50782f349c34e95c6c8643b834aaeba685f244f78a645e85a402bbda9012fb6L680-L689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
