Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD
--+-
Reporter: bgamari | Owner:
Type: bug | Status: closed
Priority: normal | Milestone: 7.8.1
Component: Compiler |Version: 7.7
Resolution: fixed| Keywords:
Os: Unknown/Multiple | Architecture: Unknown/Multiple
Failure: Building GHC failed | Difficulty: Unknown
Testcase: | Blockedby:
Blocking: |Related:
--+-
Comment(by marlowsd@…):
commit 3a6b1bfb08602a8193b0025f0fe47ec8ddf8dad2
{{{
Author: Simon Marlow marlo...@gmail.com
Date: Fri Oct 26 11:12:49 2012 +0100
Turn on -O2 for the RTS by default
Optimisation now makes a difference when compiling .cmm code, because
it enables the optimisation passes in CmmPipeline. Recently validate
has not been optimising the .cmm code because it uses SRC_HC_OPTS=-O0,
which explains why I couldn't reproduce #7366 in validate (the bug
miscompiled rts/PrimOps.cmm).
mk/config.mk.in |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
}}}
--
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:13
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD -+-- Reporter: bgamari | Owner: simonmar Type: bug | Status: new Priority: normal| Milestone: Component: Compiler | Version: Keywords:| Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: Building GHC failed Difficulty: Unknown |Testcase: Blockedby:|Blocking: Related:| -+-- Changes (by simonmar): * difficulty: = Unknown Comment: What platform and build settings? -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD
-+--
Reporter: bgamari | Owner: simonmar
Type: bug | Status: new
Priority: normal| Milestone:
Component: Compiler | Version:
Keywords:| Os: Unknown/Multiple
Architecture: Unknown/Multiple | Failure: Building GHC failed
Difficulty: Unknown |Testcase:
Blockedby:|Blocking:
Related:|
-+--
Comment(by marlowsd@…):
commit 24b4bfbcb320670a62dad10009d43f06211a5a2a
{{{
Author: Simon Marlow marlo...@gmail.com
Date: Thu Oct 25 09:25:49 2012 +0100
Fix bug in 88a6f863d9f127fc1b03a1e2f068fd20ecbe096c (#7366)
compiler/cmm/CmmSink.hs | 40
1 files changed, 20 insertions(+), 20 deletions(-)
}}}
--
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:7
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD --+- Reporter: bgamari | Owner: simonmar Type: bug | Status: closed Priority: normal | Milestone: 7.8.1 Component: Compiler |Version: 7.7 Resolution: fixed| Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Building GHC failed | Difficulty: Unknown Testcase: | Blockedby: Blocking: |Related: --+- Changes (by simonmar): * status: new = closed * version: = 7.7 * resolution: = fixed * milestone: = 7.8.1 Comment: So I haven't yet been able to reproduce the bug, but I think I know what it is so I've committed a speculative fix. I'll optimistically close the bug, please re-open if it still occurs. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD --+- Reporter: bgamari | Owner: simonmar Type: bug | Status: closed Priority: normal | Milestone: 7.8.1 Component: Compiler |Version: 7.7 Resolution: fixed| Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Building GHC failed | Difficulty: Unknown Testcase: | Blockedby: Blocking: |Related: --+- Comment(by bgamari): Thanks! I'm doing a test build right now. Both machines I was able to reproduce on are x86_64 running some variant of Linux (one running a 2.6.31 kernel, the other 3.7). -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD --+- Reporter: bgamari | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.8.1 Component: Compiler |Version: 7.7 Resolution: | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Building GHC failed | Difficulty: Unknown Testcase: | Blockedby: Blocking: |Related: --+- Changes (by simonmar): * owner: simonmar = * status: closed = new * resolution: fixed = Comment: I do have a repro in one of my builds, but the patch didn't fix it. Re- opening. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD
--+-
Reporter: bgamari | Owner:
Type: bug | Status: new
Priority: normal | Milestone: 7.8.1
Component: Compiler |Version: 7.7
Resolution: | Keywords:
Os: Unknown/Multiple | Architecture: Unknown/Multiple
Failure: Building GHC failed | Difficulty: Unknown
Testcase: | Blockedby:
Blocking: |Related:
--+-
Comment(by marlowsd@…):
commit c588395719241c4b5756bd8d60dbf822915dfc5b
{{{
Author: Simon Marlow marlo...@gmail.com
Date: Thu Oct 25 16:18:36 2012 +0100
Fix a bug in CmmSink exposed by a recent optimisation (#7366)
compiler/cmm/CmmSink.hs | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
}}}
--
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:11
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD --+- Reporter: bgamari | Owner: Type: bug | Status: closed Priority: normal | Milestone: 7.8.1 Component: Compiler |Version: 7.7 Resolution: fixed| Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Building GHC failed | Difficulty: Unknown Testcase: | Blockedby: Blocking: |Related: --+- Changes (by simonmar): * status: new = closed * resolution: = fixed Comment: Now fixed, I believe. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:12 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD
-+--
Reporter: bgamari | Owner:
Type: bug | Status: new
Priority: normal | Component: Compiler
Version: | Keywords:
Os: Unknown/Multiple | Architecture: Unknown/Multiple
Failure: Building GHC failed | Testcase:
Blockedby: | Blocking:
Related: |
-+--
Comment(by bgamari):
To be clear, this is the output of make stage=1 (which was omitted from
the run cited previously),
{{{
$ make stage=1
../mk/boilerplate.mk:149: ../mk
/ghcconfig_m_vinci7_data1_dietz_ghc_ghc_inplace_bin_ghc-stage1.mk: No such
file or directory
../mk/ghc-config /m/vinci7/data1/dietz/ghc/ghc/inplace/bin/ghc-stage1
../mk/ghcconfig_m_vinci7_data1_dietz_ghc_ghc_inplace_bin_ghc-stage1.mk;
if [ $? != 0 ]; then rm -f ../mk
/ghcconfig_m_vinci7_data1_dietz_ghc_ghc_inplace_bin_ghc-stage1.mk; exit
1; fi
ghc-config: ���美
make: *** [../mk/ghcconfig_m_vinci7_data1_dietz_ghc_ghc_inplace_bin_ghc-
stage1.mk] Error 1
}}}
--
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:1
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD -+-- Reporter: bgamari | Owner: Type: bug | Status: new Priority: normal | Component: Compiler Version: | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Building GHC failed | Testcase: Blockedby: | Blocking: Related: | -+-- Changes (by bgamari): * cc: bgamari@… (added) Comment: I have now reproduced this on two machines. I believe the regression occurred sometime between 176a360 and 0b3811c. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD
-+--
Reporter: bgamari | Owner:
Type: bug | Status: new
Priority: normal | Component: Compiler
Version: | Keywords:
Os: Unknown/Multiple | Architecture: Unknown/Multiple
Failure: Building GHC failed | Testcase:
Blockedby: | Blocking:
Related: |
-+--
Comment(by bgamari):
Here is my bisection log.
{{{
git bisect start
# good: [176a360031e1e7ef4d49ff18f1dd3e32ce4f56d9] Fix typo
git bisect good 176a360031e1e7ef4d49ff18f1dd3e32ce4f56d9
# bad: [0b3811c093736950c1d2757fb12dba60f9bf97ca] typo
git bisect bad 0b3811c093736950c1d2757fb12dba60f9bf97ca
# good: [2c2be637206cb1d58f4fc8a4a2e717e419c9fa5d] comments only
git bisect good 2c2be637206cb1d58f4fc8a4a2e717e419c9fa5d
# bad: [88a6f863d9f127fc1b03a1e2f068fd20ecbe096c] Small optimisation:
always sink/inline reg1 = reg2 assignments
git bisect bad 88a6f863d9f127fc1b03a1e2f068fd20ecbe096c
# good: [2471a6bacccdf4d187aa4b31c382d5a5094b6fa5] Use canned heap checks
to save a few bytes of code
git bisect good 2471a6bacccdf4d187aa4b31c382d5a5094b6fa5
# good: [2324b40f65b5cb7e427c5ec0185d635422b4a265] removeWay should also
unset the wayGeneralFlags
git bisect good 2324b40f65b5cb7e427c5ec0185d635422b4a265
# good: [a7e0d4484189d08125083638582a6f8e4ae44801] a small -fPIC
optimisation
git bisect good a7e0d4484189d08125083638582a6f8e4ae44801
}}}
It seems that the first bad commit is,
{{{
commit 88a6f863d9f127fc1b03a1e2f068fd20ecbe096c
Author: Simon Marlow marlo...@gmail.com
Date: Tue Oct 23 13:06:17 2012 +0100
Small optimisation: always sink/inline reg1 = reg2 assignments
}}}
--
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:3
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD -+-- Reporter: bgamari | Owner: smarlow Type: bug | Status: new Priority: normal | Component: Compiler Version: | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Building GHC failed | Testcase: Blockedby: | Blocking: Related: | -+-- Changes (by bgamari): * owner: = smarlow -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7366: Strange data corruption with HEAD
#7366: Strange data corruption with HEAD -+-- Reporter: bgamari | Owner: simonmar Type: bug | Status: new Priority: normal | Component: Compiler Version: | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Building GHC failed | Testcase: Blockedby: | Blocking: Related: | -+-- Changes (by bgamari): * owner: smarlow = simonmar -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7366#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
