Re: [GHC] #7419: hpc markup should accept multiple .mix file search paths
#7419: hpc markup should accept multiple .mix file search paths ---+ Reporter: ttuegel | Owner: igloo Type: feature request | Status: closed Priority: highest | Milestone: 7.8.1 Component: Code Coverage |Version: 7.6.1 Resolution: fixed | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Difficulty: Unknown Testcase:| Blockedby: Blocking:|Related: ---+ Changes (by igloo): * status: patch = closed * resolution: = fixed Comment: Applied, and docs updated, thanks! -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7419#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7419: hpc markup should accept multiple .mix file search paths
#7419: hpc markup should accept multiple .mix file search paths -+-- Reporter: ttuegel | Owner: igloo Type: feature request | Status: patch Priority: highest | Milestone: 7.8.1 Component: Code Coverage | Version: 7.6.1 Keywords:| Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown |Testcase: Blockedby:|Blocking: Related:| -+-- Changes (by simonpj): * owner: = igloo * difficulty: = Unknown * priority: normal = highest * milestone: = 7.8.1 Comment: Ian, I don't know the details of this one, but since the authors have been kind enough to develop a patch, could you review and (presumably) commit for 7.8, please? I have not looked, but does the patch include suitable documentation in the user manual? Simon -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7419#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7419: hpc markup should accept multiple .mix file search paths
#7419: hpc markup should accept multiple .mix file search paths -+-- Reporter: ttuegel | Owner: Type: feature request | Status: patch Priority: normal| Component: Code Coverage Version: 7.6.1 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking:|Related: -+-- Comment(by tibbe): Anything else you need form us? I'd like to see this in 7.8. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7419#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7419: hpc markup should accept multiple .mix file search paths
#7419: hpc markup should accept multiple .mix file search paths -+-- Reporter: ttuegel | Owner: Type: feature request | Status: patch Priority: normal| Component: Compiler Version: 7.6.1 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking:|Related: -+-- Comment(by ttuegel): The .mix file must not be found in multiple locations: the hpc library considers it an error for multiple .mix files to match. This sounds more constraining than it actually is, because matching is based on module name and a hash; one should only get multiple matches if the same file is checked twice. (If you do {{{ hpc --hpc-dir=A --hpc-dir=B }}}, hpc will search in the order you specified the directories, but it always searches all the paths.) -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7419#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7419: hpc markup should accept multiple .mix file search paths
#7419: hpc markup should accept multiple .mix file search paths -+-- Reporter: ttuegel | Owner: Type: feature request | Status: patch Priority: normal| Component: Code Coverage Version: 7.6.1 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking:|Related: -+-- Changes (by tibbe): * component: Compiler = Code Coverage Comment: Thanks for clarifying. The code looks good to me. Please merge. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7419#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7419: hpc markup should accept multiple .mix file search paths
#7419: hpc markup should accept multiple .mix file search paths -+-- Reporter: ttuegel | Owner: Type: feature request | Status: patch Priority: normal| Component: Compiler Version: 7.6.1 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking:|Related: -+-- Changes (by ttuegel): * status: new = patch -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7419#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7419: hpc markup should accept multiple .mix file search paths
#7419: hpc markup should accept multiple .mix file search paths -+-- Reporter: ttuegel | Owner: Type: feature request | Status: patch Priority: normal| Component: Compiler Version: 7.6.1 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Blockedby: Blocking:|Related: -+-- Changes (by tibbe): * cc: johan.tibell@… (added) Comment: One question: {{{ (\ a f - f { hpcDirs = hpcDirs f ++ [a] }) }}} Is there an implied search order here, if the same info could be found in multiple directories? If I do {{{ hpc --hpc-dir=A --hpc-dir=B }}} Which one takes precedence? Which one should take precedence? I guess we should mimic e.g. how GHC treats multiple `-i` flags. Patch looks good otherwise. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7419#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs