Re: [GHC] #7518: Instruction list length in bco-instrs redundant
#7518: Instruction list length in bco-instrs redundant -+-- Reporter: nomeata | Owner: simonmar Type: task | Status: infoneeded Priority: normal| Milestone: Component: Runtime System| Version: 7.6.1 Keywords:| Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown |Testcase: Blockedby:|Blocking: Related:| -+-- Changes (by simonmar): * status: new = infoneeded Comment: Could you point me to the bit of the code you're talking about? I can't find it. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7518#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7518: Instruction list length in bco-instrs redundant
#7518: Instruction list length in bco-instrs redundant
-+--
Reporter: nomeata | Owner: simonmar
Type: task | Status: new
Priority: normal| Milestone:
Component: Runtime System| Version: 7.6.1
Keywords:| Os: Unknown/Multiple
Architecture: Unknown/Multiple | Failure: None/Unknown
Difficulty: Unknown |Testcase:
Blockedby:|Blocking:
Related:|
-+--
Changes (by nomeata):
* status: infoneeded = new
Comment:
Certainly:
Here, the first element of the instruction list is used to find
{{{nbcd}}}:
http://hackage.haskell.org/trac/ghc/browser/rts/Disassembler.c#L276
The interpreter ignores the value (unless debugging is on):
http://hackage.haskell.org/trac/ghc/browser/rts/Interpreter.c#L789
And here, in assembleBCO, the number of instruction is prepended to the
list of instructions:
http://hackage.haskell.org/trac/ghc/browser/compiler/ghci/ByteCodeAsm.lhs#L156
The assertion in line 161 supports the observation that the information is
duplicated and the size of the ByteArray is correct.
--
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7518#comment:3
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7518: Instruction list length in bco-instrs redundant
#7518: Instruction list length in bco-instrs redundant -+-- Reporter: nomeata | Owner: simonmar Type: task | Status: new Priority: normal| Milestone: 7.8.1 Component: Runtime System| Version: 7.6.1 Keywords:| Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown |Testcase: Blockedby:|Blocking: Related:| -+-- Changes (by simonmar): * milestone: = 7.8.1 Comment: Ah, I see. Yes, I think you're right, this field isn't necessary. It is probably there because the size of an `StgArrWords` used to be stored in units of words, but it was changed to be bytes. I'll remove it. -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7518#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7518: Instruction list length in bco-instrs redundant
#7518: Instruction list length in bco-instrs redundant
-+--
Reporter: nomeata | Owner: simonmar
Type: task | Status: new
Priority: normal| Milestone: 7.8.1
Component: Runtime System| Version: 7.6.1
Keywords:| Os: Unknown/Multiple
Architecture: Unknown/Multiple | Failure: None/Unknown
Difficulty: Unknown |Testcase:
Blockedby:|Blocking:
Related:|
-+--
Comment(by marlowsd@…):
commit 0c42e301337bdefa94d0c288bb6d689ac33baa4d
{{{
Author: Simon Marlow marlo...@gmail.com
Date: Wed Jan 9 11:51:58 2013 +
remove unnecessary size field in BCO (#7518)
compiler/ghci/ByteCodeAsm.lhs |8 ++--
rts/Interpreter.c |4 +---
2 files changed, 3 insertions(+), 9 deletions(-)
}}}
--
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7518#comment:5
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7518: Instruction list length in bco-instrs redundant
#7518: Instruction list length in bco-instrs redundant -+-- Reporter: nomeata | Owner: simonmar Type: task | Status: merge Priority: normal| Milestone: 7.8.1 Component: Runtime System| Version: 7.6.1 Keywords:| Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown |Testcase: Blockedby:|Blocking: Related:| -+-- Changes (by simonmar): * status: new = merge -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7518#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7518: Instruction list length in bco-instrs redundant
#7518: Instruction list length in bco-instrs redundant ---+ Reporter: nomeata | Owner: Type: task | Status: new Priority: normal| Milestone: 7.8.1 Component: Runtime System|Version: 7.6.1 Resolution:| Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Difficulty: Unknown Testcase:| Blockedby: Blocking:|Related: ---+ Changes (by simonmar): * owner: simonmar = * status: merge = new -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7518#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7518: Instruction list length in bco-instrs redundant
#7518: Instruction list length in bco-instrs redundant ---+ Reporter: nomeata | Owner: Type: task | Status: closed Priority: normal| Milestone: 7.8.1 Component: Runtime System|Version: 7.6.1 Resolution: fixed | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Difficulty: Unknown Testcase:| Blockedby: Blocking:|Related: ---+ Changes (by simonmar): * status: new = closed * resolution: = fixed -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7518#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7518: Instruction list length in bco-instrs redundant
#7518: Instruction list length in bco-instrs redundant ---+ Reporter: nomeata | Owner: Type: task | Status: closed Priority: normal| Milestone: 7.8.1 Component: Runtime System|Version: 7.6.1 Resolution: fixed | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Difficulty: Unknown Testcase:| Blockedby: Blocking:|Related: ---+ Comment(by nomeata): It seems you missed the code in Disassembler.c -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7518#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7518: Instruction list length in bco-instrs redundant
#7518: Instruction list length in bco-instrs redundant
---+
Reporter: nomeata | Owner:
Type: task | Status: closed
Priority: normal| Milestone: 7.8.1
Component: Runtime System|Version: 7.6.1
Resolution: fixed | Keywords:
Os: Unknown/Multiple | Architecture: Unknown/Multiple
Failure: None/Unknown | Difficulty: Unknown
Testcase:| Blockedby:
Blocking:|Related:
---+
Comment(by marlowsd@…):
commit 343548da7274cd15aaeabe72c6b37bce78e9af9c
{{{
Author: Simon Marlow marlo...@gmail.com
Date: Wed Jan 9 14:46:03 2013 +
fix disassembler after removal of size field in bco-instrs (#7518)
rts/Disassembler.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
}}}
--
Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7518#comment:10
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
___
Glasgow-haskell-bugs mailing list
Glasgow-haskell-bugs@haskell.org
http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
Re: [GHC] #7518: Instruction list length in bco-instrs redundant (was: Instruction list length in bco-instrs redundand)
#7518: Instruction list length in bco-instrs redundant -+-- Reporter: nomeata | Owner: simonmar Type: task | Status: new Priority: normal| Milestone: Component: Runtime System| Version: 7.6.1 Keywords:| Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown |Testcase: Blockedby:|Blocking: Related:| -+-- Changes (by simonpj): * owner: = simonmar * difficulty: = Unknown Comment: Thanks. Simon M is king in that area so I'll assign to him. Simon -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/7518#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler ___ Glasgow-haskell-bugs mailing list Glasgow-haskell-bugs@haskell.org http://www.haskell.org/mailman/listinfo/glasgow-haskell-bugs
