Re: Permitting trailing commas for record syntax ADT declarations

2014-09-29 Thread Richard Eisenberg
To be fair, I'm not sure I like the make-commas-optional approach either. But, the solution occurred to me as possible, so I thought it was worth considering as we're exploring the design space. And, yes, I was suggesting only to make them optional, not to require everyone remove them.

Re: Permitting trailing commas for record syntax ADT declarations

2014-09-29 Thread Edward Kmett
Not a concrete suggestion, but just a related data point / nod to the sanity of the suggestion: I'm not sure I'd remove them entirely either, but FWIW, we don't require commas in fixity declarations in Ermine and it works well. On the other hand, our import lists are rather more complicated than

Re: Permitting trailing commas for record syntax ADT declarations

2014-09-26 Thread John Wiegley
Richard Eisenberg e...@cis.upenn.edu writes: What if we just stopped requiring commas in import/export lists? As far as I can tell, they're not necessary for proper parsing. +1 John ___ Glasgow-haskell-users mailing list

Re: Permitting trailing commas for record syntax ADT declarations

2014-09-26 Thread Johan Tibell
That would be nice if we had a clean slate, but I don't people are going to change their whole import lists now. Adding a comma at the end is less disruptive. On Fri, Sep 26, 2014 at 11:06 PM, John Wiegley jo...@newartisans.com wrote: Richard Eisenberg e...@cis.upenn.edu writes: What if we

Re: Permitting trailing commas for record syntax ADT declarations

2014-09-26 Thread Brandon Allbery
On Fri, Sep 26, 2014 at 5:12 PM, Johan Tibell johan.tib...@gmail.com wrote: That would be nice if we had a clean slate, but I don't people are going to change their whole import lists now. I read the proposal as making all commas optional, not as requiring them to not be present. -- brandon

Re: Permitting trailing commas for record syntax ADT declarations

2014-09-26 Thread Johan Tibell
I don't think that's necessarily is good style. I don't think we want two different ways of doing import lists. The original proposal was to address a quite small but important engineer issue: without allow *one* trailing comma your version control history gets messed up, because the wrong person

Re: Permitting trailing commas for record syntax ADT declarations

2014-09-26 Thread Brandon Allbery
On Fri, Sep 26, 2014 at 5:21 PM, Johan Tibell johan.tib...@gmail.com wrote: I don't think that's necessarily is good style. I don't think we want two different ways of doing import lists. Yes; I kinda hate the idea myself, it encourages an unreadable programming style. But it's not the