Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-09 Thread nini.lasson
Hi David, You have good ideas for GLPI but actually, for me, it's not possible for many reasons : - how review the pull request? For me it's a complete job because you must know very well all framework of GLPI and we are very few to can do that and i agree with Olivier: this job must be

Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-09 Thread David DURIEUX
Yep so 2 validations needed (a '+1' is enough) to merge is ok for all ? David ++ Le Fri, 9 Sep 2016 11:25:09 +0200 (CEST) Johan Cwiklinski a écrit: >Hello, > >> A fix cause less problem in PR, the only things will be the test >> (enough test or not). >> >> But an

Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-09 Thread Johan Cwiklinski
Hello, > A fix cause less problem in PR, the only things will be the test > (enough test or not). > > But an urgent bug fix not mean a release in urgency, so it can be > opened some hours (not some days :p) Agree but anyways, bugfix or not, "urgent" or not ; if the PR is OK and has been

Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-09 Thread Moron, Olivier
to enhance code quality OK for me - Mail original - > De: "Johan Cwiklinski" <jcwiklin...@teclib.com> > À: "Liste de diffusion des developpeurs GLPI" <glpi-dev@gna.org> > Envoyé: Vendredi 9 Septembre 2016 09:35:37 > Objet: Re: [Glpi-dev] Modify codin

Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-09 Thread Alexandre Delaunay
OK for me - Mail original - > De: "Johan Cwiklinski" <jcwiklin...@teclib.com> > À: "Liste de diffusion des developpeurs GLPI" <glpi-dev@gna.org> > Envoyé: Vendredi 9 Septembre 2016 09:35:37 > Objet: Re: [Glpi-dev] Modify coding methods to en

Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-09 Thread Johan Cwiklinski
Hello, > For PR adding a feature / changing a behavior, I think we need to keep > it open before merging for some time (1 day ?) so other developpers can > comment it (e.g. https://github.com/glpi-project/glpi/pull/945) OK for me, let's say PR will stay opened one day. ++ -- Johan

Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-09 Thread Remi Collet
Le 07/09/2016 à 11:16, David DURIEUX a écrit : > Hello, > > I propose new coding methods to enhance GLPI (better code, have > tests, so less bugs): > > * NEVER (so no exceptions) commit directly in the repository, always > create Pull Requests For PR adding a feature / changing a behavior, I

Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-08 Thread Alexandre Delaunay
-dev@gna.org> > Envoyé: Jeudi 8 Septembre 2016 11:17:45 > Objet: Re: [Glpi-dev] Modify coding methods to enhance code quality > > Hello, > > > I propose new coding methods to enhance GLPI (better code, have > > tests, so less bugs): > > [...] > > Two p

Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-07 Thread Moron, Olivier
: [Glpi-dev] Modify coding methods to enhance code quality Hello, - Mail original - > De: "David DURIEUX" <d.duri...@siprossii.com> > À: "Liste de diffusion des developpeurs GLPI" <glpi-dev@gna.org> > Envoyé: Mercredi 7 Septembre 2016 11:16:46

Re: [Glpi-dev] Modify coding methods to enhance code quality

2016-09-07 Thread Johan Cwiklinski
Hello, - Mail original - > De: "David DURIEUX" <d.duri...@siprossii.com> > À: "Liste de diffusion des developpeurs GLPI" <glpi-dev@gna.org> > Envoyé: Mercredi 7 Septembre 2016 11:16:46 > Objet: [Glpi-dev] Modify coding methods to enhance code q