Re: [Gluster-devel] problem with recent change to glfs_realpath

2016-10-21 Thread Michael Adam
On 2016-10-21 at 10:22 +0200, Niels de Vos wrote: > On Fri, Oct 21, 2016 at 01:15:50AM +0200, Michael Adam wrote: > > Hi all, > > > > Anoop has brought to my attention that > > recently glfs_realpath was changed in an incompatible way: > > Interesting, Rajesh and I had an email discussion about t

Re: [Gluster-devel] Possible problem introduced by http://review.gluster.org/15573

2016-10-21 Thread Soumya Koduri
On 10/21/2016 06:35 PM, Soumya Koduri wrote: Hi Xavi, On 10/21/2016 12:57 PM, Xavier Hernandez wrote: Looking at the code, I think that the added fd_unref() should only be called if the fop preparation fails. Otherwise the callback already unreferences the fd. Code flow: * glfs_fsync_async_

Re: [Gluster-devel] Possible problem introduced by http://review.gluster.org/15573

2016-10-21 Thread Atin Mukherjee
On Fri, Oct 21, 2016 at 6:36 PM, Soumya Koduri wrote: > > > On 10/21/2016 02:03 PM, Xavier Hernandez wrote: > >> Hi Niels, >> >> On 21/10/16 10:03, Niels de Vos wrote: >> >>> On Fri, Oct 21, 2016 at 09:03:30AM +0200, Xavier Hernandez wrote: >>> Hi, I've just tried Gluster 3.8.5 wit

Re: [Gluster-devel] Possible problem introduced by http://review.gluster.org/15573

2016-10-21 Thread Soumya Koduri
On 10/21/2016 02:03 PM, Xavier Hernandez wrote: Hi Niels, On 21/10/16 10:03, Niels de Vos wrote: On Fri, Oct 21, 2016 at 09:03:30AM +0200, Xavier Hernandez wrote: Hi, I've just tried Gluster 3.8.5 with Proxmox using gfapi and I consistently see a crash each time an attempt to connect to the

Re: [Gluster-devel] Possible problem introduced by http://review.gluster.org/15573

2016-10-21 Thread Soumya Koduri
Hi Xavi, On 10/21/2016 12:57 PM, Xavier Hernandez wrote: Looking at the code, I think that the added fd_unref() should only be called if the fop preparation fails. Otherwise the callback already unreferences the fd. Code flow: * glfs_fsync_async_common() takes an fd ref and calls STACK_WIND pa

Re: [Gluster-devel] Possible problem introduced by http://review.gluster.org/15573

2016-10-21 Thread Xavier Hernandez
Hi Niels, On 21/10/16 10:03, Niels de Vos wrote: On Fri, Oct 21, 2016 at 09:03:30AM +0200, Xavier Hernandez wrote: Hi, I've just tried Gluster 3.8.5 with Proxmox using gfapi and I consistently see a crash each time an attempt to connect to the volume is made. Thanks, that likely is the same

Re: [Gluster-devel] problem with recent change to glfs_realpath

2016-10-21 Thread Niels de Vos
On Fri, Oct 21, 2016 at 01:15:50AM +0200, Michael Adam wrote: > Hi all, > > Anoop has brought to my attention that > recently glfs_realpath was changed in an incompatible way: Interesting, Rajesh and I had an email discussion about that yesterday too... Unfortunately this (or the Samba) list was

Re: [Gluster-devel] Possible problem introduced by http://review.gluster.org/15573

2016-10-21 Thread Niels de Vos
On Fri, Oct 21, 2016 at 09:03:30AM +0200, Xavier Hernandez wrote: > Hi, > > I've just tried Gluster 3.8.5 with Proxmox using gfapi and I consistently > see a crash each time an attempt to connect to the volume is made. Thanks, that likely is the same bug as https://bugzilla.redhat.com/1379241 .

Re: [Gluster-devel] New commands for supporting add/remove brick and rebalance on tiered volume

2016-10-21 Thread Hari Gowtham
Hi, Currently there are two suggested options for the syntax of add/remove brick: 1) gluster v tier add-brick [replica ] [tier-type ] ... this syntax shows that its a add-brick operation on a tiered volume through a argument instead of distinguishing using the command. The separation of tie

Re: [Gluster-devel] Possible problem introduced by http://review.gluster.org/15573

2016-10-21 Thread Xavier Hernandez
Looking at the code, I think that the added fd_unref() should only be called if the fop preparation fails. Otherwise the callback already unreferences the fd. Code flow: * glfs_fsync_async_common() takes an fd ref and calls STACK_WIND passing that fd. * Just after that a ref is released. * W

[Gluster-devel] Possible problem introduced by http://review.gluster.org/15573

2016-10-21 Thread Xavier Hernandez
Hi, I've just tried Gluster 3.8.5 with Proxmox using gfapi and I consistently see a crash each time an attempt to connect to the volume is made. The backtrace of the crash shows this: #0 pthread_spin_lock () at ../nptl/sysdeps/x86_64/pthread_spin_lock.S:24 #1 0x7fe5345776a5 in fd_unref