[Gluster-devel] tests/basic/pump.t - what is it used for?

2017-09-07 Thread Atin Mukherjee
Pranith, I see you're the author of the test in $Subj. Now while I was working on a patch https://review.gluster.org/#/c/18226/ to disallow replace brick operations on dist only volumes the patch failed the regression on this test as the test actually uses replace brick on a distribute only

Re: [Gluster-devel] Need inputs on patch #17985

2017-09-07 Thread Raghavendra Gowdappa
- Original Message - > From: "FNU Raghavendra Manjunath" > To: "Raghavendra Gowdappa" > Cc: "Raghavendra G" , "Nithya Balachandran" > , anoo...@redhat.com, > "Gluster Devel"

Re: [Gluster-devel] Fuse mounts and inodes

2017-09-07 Thread Csaba Henk
On Wed, Sep 6, 2017 at 4:49 PM, Raghavendra G wrote: > > > On Wed, Sep 6, 2017 at 11:16 AM, Csaba Henk wrote: > >> Thanks Du, nice bit of info! It made me wander about the following: >> >> - Could it be then the default answer we give to "glusterfs

Re: [Gluster-devel] Need inputs on patch #17985

2017-09-07 Thread FNU Raghavendra Manjunath
>From snapview client perspective one important thing to note. For building the context for the entry point (by default ".snaps") a explicit lookup has to be done on it. The dentry for ".snaps" is not returned when readdir is done on its parent directory (Not even when ls -a is done). So for

Re: [Gluster-devel] [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Niels de Vos
On Thu, Sep 07, 2017 at 04:11:22PM +0530, Milind Changire wrote: > *Squashed Patches* > I believe, individual engineers have to own the responsibility of > maintaining history of all appropriate Change-Ids as part of the commit > message when multiple patches have been squashed/merged into one

Re: [Gluster-devel] [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Kaushal M
On 7 Sep 2017 6:25 pm, "Niels de Vos" wrote: On Thu, Sep 07, 2017 at 04:41:54PM +0530, Nigel Babu wrote: > On Thu, Sep 07, 2017 at 12:43:28PM +0200, Niels de Vos wrote: > > > > Q: Can patches of a series be merged before all patches in the series > > have a +2? Initial changes

Re: [Gluster-devel] Changing Submit Type on review.gluster.org

2017-09-07 Thread Niels de Vos
On Thu, Sep 07, 2017 at 04:41:54PM +0530, Nigel Babu wrote: > On Thu, Sep 07, 2017 at 12:43:28PM +0200, Niels de Vos wrote: > > > > Q: Can patches of a series be merged before all patches in the series > > have a +2? Initial changes that prepare things, or add new (unused) core > > functionalities

[Gluster-devel] Coverity covscan for 2017-09-07-eb2f1ab4 (master branch)

2017-09-07 Thread staticanalysis
GlusterFS Coverity covscan results are available from http://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-09-07-eb2f1ab4 ___ Gluster-devel mailing list Gluster-devel@gluster.org

Re: [Gluster-devel] [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Shyam Ranganathan
On 09/07/2017 02:20 AM, Nigel Babu wrote: Hello folks, A few times, we've merged dependent patches out of order because the Submit type[1] did not block us from doing so. The last few times we've talked about this, we didn't actually take a strong decision either way. In yesterday's maintainers

Re: [Gluster-devel] Build on FreeBSD and gcc version

2017-09-07 Thread Michael Scherer
Le jeudi 07 septembre 2017 à 11:17 +0200, Niels de Vos a écrit : > On Wed, Sep 06, 2017 at 12:39:42PM +0200, Michael Scherer wrote: > > Hi, > > > > so I have been trying to make the internal freebsd builder usable, > > sinc > > eit was freshly installed and not building anything. > > > > Over

Re: [Gluster-devel] Changing Submit Type on review.gluster.org

2017-09-07 Thread Nigel Babu
On Thu, Sep 07, 2017 at 12:43:28PM +0200, Niels de Vos wrote: > > Q: Can patches of a series be merged before all patches in the series > have a +2? Initial changes that prepare things, or add new (unused) core > functionalities should be mergable so that follow-up patches can be > posted against

Re: [Gluster-devel] [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Nigel Babu
On Thu, Sep 07, 2017 at 04:11:22PM +0530, Milind Changire wrote: > *Squashed Patches* > I believe, individual engineers have to own the responsibility of > maintaining history of all appropriate Change-Ids as part of the commit > message when multiple patches have been squashed/merged into one

Re: [Gluster-devel] [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Niels de Vos
On Thu, Sep 07, 2017 at 12:06:19PM +0530, Amar Tumballi wrote: > On Thu, Sep 7, 2017 at 11:50 AM, Nigel Babu wrote: > > > Hello folks, > > > > A few times, we've merged dependent patches out of order because the Submit > > type[1] did not block us from doing so. The last few

Re: [Gluster-devel] Changing Submit Type on review.gluster.org

2017-09-07 Thread Niels de Vos
On Thu, Sep 07, 2017 at 11:50:21AM +0530, Nigel Babu wrote: > Hello folks, > > A few times, we've merged dependent patches out of order because the Submit > type[1] did not block us from doing so. The last few times we've talked about > this, we didn't actually take a strong decision either way.

Re: [Gluster-devel] [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Milind Changire
*Squashed Patches* I believe, individual engineers have to own the responsibility of maintaining history of all appropriate Change-Ids as part of the commit message when multiple patches have been squashed/merged into one commit. On Thu, Sep 7, 2017 at 11:50 AM, Nigel Babu

Re: [Gluster-devel] [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Nigel Babu
On Thu, Sep 07, 2017 at 12:17:32PM +0530, Atin Mukherjee wrote: > One basic question (rather clarification) here. If indeed a rebase is > necessary for a patch which was posted some time back and a regression was > passed at that time, with this change will a (centos) regression job > re-triggered

Re: [Gluster-devel] Build on FreeBSD and gcc version

2017-09-07 Thread Niels de Vos
On Wed, Sep 06, 2017 at 12:39:42PM +0200, Michael Scherer wrote: > Hi, > > so I have been trying to make the internal freebsd builder usable, sinc > eit was freshly installed and not building anything. > > Over the course of the day, I found a few missing deps, found a ton of > warnings (I

Re: [Gluster-devel] [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Atin Mukherjee
On Thu, Sep 7, 2017 at 11:50 AM, Nigel Babu wrote: > Hello folks, > > A few times, we've merged dependent patches out of order because the Submit > type[1] did not block us from doing so. The last few times we've talked > about > this, we didn't actually take a strong decision

Re: [Gluster-devel] [Gluster-Maintainers] Changing Submit Type on review.gluster.org

2017-09-07 Thread Amar Tumballi
On Thu, Sep 7, 2017 at 11:50 AM, Nigel Babu wrote: > Hello folks, > > A few times, we've merged dependent patches out of order because the Submit > type[1] did not block us from doing so. The last few times we've talked > about > this, we didn't actually take a strong decision

[Gluster-devel] Changing Submit Type on review.gluster.org

2017-09-07 Thread Nigel Babu
Hello folks, A few times, we've merged dependent patches out of order because the Submit type[1] did not block us from doing so. The last few times we've talked about this, we didn't actually take a strong decision either way. In yesterday's maintainers meeting, we agreed to change the Submit