Hi Niels, Thanks for the feedback. The patches which bring these changes in glusterfs are out for review here:
https://review.gluster.org/18768 (changing the auth-glusterfs version) https://review.gluster.org/19098 (changing fops program actors) Shyam, please star them for 4.0 watchlist for review help. Also, as a dependent patchsets, please review this to reduce some warnings in glusterfs logs to see more focused warnings. https://review.gluster.org/19150 https://review.gluster.org/19166 Regards, Amar On Fri, Jan 12, 2018 at 5:16 PM, Niels de Vos <nde...@redhat.com> wrote: > On Wed, Jan 10, 2018 at 03:36:55PM -0500, Shyam Ranganathan wrote: > > Hi, > > > > As we are introducing a new protocol version, the existing gluster > > wireshark plugin [1] needs to be updated. > > > > Further this needs to get released to wireshark users in some fashion, > > which looks like a need to follow wireshark roadmap [2] (not sure if > > this can be part of a maintenance release, which would possibly be based > > on the quantum of changes etc.). > > > > This need not happen with 4.0 branching, but at least has to be > > completed before 4.0 release. > > > > @neils once the protocol changes are complete, would this be possible to > > complete by you in the next 6 odd weeks by the release (end of Feb)? Or, > > if we need volunteers, please give a shout out here. > > Adding the new bits to the Wireshark dissector is pretty straight > forward. Once the protocol changes have been done, it would be good to > have a few .pcap files captured that can be used for developing and > testing the changes. This can even be done in steps, as soon as one > chunk of the protocol is finalized, a patch to upstream Wireshark can be > sent already. We can improve it incrementally that way, also making it > easier for multiple contributors to work on it. > > I can probably do some of the initial work, but would like assistance > from others with testing and possibly improving certain parts. If > someone can provide tcpdumps with updated protocol changes, that would > be most welcome! Capture the dumps like this: > > # tcpdump -i any -w /var/tmp/gluster-40-${proto_change}.pcap -s 0 tcp > and not port 22 > ... exercise the protocol bit that changed, include connection setup > ... press CTRL+C once done > # gzip /var/tmp/gluster-40-${proto_change}.pcap > ... Wireshark can read .pcap.gz without manual decompressing > > Attach the .pcap.gz to the GitHub issue for the protocol change and > email gluster-devel@ once it is available so that a developer can start > working on the Wireshark change. > > Thanks, > Niels > > > > > > Shyam > > > > [1] Gluster wireshark plugin: > > https://code.wireshark.org/review/gitweb?p=wireshark.git; > a=tree;f=epan/dissectors;h=8c8303285a204bdff3b8b80e2811dc > d9b7ab6fe0;hb=HEAD > > > > [2] Wireshark roadmap: https://wiki.wireshark.org/Development/Roadmap > > > _______________________________________________ > maintainers mailing list > maintain...@gluster.org > http://lists.gluster.org/mailman/listinfo/maintainers > -- Amar Tumballi (amarts)
_______________________________________________ Gluster-devel mailing list Gluster-devel@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-devel