Re: [Gluster-devel] About split-brain-resolution.t

2015-04-07 Thread Anuradha Talur
- Original Message - > From: "Emmanuel Dreyfus" > To: "Anuradha Talur" , "Pranith Kumar Karampuri" > > Cc: gluster-devel@gluster.org > Sent: Tuesday, March 31, 2015 9:55:24 PM > Subject: Re: [Gluster-devel] About split-brain-resolution.

Re: [Gluster-devel] About split-brain-resolution.t

2015-03-31 Thread Emmanuel Dreyfus
Anuradha Talur wrote: > 1) I send a patch today to revert the .t and send it again along with the fix. > Or... > 2) Can this be failure be ignored till the fix is merged in? We can ignore: NetBSD regresssion skips the test for now. -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz m...@netbsd.org

Re: [Gluster-devel] About split-brain-resolution.t

2015-03-31 Thread Anuradha Talur
- Original Message - > From: "Pranith Kumar Karampuri" > To: "Emmanuel Dreyfus" > Cc: gluster-devel@gluster.org, "Anuradha Talur" > Sent: Monday, 30 March, 2015 6:09:58 PM > Subject: Re: [Gluster-devel] About split-brain-resolution.t >

Re: [Gluster-devel] About split-brain-resolution.t

2015-03-30 Thread Pranith Kumar Karampuri
On 03/30/2015 06:01 PM, Emmanuel Dreyfus wrote: On Mon, Mar 30, 2015 at 05:44:23PM +0530, Pranith Kumar Karampuri wrote: Problem here is that ' inode_forget' is coming even before it gets to inspect the file. We initially thought we should 'ref' the inode when the user specifies the choice and

Re: [Gluster-devel] About split-brain-resolution.t

2015-03-30 Thread Emmanuel Dreyfus
On Mon, Mar 30, 2015 at 05:44:23PM +0530, Pranith Kumar Karampuri wrote: > Problem here is that ' inode_forget' is coming even before it gets to > inspect the file. We initially thought we should 'ref' the inode when the > user specifies the choice and 'unref' it at the time of 'finalize' or > 'abo

Re: [Gluster-devel] About split-brain-resolution.t

2015-03-30 Thread Pranith Kumar Karampuri
On 03/30/2015 06:34 PM, Emmanuel Dreyfus wrote: Pranith Kumar Karampuri wrote: Since spb_choice is not saved as an attribute for the file on the bricks, it cannot be recovered when the context is reallocated. Either that "save" feature has been forgotten, or going to afr_destroy() here is a b

Re: [Gluster-devel] About split-brain-resolution.t

2015-03-30 Thread Emmanuel Dreyfus
Pranith Kumar Karampuri wrote: > > Since spb_choice is not saved as an attribute for the file on the > > bricks, it cannot be recovered when the context is reallocated. Either > > that "save" feature has been forgotten, or going to afr_destroy() here > > is a bug. Here is the backtrace leading th

Re: [Gluster-devel] About split-brain-resolution.t

2015-03-30 Thread Pranith Kumar Karampuri
On 03/29/2015 02:23 PM, Emmanuel Dreyfus wrote: Pranith Kumar Karampuri wrote: I see split-brain-resolution.t uses attribute replica.split-brain-choice to choose what replica should be used. This attribute is not in privilegied space (trusted. prefixed). Is it on purpose? Yes, these are used

Re: [Gluster-devel] About split-brain-resolution.t

2015-03-29 Thread Emmanuel Dreyfus
Pranith Kumar Karampuri wrote: > > I see split-brain-resolution.t uses attribute replica.split-brain-choice > > to choose what replica should be used. This attribute is not in > > privilegied space (trusted. prefixed). Is it on purpose? > Yes, these are used as internal commands to make a choice

Re: [Gluster-devel] About split-brain-resolution.t

2015-03-28 Thread Emmanuel Dreyfus
Pranith Kumar Karampuri wrote: > > I see split-brain-resolution.t uses attribute replica.split-brain-choice > > to choose what replica should be used. This attribute is not in > > privilegied space (trusted. prefixed). Is it on purpose? > Yes, these are used as internal commands to make a choice

Re: [Gluster-devel] About split-brain-resolution.t

2015-03-28 Thread Pranith Kumar Karampuri
On 03/28/2015 09:51 PM, Emmanuel Dreyfus wrote: Hi I see split-brain-resolution.t uses attribute replica.split-brain-choice to choose what replica should be used. This attribute is not in privilegied space (trusted. prefixed). Is it on purpose? Yes, these are used as internal commands to make a

[Gluster-devel] About split-brain-resolution.t

2015-03-28 Thread Emmanuel Dreyfus
Hi I see split-brain-resolution.t uses attribute replica.split-brain-choice to choose what replica should be used. This attribute is not in privilegied space (trusted. prefixed). Is it on purpose? While there, just in case someone has an idea on this: on NetBSD setting this attribute is ignored.