Re: [Gluster-devel] FreeBSD and NetBSD builds failing on master

2015-11-02 Thread Jeff Darcy
On November 2, 2015 at 12:09:45 PM, Emmanuel Dreyfus (m...@netbsd.org) wrote: > On Mon, Nov 02, 2015 at 11:50:25AM -0500, Jeff Darcy wrote: > > I should have caught this problem (mea culpa) but ?break the world? is a > > bit hyperbolic. ?The world? is broken much of the time, because very > >

Re: [Gluster-devel] FreeBSD and NetBSD builds failing on master

2015-11-02 Thread Vijay Bellur
On Monday 02 November 2015 03:41 PM, Niels de Vos wrote: On Mon, Nov 02, 2015 at 01:19:48PM +0530, Raghavendra Talur wrote: Hi All, Recently merged patch "debug/io-stats: Add FOP sampling feature" [1] has a hard coded path for log directory and I think *BSD machines have a different path for

Re: [Gluster-devel] FreeBSD and NetBSD builds failing on master

2015-11-02 Thread Emmanuel Dreyfus
Jeff Darcy wrote: > None of us can keep up with the change stream. :( What's the best way > to ask, in your case? Add you as a reviewer within Gerrit? Separate > email? Anything else that would maximize efficiency when people ask for > help? Well an e-mail is fine. Being

Re: [Gluster-devel] FreeBSD and NetBSD builds failing on master

2015-11-02 Thread Jeff Darcy
> Generally speaking, I am in favor of backing otu changes that > break the world. I should have caught this problem (mea culpa) but “break the world” is a bit hyperbolic.  “The world” is broken much of the time, because very few of the developers on this project know how to fix *BSD portability

Re: [Gluster-devel] FreeBSD and NetBSD builds failing on master

2015-11-01 Thread Emmanuel Dreyfus
On Mon, Nov 02, 2015 at 01:19:48PM +0530, Raghavendra Talur wrote: > Recently merged patch "debug/io-stats: Add FOP sampling feature" [1] has a > hard coded path for log directory and I think *BSD machines have a > different path for /var/log. On NetBSD /var/log is the location for logs, but one

[Gluster-devel] FreeBSD and NetBSD builds failing on master

2015-11-01 Thread Raghavendra Talur
Hi All, Recently merged patch "debug/io-stats: Add FOP sampling feature" [1] has a hard coded path for log directory and I think *BSD machines have a different path for /var/log. Can we have the patch reverted till this is fixed? [1] http://review.gluster.org/#/c/12210/ Thanks, Raghavendra