On 14/07/2014, at 6:13 PM, Anders Blomdell wrote:
> I was thinking about "git blame"/original submitter, without implying guilt
> of any kind.
That's what I do. And look in the MAINTAINERS file, and
also try to pick out a few people that have a good chance
to caring about the specific code in
On 14 Jul 2014 18:39, Jeff Darcy wrote:
>
> > When submitting patches where there is an/some obvious person(s) to blame,
> > is it OK/desirable to request them as Code-Reviewers in gerrit?
>
> Inviting reviewers with clear interest or knowledge in a piece of code is
> not only OK but recommend
On Mon, Jul 14, 2014 at 9:31 AM, Anders Blomdell
wrote:
> When submitting patches where there is an/some obvious person(s) to blame,
> is it OK/desirable to request them as Code-Reviewers in gerrit?
Gist of adding "Core-Reviewers" is to find faults in oneself - not the
other way around :-)
--
R
> When submitting patches where there is an/some obvious person(s) to blame,
> is it OK/desirable to request them as Code-Reviewers in gerrit?
Inviting reviewers with clear interest or knowledge in a piece of code is
not only OK but recommended. I think "blame" might not be a good idea,
though.
_
When submitting patches where there is an/some obvious person(s) to blame,
is it OK/desirable to request them as Code-Reviewers in gerrit?
/Anders
--
Anders Blomdell Email: anders.blomd...@control.lth.se
Department of Automatic Control
Lund University Phone:+
