Re: [Gluster-devel] Python3 build process

2018-09-28 Thread Kaleb S. KEITHLEY
On 9/28/18 6:12 AM, Niels de Vos wrote: > Is it really needed to have this as an option? Instead of an option in > configure.ac, can it not be a post-install task in a Makefile.am? I don't fully understand how .pyc and .pyo files are used, or how the new-in-python3 __cache__ files are used, but t

Re: [Gluster-devel] Python3 build process

2018-09-28 Thread Kaleb S. KEITHLEY
On 9/28/18 9:38 AM, Niels de Vos wrote: >>> >>> Tests should just run with "$PYTHON run-the-test.py" instead of >>> ./run-the-test.py with a #!/usr/bin/python shebang. The testing >>> framework can also find out what version of python is available. >> >> If we back up a bit here, if all shebangs ar

Re: [Gluster-devel] Python3 build process

2018-09-28 Thread Niels de Vos
On Fri, Sep 28, 2018 at 09:14:15AM -0400, Shyam Ranganathan wrote: > On 09/28/2018 09:11 AM, Niels de Vos wrote: > > On Fri, Sep 28, 2018 at 08:57:06AM -0400, Shyam Ranganathan wrote: > >> On 09/28/2018 06:12 AM, Niels de Vos wrote: > >>> On Thu, Sep 27, 2018 at 08:40:54AM -0400, Shyam Ranganathan

Re: [Gluster-devel] Python3 build process

2018-09-28 Thread Shyam Ranganathan
On 09/28/2018 09:11 AM, Niels de Vos wrote: > On Fri, Sep 28, 2018 at 08:57:06AM -0400, Shyam Ranganathan wrote: >> On 09/28/2018 06:12 AM, Niels de Vos wrote: >>> On Thu, Sep 27, 2018 at 08:40:54AM -0400, Shyam Ranganathan wrote: On 09/27/2018 08:07 AM, Kaleb S. KEITHLEY wrote: >> The tho

Re: [Gluster-devel] Python3 build process

2018-09-28 Thread Niels de Vos
On Fri, Sep 28, 2018 at 08:57:06AM -0400, Shyam Ranganathan wrote: > On 09/28/2018 06:12 AM, Niels de Vos wrote: > > On Thu, Sep 27, 2018 at 08:40:54AM -0400, Shyam Ranganathan wrote: > >> On 09/27/2018 08:07 AM, Kaleb S. KEITHLEY wrote: > The thought is, > - Add a configure option "--ena

Re: [Gluster-devel] Python3 build process

2018-09-28 Thread Shyam Ranganathan
On 09/28/2018 12:36 AM, Kotresh Hiremath Ravishankar wrote: > > - All regression hosts are currently py2 and so if we do not run > the py > > shebang correction during configure (as we do not build and test from > > RPMS), we would be running with incorrect py3 shebangs (although th

Re: [Gluster-devel] Python3 build process

2018-09-28 Thread Shyam Ranganathan
On 09/28/2018 06:12 AM, Niels de Vos wrote: > On Thu, Sep 27, 2018 at 08:40:54AM -0400, Shyam Ranganathan wrote: >> On 09/27/2018 08:07 AM, Kaleb S. KEITHLEY wrote: The thought is, - Add a configure option "--enable-py-version-correction" to configure, that is disabled by default >>>

Re: [Gluster-devel] Python3 build process

2018-09-28 Thread Niels de Vos
On Thu, Sep 27, 2018 at 08:40:54AM -0400, Shyam Ranganathan wrote: > On 09/27/2018 08:07 AM, Kaleb S. KEITHLEY wrote: > >> The thought is, > >> - Add a configure option "--enable-py-version-correction" to configure, > >> that is disabled by default > > "correction" implies there's something that's

Re: [Gluster-devel] Python3 build process

2018-09-27 Thread Kotresh Hiremath Ravishankar
On Thu, Sep 27, 2018 at 5:38 PM Kaleb S. KEITHLEY wrote: > On 9/26/18 8:28 PM, Shyam Ranganathan wrote: > > Hi, > > > > With the introduction of default python 3 shebangs and the change in > > configure.ac to correct these to py2 if the build is being attempted on > > a machine that does not have

Re: [Gluster-devel] Python3 build process

2018-09-27 Thread Kaleb S. KEITHLEY
On 9/27/18 8:57 AM, Kaleb S. KEITHLEY wrote: > On 9/27/18 8:40 AM, Shyam Ranganathan wrote: >> On 09/27/2018 08:07 AM, Kaleb S. KEITHLEY wrote: The thought is, - Add a configure option "--enable-py-version-correction" to configure, that is disabled by default >>> "correction" implies

Re: [Gluster-devel] Python3 build process

2018-09-27 Thread Kaleb S. KEITHLEY
On 9/27/18 8:40 AM, Shyam Ranganathan wrote: > On 09/27/2018 08:07 AM, Kaleb S. KEITHLEY wrote: >>> The thought is, >>> - Add a configure option "--enable-py-version-correction" to configure, >>> that is disabled by default >> "correction" implies there's something that's incorrect. How about >> "c

Re: [Gluster-devel] Python3 build process

2018-09-27 Thread Shyam Ranganathan
On 09/27/2018 08:07 AM, Kaleb S. KEITHLEY wrote: >> The thought is, >> - Add a configure option "--enable-py-version-correction" to configure, >> that is disabled by default > "correction" implies there's something that's incorrect. How about > "conversion" or perhaps just --enable-python2 > I wo

Re: [Gluster-devel] Python3 build process

2018-09-27 Thread Kaleb S. KEITHLEY
On 9/26/18 8:28 PM, Shyam Ranganathan wrote: > Hi, > > With the introduction of default python 3 shebangs and the change in > configure.ac to correct these to py2 if the build is being attempted on > a machine that does not have py3, there are a couple of issues > uncovered. Here is the plan to fi

[Gluster-devel] Python3 build process

2018-09-26 Thread Shyam Ranganathan
Hi, With the introduction of default python 3 shebangs and the change in configure.ac to correct these to py2 if the build is being attempted on a machine that does not have py3, there are a couple of issues uncovered. Here is the plan to fix the same, suggestions welcome. Issues: - A configure j