Re: [Gluster-devel] What do extra_free and extrastd_free params do in the dictionary object?

2020-01-13 Thread Xavi Hernandez
On Mon, Jan 13, 2020 at 9:41 AM Yaniv Kaul wrote: > To conclude and ensure I understood both: > - I've sent a patch to remove extra_free parameter (and the associated > gf_memdup() in 2 places) - > https://review.gluster.org/#/c/glusterfs/+/23999/ (waiting for CI to > finish working on it). > -

Re: [Gluster-devel] What do extra_free and extrastd_free params do in the dictionary object?

2020-01-13 Thread Yaniv Kaul
To conclude and ensure I understood both: - I've sent a patch to remove extra_free parameter (and the associated gf_memdup() in 2 places) - https://review.gluster.org/#/c/glusterfs/+/23999/ (waiting for CI to finish working on it). - I'll send a patch to remove extra_stdfree - but this one is

Re: [Gluster-devel] What do extra_free and extrastd_free params do in the dictionary object?

2020-01-09 Thread Xavi Hernandez
On Thu, Jan 9, 2020 at 11:11 AM Yaniv Kaul wrote: > > > On Thu, Jan 9, 2020 at 11:35 AM Xavi Hernandez > wrote: > >> On Thu, Jan 9, 2020 at 10:22 AM Amar Tumballi wrote: >> >>> >>> >>> On Thu, Jan 9, 2020 at 2:33 PM Xavi Hernandez >>> wrote: >>> On Thu, Jan 9, 2020 at 9:44 AM Amar

Re: [Gluster-devel] What do extra_free and extrastd_free params do in the dictionary object?

2020-01-09 Thread Yaniv Kaul
On Thu, Jan 9, 2020 at 11:35 AM Xavi Hernandez wrote: > On Thu, Jan 9, 2020 at 10:22 AM Amar Tumballi wrote: > >> >> >> On Thu, Jan 9, 2020 at 2:33 PM Xavi Hernandez >> wrote: >> >>> On Thu, Jan 9, 2020 at 9:44 AM Amar Tumballi wrote: >>> On Thu, Jan 9, 2020 at 1:38 PM Xavi

Re: [Gluster-devel] What do extra_free and extrastd_free params do in the dictionary object?

2020-01-09 Thread Xavi Hernandez
On Thu, Jan 9, 2020 at 10:22 AM Amar Tumballi wrote: > > > On Thu, Jan 9, 2020 at 2:33 PM Xavi Hernandez wrote: > >> On Thu, Jan 9, 2020 at 9:44 AM Amar Tumballi wrote: >> >>> >>> >>> On Thu, Jan 9, 2020 at 1:38 PM Xavi Hernandez >>> wrote: >>> On Sun, Dec 22, 2019 at 4:56 PM Yaniv Kaul

Re: [Gluster-devel] What do extra_free and extrastd_free params do in the dictionary object?

2020-01-09 Thread Amar Tumballi
On Thu, Jan 9, 2020 at 2:33 PM Xavi Hernandez wrote: > On Thu, Jan 9, 2020 at 9:44 AM Amar Tumballi wrote: > >> >> >> On Thu, Jan 9, 2020 at 1:38 PM Xavi Hernandez >> wrote: >> >>> On Sun, Dec 22, 2019 at 4:56 PM Yaniv Kaul wrote: >>> I could not find a relevant use for them. Can anyone

Re: [Gluster-devel] What do extra_free and extrastd_free params do in the dictionary object?

2020-01-09 Thread Xavi Hernandez
On Thu, Jan 9, 2020 at 9:44 AM Amar Tumballi wrote: > > > On Thu, Jan 9, 2020 at 1:38 PM Xavi Hernandez wrote: > >> On Sun, Dec 22, 2019 at 4:56 PM Yaniv Kaul wrote: >> >>> I could not find a relevant use for them. Can anyone enlighten me? >>> >> >> I'm not sure why they are needed. They seem

Re: [Gluster-devel] What do extra_free and extrastd_free params do in the dictionary object?

2020-01-09 Thread Amar Tumballi
On Thu, Jan 9, 2020 at 1:38 PM Xavi Hernandez wrote: > On Sun, Dec 22, 2019 at 4:56 PM Yaniv Kaul wrote: > >> I could not find a relevant use for them. Can anyone enlighten me? >> > > I'm not sure why they are needed. They seem to be used to keep the > unserialized version of a dict around

Re: [Gluster-devel] What do extra_free and extrastd_free params do in the dictionary object?

2020-01-09 Thread Xavi Hernandez
On Sun, Dec 22, 2019 at 4:56 PM Yaniv Kaul wrote: > I could not find a relevant use for them. Can anyone enlighten me? > I'm not sure why they are needed. They seem to be used to keep the unserialized version of a dict around until the dict is destroyed. I thought this could be because we were

[Gluster-devel] What do extra_free and extrastd_free params do in the dictionary object?

2019-12-22 Thread Yaniv Kaul
I could not find a relevant use for them. Can anyone enlighten me? TIA, Y. ___ Community Meeting Calendar: APAC Schedule - Every 2nd and 4th Tuesday at 11:30 AM IST Bridge: https://bluejeans.com/441850968 NA/EMEA Schedule - Every 1st and 3rd Tuesday