Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-06-10 Thread Yaniv Kaul
ttps://review.gluster.org/#/c/glusterfs/+/22687/ > > > > > > > > *From:* Raghavendra Gowdappa > *Sent:* Wednesday, May 08, 2019 7:35 PM > *To:* Zhou, Cynthia (NSB - CN/Hangzhou) > *Cc:* Amar Tumballi Suryanarayan ; > gluster-devel@gluster.org > *Su

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-06-10 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
ailto:atumb...@redhat.com>> Cc: 'Milind Changire' mailto:mchan...@redhat.com>>; 'gluster-devel@gluster.org<mailto:gluster-devel@gluster.org>' mailto:gluster-devel@gluster.org>> Subject: RE: [Gluster-devel] glusterfsd memory leak issue found after enable ssl Hi, From our test v

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-05-08 Thread Raghavendra Gowdappa
dnesday, May 08, 2019 7:35 PM > *To:* Zhou, Cynthia (NSB - CN/Hangzhou) > *Cc:* Amar Tumballi Suryanarayan ; > gluster-devel@gluster.org > *Subject:* Re: [Gluster-devel] glusterfsd memory leak issue found after > enable ssl > > > > > > > > On Wed, May 8, 2019 at

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-05-08 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
gt;> Cc: 'Milind Changire' mailto:mchan...@redhat.com>>; 'gluster-devel@gluster.org<mailto:gluster-devel@gluster.org>' mailto:gluster-devel@gluster.org>> Subject: RE: [Gluster-devel] glusterfsd memory leak issue found after enable ssl Hi, From our test valgrind and libleak al

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-05-08 Thread Raghavendra Gowdappa
} > + SSL_shutdown(priv->ssl_ssl); > + SSL_clear(priv->ssl_ssl); > + SSL_free(priv->ssl_ssl); > > *From:* Zhou, Cynthia (NSB - CN/Hangzhou) > *Sent:* Monday, May 06, 2019 2:12 PM > *To:* 'Amar Tumballi Suryanarayan' &g

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-05-08 Thread Milind Changire
ock); > + if(priv->ssl_ctx) > + { > + SSL_CTX_free(priv->ssl_ctx); > + priv->ssl_ctx = NULL; > + } > + SSL_shutdown(priv->ssl_ssl); > + SSL_clear(pr

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-05-08 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
} + SSL_shutdown(priv->ssl_ssl); + SSL_clear(priv->ssl_ssl); + SSL_free(priv->ssl_ssl); From: Zhou, Cynthia (NSB - CN/Hangzhou) Sent: Monday, May 06, 2019 2:12 PM To: 'Amar Tumballi Suryanarayan' Cc: 'Milind Changire' ; 'glust

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-05-06 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
before. Is glusterfs using ssl_accept correctly? cynthia From: Zhou, Cynthia (NSB - CN/Hangzhou) Sent: Monday, May 06, 2019 10:34 AM To: 'Amar Tumballi Suryanarayan' Cc: Milind Changire ; gluster-devel@gluster.org Subject: RE: [Gluster-devel] glusterfsd memory leak issue found after enable ssl Hi

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-05-05 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
l); +SSL_free(priv->ssl_ssl); +priv->ssl_ssl = NULL; + } if (priv->ssl_private_key) { GF_FREE(priv->ssl_private_key); } From: Amar Tumballi Suryanarayan Sent: Wednesday, May 01, 2019 8:43 PM To: Zhou, Cynthia (NSB - CN/Hangzhou) Cc: Milind Changire ; gluster

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-05-01 Thread Amar Tumballi Suryanarayan
> > *From:* Milind Changire > *Sent:* Monday, April 22, 2019 2:36 PM > *To:* Zhou, Cynthia (NSB - CN/Hangzhou) > *Cc:* Atin Mukherjee ; gluster-devel@gluster.org > *Subject:* Re: [Gluster-devel] glusterfsd memory leak issue found after > enable ssl > > > > According to BIO_ne

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-22 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
ct: Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl According to BIO_new_socket() man page ... If the close flag is set then the socket is shut down and closed when the BIO is freed. For Gluster to have more control over the socket shutdown, the BIO_NOCLOSE flag

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-22 Thread Milind Changire
According to BIO_new_socket() man page ... *If the close flag is set then the socket is shut down and closed when the BIO is freed.* For Gluster to have more control over the socket shutdown, the BIO_NOCLOSE flag is set. Otherwise, SSL takes control of socket shutdown whenever BIO is freed.

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-22 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
ct: Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl Looks like using BIO_free() is not right. Here's what the SSL_set_bio() man page says ... SSL_set_bio() is similar to SSL_set0_rbio() and SSL_set0_wbio() except that it connects both the rbio and the wbio at the sam

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-22 Thread Milind Changire
+SSL_shutdown(priv->ssl_ssl); > > +SSL_clear(priv->ssl_ssl); > > +SSL_free(priv->ssl_ssl); > > + gf_log(this->name, GF_LOG_INFO,"priv->ssl_sbio of socket(%d)is %p > ",priv->sock,priv->ssl_sbio); > > +if(priv->ssl_sbio != N

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-22 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
@gluster.org Subject: Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl This probably went unnoticed until now. On Mon, Apr 22, 2019 at 10:45 AM Zhou, Cynthia (NSB - CN/Hangzhou) mailto:cynthia.z...@nokia-sbell.com>> wrote: Why there is no bio_free

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-22 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
(%d)is %p ",priv->sock,priv->ssl_sbio); +if(priv->ssl_sbio != NULL) +BIO_free(priv->ssl_sbio); +priv->ssl_ssl = NULL; + priv->ssl_sbio = NULL; + } if (priv->ssl_private_key) { GF_FREE(priv->ssl_private_key); From: Milind Changire Sent: Monday

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-21 Thread Milind Changire
> *Sent:* Monday, April 22, 2019 10:21 AM > *To:* Zhou, Cynthia (NSB - CN/Hangzhou) > *Cc:* Atin Mukherjee ; gluster-devel@gluster.org > *Subject:* Re: [Gluster-devel] glusterfsd memory leak issue found after > enable ssl > > > > After patch 22334 <https://revi

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-21 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
gt;ssl_private_key); } From: Zhou, Cynthia (NSB - CN/Hangzhou) Sent: Thursday, April 18, 2019 5:31 PM To: 'Atin Mukherjee' mailto:amukh...@redhat.com>> Cc: 'Raghavendra Gowdappa' mailto:rgowd...@redhat.com>>; 'gluster-devel@gluster.org<mailto:gluster-devel@gluster.org>' mailto

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-21 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
Ok, I will post it later. cynthia From: Raghavendra Gowdappa Sent: Monday, April 22, 2019 10:09 AM To: Zhou, Cynthia (NSB - CN/Hangzhou) Cc: Atin Mukherjee ; gluster-devel@gluster.org Subject: Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl On Mon, Apr 22, 2019 at 7

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-21 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
GF_FREE(priv->ssl_private_key); } From: Zhou, Cynthia (NSB - CN/Hangzhou) Sent: Thursday, April 18, 2019 5:31 PM To: 'Atin Mukherjee' Cc: 'Raghavendra Gowdappa' ; 'gluster-devel@gluster.org' Subject: RE: [Gluster-devel] glusterfsd memory leak issue found after enable ssl We scan i

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-18 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
; gluster-devel@gluster.org Subject: RE: [Gluster-devel] glusterfsd memory leak issue found after enable ssl I’ve test on glusterfs3.12.15 and glusterfs5.5 all have this issue, after enable tls ssl socket, when execute gluster v heal info, will trigger glfshel to connect glusterfsd process

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-18 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
Sent: Thursday, April 18, 2019 1:19 PM To: Zhou, Cynthia (NSB - CN/Hangzhou) Cc: Raghavendra Gowdappa ; gluster-devel@gluster.org Subject: Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl On Wed, 17 Apr 2019 at 10:53, Zhou, Cynthia (NSB - CN/Hangzhou) mailto:cynthia.z

Re: [Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-17 Thread Atin Mukherjee
On Wed, 17 Apr 2019 at 10:53, Zhou, Cynthia (NSB - CN/Hangzhou) < cynthia.z...@nokia-sbell.com> wrote: > Hi, > > In my recent test, I found that there are very severe glusterfsd memory > leak when enable socket ssl option > What gluster version are you testing? Would you be able to continue your

[Gluster-devel] glusterfsd memory leak issue found after enable ssl

2019-04-16 Thread Zhou, Cynthia (NSB - CN/Hangzhou)
Hi, In my recent test, I found that there are very severe glusterfsd memory leak when enable socket ssl option. If I monitor glusterfsd process RSS with command: pidstat -r -p 1 And at the same tme, execute command: gluster v heal info, i find that the RSS keep increasing until system Out of