On 12/17/2014 01:01 PM, Lalatendu Mohanty wrote:
On 12/17/2014 12:56 PM, Krishnan Parthasarathi wrote:
I was looking into a Coverity issue (CID 1228603) in GlusterFS.
I sent a patch[1] before I fully understood why this was an issue.
After searching around in the internet for explanations, I
On Wed, Dec 17, 2014 at 02:26:55AM -0500, Krishnan Parthasarathi wrote:
I was looking into a Coverity issue (CID 1228603) in GlusterFS.
I sent a patch[1] before I fully understood why this was an issue.
After searching around in the internet for explanations, I identified that
the core issue
As long as we can precisely 'teach' Coverity our usage patterns that are known
to be correct, it is OK to address a family of issues. If there is an advertised
interface in Coverity to do that then we should be able to 'undo' it as well.
OTOH, closing a bunch of similar looking (but incorrectly
Thanks Lala and Niels, I marked the issue as intentional with a comment.
FWIW, this exercise inspired me to refactor the code near the false positive
site. For those interested in reviewing, http://review.gluster.org/9288
~kp
- Original Message -
As long as we can precisely 'teach'
On Wed, Dec 17, 2014 at 01:54:09PM +0530, Atin Mukherjee wrote:
On 12/17/2014 01:01 PM, Lalatendu Mohanty wrote:
On 12/17/2014 12:56 PM, Krishnan Parthasarathi wrote:
I was looking into a Coverity issue (CID 1228603) in GlusterFS.
I sent a patch[1] before I fully understood why this was
- Original Message -
From: Niels de Vos nde...@redhat.com
To: Atin Mukherjee amukh...@redhat.com
Cc: Gluster Devel gluster-devel@gluster.org
Sent: Wednesday, December 17, 2014 2:21:50 PM
Subject: Re: [Gluster-devel] Help needed with Coverity - How to remove
tainted_data_argument
On 12/17/2014 09:26 AM, Niels de Vos wrote:
On Wed, Dec 17, 2014 at 02:26:55AM -0500, Krishnan Parthasarathi wrote:
I was looking into a Coverity issue (CID 1228603) in GlusterFS.
I sent a patch[1] before I fully understood why this was an issue.
After searching around in the internet for
On 12/17/2014 11:29 AM, Niels de Vos wrote:
On Wed, Dec 17, 2014 at 10:24:46AM +0100, Xavier Hernandez wrote:
I think the root cause of this particular problem is a pattern like this:
GF_ASSERT(type = x);
array[type] = y
I think there are several places where this pattern is used.
On 12/17/2014 12:46 PM, Krishnan Parthasarathi wrote:
- Original Message -
On 12/17/2014 11:29 AM, Niels de Vos wrote:
On Wed, Dec 17, 2014 at 10:24:46AM +0100, Xavier Hernandez wrote:
I think the root cause of this particular problem is a pattern like this:
GF_ASSERT(type =
On 12/17/2014 12:56 PM, Krishnan Parthasarathi wrote:
I was looking into a Coverity issue (CID 1228603) in GlusterFS.
I sent a patch[1] before I fully understood why this was an issue.
After searching around in the internet for explanations, I identified that
the core issue was that a character
10 matches
Mail list logo
