Re: [Gluster-devel] run-tests-in-vagrant

[Niels de Vos]

On Fri, Feb 16, 2018 at 10:15:28AM +0100, Niels de Vos wrote:
> On Fri, Feb 16, 2018 at 10:08:51AM +0530, Nigel Babu wrote:
> > So we have a job that's unmaintained and unwatched. If nobody steps up to
> > own it in the next 2 weeks, I'll be deleting this job.
> 
> I fixed the downloading of the Vagrant box with
> https://github.com/gluster/glusterfs-patch-acceptance-tests/pull/122 .

In addition to the download error, I have improved the return status of
the ./run-tests-in-vagrant.sh script so that it returns the status of
the jobs taht are run in the VM:
  https://review.gluster.org/19575

Please review that one too :)

Thanks,
Niels
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] run-tests-in-vagrant

[Niels de Vos]

On Fri, Feb 16, 2018 at 10:08:51AM +0530, Nigel Babu wrote:
> So we have a job that's unmaintained and unwatched. If nobody steps up to
> own it in the next 2 weeks, I'll be deleting this job.

I fixed the downloading of the Vagrant box with
https://github.com/gluster/glusterfs-patch-acceptance-tests/pull/122 .

Maybe Talur can help with updating the box so that geo-replication tests
function? If there is an Ansible role/repository with the changes that
were done on the Jenkins slaves, that could possibly help.

Is it possible to provide a Vargrant box configured similar to the
Jenkins slaves (without the Jenkins bits and other internal pieces) from
the same deployment as the slaves? That would make things less manual
and much easier to consume.

Thanks!
Niels


> 
> On Wed, Feb 14, 2018 at 4:49 PM, Niels de Vos  wrote:
> 
> > On Wed, Feb 14, 2018 at 11:15:23AM +0530, Nigel Babu wrote:
> > > Hello,
> > >
> > > Centos CI has a run-tests-in-vagrant job. Do we continue to need this
> > > anymore? It still runs master and 3.8. I don't see this job adding much
> > > value at this point given we only look at results that are on
> > > build.gluster.org. I'd like to use the extra capacity for other tests
> > that
> > > will run on centos-ci.
> >
> > The ./run-tests-in-vagrant.sh script is ideally what developers run
> > before submitting their patches. In case it fails, we should fix it.
> > Being able to run tests locally is something many of the new
> > contributors want to do. Having a controlled setup for the testing can
> > really help with getting new contributors onboard.
> >
> > Hmm, and the script/job definitely seems to be broken with at least two
> > parts:
> > - the Vagrant version on CentOS uses the old URL to get the box
> > - 00-georep-verify-setup.t fails, but the result is marked as SUCCESS
> >
> > It seems we need to get better at watching the CI, or at least be able
> > to receive and handle notifications...
> >
> > Thanks,
> > Niels
> >
> 
> 
> 
> -- 
> nigelb
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] run-tests-in-vagrant

[Nigel Babu]

So we have a job that's unmaintained and unwatched. If nobody steps up to
own it in the next 2 weeks, I'll be deleting this job.

On Wed, Feb 14, 2018 at 4:49 PM, Niels de Vos  wrote:

> On Wed, Feb 14, 2018 at 11:15:23AM +0530, Nigel Babu wrote:
> > Hello,
> >
> > Centos CI has a run-tests-in-vagrant job. Do we continue to need this
> > anymore? It still runs master and 3.8. I don't see this job adding much
> > value at this point given we only look at results that are on
> > build.gluster.org. I'd like to use the extra capacity for other tests
> that
> > will run on centos-ci.
>
> The ./run-tests-in-vagrant.sh script is ideally what developers run
> before submitting their patches. In case it fails, we should fix it.
> Being able to run tests locally is something many of the new
> contributors want to do. Having a controlled setup for the testing can
> really help with getting new contributors onboard.
>
> Hmm, and the script/job definitely seems to be broken with at least two
> parts:
> - the Vagrant version on CentOS uses the old URL to get the box
> - 00-georep-verify-setup.t fails, but the result is marked as SUCCESS
>
> It seems we need to get better at watching the CI, or at least be able
> to receive and handle notifications...
>
> Thanks,
> Niels
>



-- 
nigelb
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] run-tests-in-vagrant

[Niels de Vos]

On Wed, Feb 14, 2018 at 11:15:23AM +0530, Nigel Babu wrote:
> Hello,
> 
> Centos CI has a run-tests-in-vagrant job. Do we continue to need this
> anymore? It still runs master and 3.8. I don't see this job adding much
> value at this point given we only look at results that are on
> build.gluster.org. I'd like to use the extra capacity for other tests that
> will run on centos-ci.

The ./run-tests-in-vagrant.sh script is ideally what developers run
before submitting their patches. In case it fails, we should fix it.
Being able to run tests locally is something many of the new
contributors want to do. Having a controlled setup for the testing can
really help with getting new contributors onboard.

Hmm, and the script/job definitely seems to be broken with at least two
parts:
- the Vagrant version on CentOS uses the old URL to get the box
- 00-georep-verify-setup.t fails, but the result is marked as SUCCESS

It seems we need to get better at watching the CI, or at least be able
to receive and handle notifications...

Thanks,
Niels


signature.asc
Description: PGP signature
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] run-tests-in-vagrant

[Nigel Babu]

Hello,

Centos CI has a run-tests-in-vagrant job. Do we continue to need this
anymore? It still runs master and 3.8. I don't see this job adding much
value at this point given we only look at results that are on
build.gluster.org. I'd like to use the extra capacity for other tests that
will run on centos-ci.

-- 
nigelb
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel