Re: [Gluster-devel] tests/basic/pump.t - what is it used for?

[Amar Tumballi]

All I know is pump translator is written long back to support
'replace-brick' without data-loss in distributed setup too. But we figured
out pump is not maintainable along the way, and said you can't do a
replace-brick in distributed volume type.

https://github.com/gluster/glusterfs/commit/acdeed002d30209e0a058c2df0346d
4f16c08994

I don't see that its used now, so looks like we can remove this test.

-Amar

On Fri, Sep 8, 2017 at 10:02 AM, Atin Mukherjee  wrote:

> Pranith,
>
> I see you're the author of the test in $Subj. Now while I was working on a
> patch https://review.gluster.org/#/c/18226/ to disallow replace brick
> operations on dist only volumes the patch failed the regression on this
> test as the test actually uses replace brick on a distribute only volume
> which IMO is wrong as then this would always end up in to data loss
> situation. I'd need some context here to understand the expectation of this
> test before doing any modifications.
>
> ~Atin
>
> ___
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel
>



-- 
Amar Tumballi (amarts)
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

Re: [Gluster-devel] tests/basic/pump.t - what is it used for?

[Pranith Kumar Karampuri]

It was used for testing pump xlator functionality. When replace-brick is
done on a distribute volume, it would lead to pump xlator migrating data to
the destination brick from source. I guess we can delete this test. I don't
think we support pump xlator anymore.

On Fri, Sep 8, 2017 at 10:02 AM, Atin Mukherjee  wrote:

> Pranith,
>
> I see you're the author of the test in $Subj. Now while I was working on a
> patch https://review.gluster.org/#/c/18226/ to disallow replace brick
> operations on dist only volumes the patch failed the regression on this
> test as the test actually uses replace brick on a distribute only volume
> which IMO is wrong as then this would always end up in to data loss
> situation. I'd need some context here to understand the expectation of this
> test before doing any modifications.
>
> ~Atin
>



-- 
Pranith
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel

[Gluster-devel] tests/basic/pump.t - what is it used for?

[Atin Mukherjee]

Pranith,

I see you're the author of the test in $Subj. Now while I was working on a
patch https://review.gluster.org/#/c/18226/ to disallow replace brick
operations on dist only volumes the patch failed the regression on this
test as the test actually uses replace brick on a distribute only volume
which IMO is wrong as then this would always end up in to data loss
situation. I'd need some context here to understand the expectation of this
test before doing any modifications.

~Atin
___
Gluster-devel mailing list
Gluster-devel@gluster.org
http://lists.gluster.org/mailman/listinfo/gluster-devel