Re: [Gluster-devel] gcov/lcov code coverage of glusterfs

2013-05-10 Thread Jeff Darcy
On 05/10/2013 01:02 PM, Justin Clift wrote: Patch submission is actually pretty simple once you've gone through it the first time. :) So's skydiving. ;) ___ Gluster-devel mailing list Gluster-devel@nongnu.org https://lists.nongnu.org/mailman/listi

Re: [Gluster-devel] gcov/lcov code coverage of glusterfs

2013-05-10 Thread Justin Clift
On 10/05/2013, at 5:51 PM, John Smith wrote: > On Fri, May 10, 2013 at 6:45 PM, Justin Clift wrote: >> >> Thanks John. :) >> > No problem. Also: My Very First Patch *ever* to an open source project ! w00t > ! > lol It's all good. Keep them coming. :) There's even instructions online if you

Re: [Gluster-devel] gcov/lcov code coverage of glusterfs

2013-05-10 Thread John Smith
On Fri, May 10, 2013 at 6:45 PM, Justin Clift wrote: > > Thanks John. :) > No problem. Also: My Very First Patch *ever* to an open source project ! w00t ! lol - John Smith ___ Gluster-devel mailing list Gluster-devel@nongnu.org https://lists.nongnu.or

Re: [Gluster-devel] gcov/lcov code coverage of glusterfs

2013-05-10 Thread Justin Clift
On 10/05/2013, at 4:06 PM, John Smith wrote: > I think I finally figured this one out. It looks like the 'CFLAGS' env > is (unintended) being overwritten in 'configure.ac'. > > So I modified the line reading: > > CFLAGS="-g" > > to > > CFLAGS+=" -g" > > And now all CFLAGS env vars seem to be

Re: [Gluster-devel] gcov/lcov code coverage of glusterfs

2013-05-10 Thread John Smith
Hi, I think I finally figured this one out. It looks like the 'CFLAGS' env is (unintended) being overwritten in 'configure.ac'. So I modified the line reading: CFLAGS="-g" to CFLAGS+=" -g" And now all CFLAGS env vars seem to be propagated through all the Makefiles as expected. Maybe someone

Re: [Gluster-devel] gcov/lcov code coverage of glusterfs

2013-05-10 Thread John Smith
On Thu, May 9, 2013 at 8:40 PM, John Smith wrote: > On Thu, May 9, 2013 at 7:46 PM, Michael Brown wrote: >> How are you passing the flags? >> > LDFLAGS+='-fprofile-arcs' CFLAGS+='-fprofile-arcs -ftest-coverage' ./configure > > >> >> I just tried: >> >> ./configure --prefix=/usr/local/glusterfs >

Re: [Gluster-devel] gcov/lcov code coverage of glusterfs

2013-05-09 Thread John Smith
On Thu, May 9, 2013 at 7:46 PM, Michael Brown wrote: > How are you passing the flags? > LDFLAGS+='-fprofile-arcs' CFLAGS+='-fprofile-arcs -ftest-coverage' ./configure > > I just tried: > > ./configure --prefix=/usr/local/glusterfs > {,GF_FUSE_,GF_GLUSTERFS_,GF_}CFLAGS="-fprofile-arcs -ftest-cov

Re: [Gluster-devel] gcov/lcov code coverage of glusterfs

2013-05-09 Thread Michael Brown
How are you passing the flags? I just tried: ./configure --prefix=/usr/local/glusterfs {,GF_FUSE_,GF_GLUSTERFS_,GF_}CFLAGS="-fprofile-arcs -ftest-coverage" and was able to build it fine. M. -- Michael Brown, Systems Consultant Net Direct Inc. ☎: +1 519 883 1172 x5106 - Original Message