Re: [Gluster-devel] AFR conservative merge portability

2014-12-19 Thread Emmanuel Dreyfus
On Fri, Dec 19, 2014 at 10:49:38AM +0530, Ravishankar N wrote: I addressed the points you raised but now my patch is failing just newly introduced ./tests/bugs/afr-quota-xattr-mdata-heal.t (...) There seems to be one more catch. afr_is_dirtime_splitbrain() only compares equality of

Re: [Gluster-devel] AFR conservative merge portability

2014-12-18 Thread Ravishankar N
On 12/18/2014 01:28 PM, Emmanuel Dreyfus wrote: On Mon, Dec 15, 2014 at 03:21:24PM -0500, Jeff Darcy wrote: Is there *any* case, not even necessarily involving conservative merge, where it would be harmful to propagate the latest ctime/mtime for any replica of a directory? In case of

Re: [Gluster-devel] AFR conservative merge portability

2014-12-18 Thread Ravishankar N
On 12/19/2014 08:23 AM, Emmanuel Dreyfus wrote: Ravishankar N ravishan...@redhat.com wrote: Point #1 would be addressed by your patch with some modifications (pending review ); I addressed the points you raised but now my patch is failing just newly introduced

Re: [Gluster-devel] AFR conservative merge portability

2014-12-17 Thread Emmanuel Dreyfus
On Mon, Dec 15, 2014 at 03:21:24PM -0500, Jeff Darcy wrote: Is there *any* case, not even necessarily involving conservative merge, where it would be harmful to propagate the latest ctime/mtime for any replica of a directory? In case of conservative merge, the problem vanish on its own anyway:

Re: [Gluster-devel] AFR conservative merge portability

2014-12-15 Thread Emmanuel Dreyfus
Ravishankar N ravishan...@redhat.com wrote: The check can be done in metadata selfheal itself but I don't think AFR is to blame if the user space app in NetBSD sends a setattr on the parent dir. It is not exactly the problem: When adding an entry, you must update parent directory mtime/ctime.

Re: [Gluster-devel] AFR conservative merge portability

2014-12-15 Thread Jeff Darcy
Here is a proposal: we know that at the end of conservative merge, we should end up with the situation where directory ctime/mtime is the ctime of the most recently added children. Won't the directory mtime change as the result of a rename or unlink? Neither of those would be reflected in the

Re: [Gluster-devel] AFR conservative merge portability

2014-12-14 Thread Krutika Dhananjay
Seems OK to me, as long as the appropriate locks are taken. -Krutika - Original Message - From: Emmanuel Dreyfus m...@netbsd.org To: Gluster Devel gluster-devel@gluster.org Sent: Saturday, December 13, 2014 8:08:03 PM Subject: [Gluster-devel] AFR conservative merge portability

Re: [Gluster-devel] AFR conservative merge portability

2014-12-14 Thread Ravishankar N
*From: *Emmanuel Dreyfus m...@netbsd.org *To: *Gluster Devel gluster-devel@gluster.org *Sent: *Saturday, December 13, 2014 8:08:03 PM *Subject: *[Gluster-devel] AFR conservative merge portability Hello On NetBSD, tests/basic/afr/entry