What is the agreed upon clang version for Glusterfs project? Is it clang-6?
On Fri, Oct 5, 2018 at 1:58 PM Raghavendra Gowdappa
wrote:
> clang-4.0.1 pushes patch, but still doesn't understand some keys in
> clang-format.
>
> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
> [detached HEAD 401a7b6]
clang-4.0.1 pushes patch, but still doesn't understand some keys in
clang-format.
[rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
[detached HEAD 401a7b6] cluster/dht: clang-format dht-common.c
1 file changed, 10674 insertions(+), 11166 deletions(-)
rewrite xlators/cluster/dht/src/dht-common.c (88%)
We should document (better still add checks in rfc.sh and warn user to
upgrade) that we need clang version x or greater.
On Fri, Oct 5, 2018 at 10:45 AM Sachidananda URS wrote:
>
>
> On Fri, Oct 5, 2018 at 10:41 AM, Raghavendra Gowdappa > wrote:
>
>> General options:
>>
>> -help
On Fri, Oct 5, 2018 at 10:41 AM, Raghavendra Gowdappa
wrote:
> General options:
>
> -help - Display available options (-help-hidden for
> more)
> -help-list- Display list of available options
> (-help-list-hidden for more)
> -version -
General options:
-help - Display available options (-help-hidden for
more)
-help-list- Display list of available options
(-help-list-hidden for more)
-version - Display the version of this program
[rgowdapp@rgowdapp ~]$ clang-format
[rgowdapp@rgowdapp glusterfs]$ clang-format --version ; echo $?
> LLVM (http://llvm.org/):
> LLVM version 3.4.2
> Optimized build.
> Built Dec 7 2015 (09:37:36).
> Default target: x86_64-redhat-linux-gnu
> Host CPU: x86-64
> 1
>
> Wonder why clang-format --version has to return
On Fri, Oct 5, 2018 at 9:58 AM Sachidananda URS wrote:
>
>
> On Fri, Oct 5, 2018 at 9:45 AM, Raghavendra Gowdappa
> wrote:
>
>>
>>
>> On Fri, Oct 5, 2018 at 9:34 AM Raghavendra Gowdappa
>> wrote:
>>
>>>
>>>
>>> On Fri, Oct 5, 2018 at 9:11 AM Kaushal M wrote:
>>>
On Fri, Oct 5, 2018 at
Even I encountered the same. If you have clang version less than 6, it
exits. Upgrading clang version fixed it.
Regards,
Poornima
On Fri, Oct 5, 2018, 9:58 AM Sachidananda URS wrote:
>
>
> On Fri, Oct 5, 2018 at 9:45 AM, Raghavendra Gowdappa
> wrote:
>
>>
>>
>> On Fri, Oct 5, 2018 at 9:34 AM
On Fri, Oct 5, 2018 at 9:45 AM, Raghavendra Gowdappa
wrote:
>
>
> On Fri, Oct 5, 2018 at 9:34 AM Raghavendra Gowdappa
> wrote:
>
>>
>>
>> On Fri, Oct 5, 2018 at 9:11 AM Kaushal M wrote:
>>
>>> On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa
>>> wrote:
>>> >
>>> >
>>> >
>>> > On Fri, Oct
On Fri, Oct 5, 2018 at 9:34 AM Raghavendra Gowdappa
wrote:
>
>
> On Fri, Oct 5, 2018 at 9:11 AM Kaushal M wrote:
>
>> On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa
>> wrote:
>> >
>> >
>> >
>> > On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi
>> wrote:
>> >>
>> >> Can you try below diff in
On Fri, Oct 5, 2018 at 9:11 AM Kaushal M wrote:
> On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa
> wrote:
> >
> >
> >
> > On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi
> wrote:
> >>
> >> Can you try below diff in your rfc, and let me know if it works?
> >
> >
> > No. it didn't. I see the
On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa wrote:
>
>
>
> On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi wrote:
>>
>> Can you try below diff in your rfc, and let me know if it works?
>
>
> No. it didn't. I see the same error.
> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
> + rebase_changes
>
On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi wrote:
> Can you try below diff in your rfc, and let me know if it works?
>
No. it didn't. I see the same error.
[rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
+ rebase_changes
+ GIT_EDITOR=./rfc.sh
+ git rebase -i origin/master
[detached HEAD e50667e]
Can you try below diff in your rfc, and let me know if it works?
```
> diff --git a/rfc.sh b/rfc.sh
> index 607fd7528f..4ffef26ca1 100755
> --- a/rfc.sh
> +++ b/rfc.sh
> @@ -321,21 +321,21 @@ main()
> fi
>
> # TODO: add clang-format command here. It will after the changes are
> done
14 matches
Mail list logo
