Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
What is the agreed upon clang version for Glusterfs project? Is it clang-6? On Fri, Oct 5, 2018 at 1:58 PM Raghavendra Gowdappa wrote: > clang-4.0.1 pushes patch, but still doesn't understand some keys in > clang-format. > > [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh > [detached HEAD 401a7b6] cluster/dht: clang-format dht-common.c > 1 file changed, 10674 insertions(+), 11166 deletions(-) > rewrite xlators/cluster/dht/src/dht-common.c (88%) > [detached HEAD 2bf5031] cluster/dht: fixes to unlinking invalid linkto file > 1 file changed, 236 insertions(+), 268 deletions(-) > Successfully rebased and updated refs/heads/1635145. > YAML:35:23: error: unknown key 'SplitEmptyFunction' > SplitEmptyFunction: true > ^~~~ > > > On Fri, Oct 5, 2018 at 10:47 AM Raghavendra Gowdappa > wrote: > >> We should document (better still add checks in rfc.sh and warn user to >> upgrade) that we need clang version x or greater. >> >> On Fri, Oct 5, 2018 at 10:45 AM Sachidananda URS wrote: >> >>> >>> >>> On Fri, Oct 5, 2018 at 10:41 AM, Raghavendra Gowdappa < >>> rgowd...@redhat.com> wrote: >>> General options: -help - Display available options (-help-hidden for more) -help-list- Display list of available options (-help-list-hidden for more) -version - Display the version of this program [rgowdapp@rgowdapp ~]$ clang-format -version ; echo $? LLVM (http://llvm.org/): LLVM version 3.4.2 Optimized build. Built Dec 7 2015 (09:37:36). Default target: x86_64-redhat-linux-gnu Host CPU: x86-64 1 >>> It is a bug then, which they've fixed later on. Upgrade is the only >>> choice. >>> >>> ___ Gluster-devel mailing list Gluster-devel@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
clang-4.0.1 pushes patch, but still doesn't understand some keys in clang-format. [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh [detached HEAD 401a7b6] cluster/dht: clang-format dht-common.c 1 file changed, 10674 insertions(+), 11166 deletions(-) rewrite xlators/cluster/dht/src/dht-common.c (88%) [detached HEAD 2bf5031] cluster/dht: fixes to unlinking invalid linkto file 1 file changed, 236 insertions(+), 268 deletions(-) Successfully rebased and updated refs/heads/1635145. YAML:35:23: error: unknown key 'SplitEmptyFunction' SplitEmptyFunction: true ^~~~ On Fri, Oct 5, 2018 at 10:47 AM Raghavendra Gowdappa wrote: > We should document (better still add checks in rfc.sh and warn user to > upgrade) that we need clang version x or greater. > > On Fri, Oct 5, 2018 at 10:45 AM Sachidananda URS wrote: > >> >> >> On Fri, Oct 5, 2018 at 10:41 AM, Raghavendra Gowdappa < >> rgowd...@redhat.com> wrote: >> >>> General options: >>> >>> -help - Display available options (-help-hidden >>> for more) >>> -help-list- Display list of available options >>> (-help-list-hidden for more) >>> -version - Display the version of this program >>> [rgowdapp@rgowdapp ~]$ clang-format -version ; echo $? >>> LLVM (http://llvm.org/): >>> LLVM version 3.4.2 >>> Optimized build. >>> Built Dec 7 2015 (09:37:36). >>> Default target: x86_64-redhat-linux-gnu >>> Host CPU: x86-64 >>> 1 >>> >>> >> It is a bug then, which they've fixed later on. Upgrade is the only >> choice. >> >> ___ Gluster-devel mailing list Gluster-devel@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
We should document (better still add checks in rfc.sh and warn user to upgrade) that we need clang version x or greater. On Fri, Oct 5, 2018 at 10:45 AM Sachidananda URS wrote: > > > On Fri, Oct 5, 2018 at 10:41 AM, Raghavendra Gowdappa > wrote: > >> General options: >> >> -help - Display available options (-help-hidden for >> more) >> -help-list- Display list of available options >> (-help-list-hidden for more) >> -version - Display the version of this program >> [rgowdapp@rgowdapp ~]$ clang-format -version ; echo $? >> LLVM (http://llvm.org/): >> LLVM version 3.4.2 >> Optimized build. >> Built Dec 7 2015 (09:37:36). >> Default target: x86_64-redhat-linux-gnu >> Host CPU: x86-64 >> 1 >> >> > It is a bug then, which they've fixed later on. Upgrade is the only choice. > > ___ Gluster-devel mailing list Gluster-devel@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
On Fri, Oct 5, 2018 at 10:41 AM, Raghavendra Gowdappa wrote: > General options: > > -help - Display available options (-help-hidden for > more) > -help-list- Display list of available options > (-help-list-hidden for more) > -version - Display the version of this program > [rgowdapp@rgowdapp ~]$ clang-format -version ; echo $? > LLVM (http://llvm.org/): > LLVM version 3.4.2 > Optimized build. > Built Dec 7 2015 (09:37:36). > Default target: x86_64-redhat-linux-gnu > Host CPU: x86-64 > 1 > > It is a bug then, which they've fixed later on. Upgrade is the only choice. ___ Gluster-devel mailing list Gluster-devel@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
General options: -help - Display available options (-help-hidden for more) -help-list- Display list of available options (-help-list-hidden for more) -version - Display the version of this program [rgowdapp@rgowdapp ~]$ clang-format -version ; echo $? LLVM (http://llvm.org/): LLVM version 3.4.2 Optimized build. Built Dec 7 2015 (09:37:36). Default target: x86_64-redhat-linux-gnu Host CPU: x86-64 1 On Fri, Oct 5, 2018 at 10:37 AM Sachidananda URS wrote: > > > > [rgowdapp@rgowdapp glusterfs]$ clang-format --version ; echo $? >> LLVM (http://llvm.org/): >> LLVM version 3.4.2 >> Optimized build. >> Built Dec 7 2015 (09:37:36). >> Default target: x86_64-redhat-linux-gnu >> Host CPU: x86-64 >> 1 >> >> Wonder why clang-format --version has to return non-zero return code >> though. >> > > Maybe because the syntax is `clang-format -version' not --version. > In the newer releases both -version and --version return 0. > You can try -version, if it returns 0. We can fix `rfc.sh' > > But, what they document is -version. > > > ___ Gluster-devel mailing list Gluster-devel@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
[rgowdapp@rgowdapp glusterfs]$ clang-format --version ; echo $? > LLVM (http://llvm.org/): > LLVM version 3.4.2 > Optimized build. > Built Dec 7 2015 (09:37:36). > Default target: x86_64-redhat-linux-gnu > Host CPU: x86-64 > 1 > > Wonder why clang-format --version has to return non-zero return code > though. > Maybe because the syntax is `clang-format -version' not --version. In the newer releases both -version and --version return 0. You can try -version, if it returns 0. We can fix `rfc.sh' But, what they document is -version. ___ Gluster-devel mailing list Gluster-devel@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
On Fri, Oct 5, 2018 at 9:58 AM Sachidananda URS wrote:
>
>
> On Fri, Oct 5, 2018 at 9:45 AM, Raghavendra Gowdappa
> wrote:
>
>>
>>
>> On Fri, Oct 5, 2018 at 9:34 AM Raghavendra Gowdappa
>> wrote:
>>
>>>
>>>
>>> On Fri, Oct 5, 2018 at 9:11 AM Kaushal M wrote:
>>>
On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa <
rgowd...@redhat.com> wrote:
>
>
>
> On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi
wrote:
>>
>> Can you try below diff in your rfc, and let me know if it works?
>
>
> No. it didn't. I see the same error.
> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
> + rebase_changes
> + GIT_EDITOR=./rfc.sh
> + git rebase -i origin/master
> [detached HEAD e50667e] cluster/dht: clang-format dht-common.c
> 1 file changed, 10674 insertions(+), 11166 deletions(-)
> rewrite xlators/cluster/dht/src/dht-common.c (88%)
> [detached HEAD 0734847] cluster/dht: fixes to unlinking invalid
linkto file
> 1 file changed, 1 insertion(+), 1 deletion(-)
> [detached HEAD 7aeba07] rfc.sh: test - DO NOT MERGE
> 1 file changed, 8 insertions(+), 3 deletions(-)
> Successfully rebased and updated refs/heads/1635145.
> + check_backport
> + moveon=N
> + '[' master = master ']'
> + return
> + assert_diverge
> + git diff origin/master..HEAD
> + grep -q .
> ++ git log -n1 --format=%b
> ++ grep -ow -E
'([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
> ++ awk -F '#' '{print $2}'
> + reference=1635145
> + '[' -z 1635145 ']'
> ++ clang-format --version
> + clang_format='LLVM (http://llvm.org/):
> LLVM version 3.4.2
> Optimized build.
> Built Dec 7 2015 (09:37:36).
> Default target: x86_64-redhat-linux-gnu
> Host CPU: x86-64'
This is a pretty old version of clang. Maybe this is the problem?
>>>
>>> Yes. That's what I suspected too. Trying to get repos for the upgrade.
>>>
>>
>> But, what's surprising is that script exits.
>>
>
> What is the return code of clang-format? If it is non-zero then script
> will silently exit because that is what
> it is told to do.
>
> `#!/bin/sh -e' means exit on error.
>
You are right :).
[rgowdapp@rgowdapp glusterfs]$ clang-format --version ; echo $?
LLVM (http://llvm.org/):
LLVM version 3.4.2
Optimized build.
Built Dec 7 2015 (09:37:36).
Default target: x86_64-redhat-linux-gnu
Host CPU: x86-64
1
Wonder why clang-format --version has to return non-zero return code though.
> -sac
>
>
___
Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
Even I encountered the same. If you have clang version less than 6, it
exits. Upgrading clang version fixed it.
Regards,
Poornima
On Fri, Oct 5, 2018, 9:58 AM Sachidananda URS wrote:
>
>
> On Fri, Oct 5, 2018 at 9:45 AM, Raghavendra Gowdappa
> wrote:
>
>>
>>
>> On Fri, Oct 5, 2018 at 9:34 AM Raghavendra Gowdappa
>> wrote:
>>
>>>
>>>
>>> On Fri, Oct 5, 2018 at 9:11 AM Kaushal M wrote:
>>>
On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa <
rgowd...@redhat.com> wrote:
>
>
>
> On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi
wrote:
>>
>> Can you try below diff in your rfc, and let me know if it works?
>
>
> No. it didn't. I see the same error.
> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
> + rebase_changes
> + GIT_EDITOR=./rfc.sh
> + git rebase -i origin/master
> [detached HEAD e50667e] cluster/dht: clang-format dht-common.c
> 1 file changed, 10674 insertions(+), 11166 deletions(-)
> rewrite xlators/cluster/dht/src/dht-common.c (88%)
> [detached HEAD 0734847] cluster/dht: fixes to unlinking invalid
linkto file
> 1 file changed, 1 insertion(+), 1 deletion(-)
> [detached HEAD 7aeba07] rfc.sh: test - DO NOT MERGE
> 1 file changed, 8 insertions(+), 3 deletions(-)
> Successfully rebased and updated refs/heads/1635145.
> + check_backport
> + moveon=N
> + '[' master = master ']'
> + return
> + assert_diverge
> + git diff origin/master..HEAD
> + grep -q .
> ++ git log -n1 --format=%b
> ++ grep -ow -E
'([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
> ++ awk -F '#' '{print $2}'
> + reference=1635145
> + '[' -z 1635145 ']'
> ++ clang-format --version
> + clang_format='LLVM (http://llvm.org/):
> LLVM version 3.4.2
> Optimized build.
> Built Dec 7 2015 (09:37:36).
> Default target: x86_64-redhat-linux-gnu
> Host CPU: x86-64'
This is a pretty old version of clang. Maybe this is the problem?
>>>
>>> Yes. That's what I suspected too. Trying to get repos for the upgrade.
>>>
>>
>> But, what's surprising is that script exits.
>>
>
> What is the return code of clang-format? If it is non-zero then script
> will silently exit because that is what
> it is told to do.
>
> `#!/bin/sh -e' means exit on error.
>
> -sac
>
> ___
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> https://lists.gluster.org/mailman/listinfo/gluster-devel
___
Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
On Fri, Oct 5, 2018 at 9:45 AM, Raghavendra Gowdappa
wrote:
>
>
> On Fri, Oct 5, 2018 at 9:34 AM Raghavendra Gowdappa
> wrote:
>
>>
>>
>> On Fri, Oct 5, 2018 at 9:11 AM Kaushal M wrote:
>>
>>> On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa
>>> wrote:
>>> >
>>> >
>>> >
>>> > On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi
>>> wrote:
>>> >>
>>> >> Can you try below diff in your rfc, and let me know if it works?
>>> >
>>> >
>>> > No. it didn't. I see the same error.
>>> > [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
>>> > + rebase_changes
>>> > + GIT_EDITOR=./rfc.sh
>>> > + git rebase -i origin/master
>>> > [detached HEAD e50667e] cluster/dht: clang-format dht-common.c
>>> > 1 file changed, 10674 insertions(+), 11166 deletions(-)
>>> > rewrite xlators/cluster/dht/src/dht-common.c (88%)
>>> > [detached HEAD 0734847] cluster/dht: fixes to unlinking invalid linkto
>>> file
>>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>>> > [detached HEAD 7aeba07] rfc.sh: test - DO NOT MERGE
>>> > 1 file changed, 8 insertions(+), 3 deletions(-)
>>> > Successfully rebased and updated refs/heads/1635145.
>>> > + check_backport
>>> > + moveon=N
>>> > + '[' master = master ']'
>>> > + return
>>> > + assert_diverge
>>> > + git diff origin/master..HEAD
>>> > + grep -q .
>>> > ++ git log -n1 --format=%b
>>> > ++ grep -ow -E '([fF][iI][xX][eE][sS]|[uU][
>>> pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)
>>> ?(bz)?#[[:digit:]]+'
>>> > ++ awk -F '#' '{print $2}'
>>> > + reference=1635145
>>> > + '[' -z 1635145 ']'
>>> > ++ clang-format --version
>>> > + clang_format='LLVM (http://llvm.org/):
>>> > LLVM version 3.4.2
>>> > Optimized build.
>>> > Built Dec 7 2015 (09:37:36).
>>> > Default target: x86_64-redhat-linux-gnu
>>> > Host CPU: x86-64'
>>>
>>> This is a pretty old version of clang. Maybe this is the problem?
>>>
>>
>> Yes. That's what I suspected too. Trying to get repos for the upgrade.
>>
>
> But, what's surprising is that script exits.
>
What is the return code of clang-format? If it is non-zero then script will
silently exit because that is what
it is told to do.
`#!/bin/sh -e' means exit on error.
-sac
___
Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
On Fri, Oct 5, 2018 at 9:34 AM Raghavendra Gowdappa
wrote:
>
>
> On Fri, Oct 5, 2018 at 9:11 AM Kaushal M wrote:
>
>> On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa
>> wrote:
>> >
>> >
>> >
>> > On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi
>> wrote:
>> >>
>> >> Can you try below diff in your rfc, and let me know if it works?
>> >
>> >
>> > No. it didn't. I see the same error.
>> > [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
>> > + rebase_changes
>> > + GIT_EDITOR=./rfc.sh
>> > + git rebase -i origin/master
>> > [detached HEAD e50667e] cluster/dht: clang-format dht-common.c
>> > 1 file changed, 10674 insertions(+), 11166 deletions(-)
>> > rewrite xlators/cluster/dht/src/dht-common.c (88%)
>> > [detached HEAD 0734847] cluster/dht: fixes to unlinking invalid linkto
>> file
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > [detached HEAD 7aeba07] rfc.sh: test - DO NOT MERGE
>> > 1 file changed, 8 insertions(+), 3 deletions(-)
>> > Successfully rebased and updated refs/heads/1635145.
>> > + check_backport
>> > + moveon=N
>> > + '[' master = master ']'
>> > + return
>> > + assert_diverge
>> > + git diff origin/master..HEAD
>> > + grep -q .
>> > ++ git log -n1 --format=%b
>> > ++ grep -ow -E
>> '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
>> > ++ awk -F '#' '{print $2}'
>> > + reference=1635145
>> > + '[' -z 1635145 ']'
>> > ++ clang-format --version
>> > + clang_format='LLVM (http://llvm.org/):
>> > LLVM version 3.4.2
>> > Optimized build.
>> > Built Dec 7 2015 (09:37:36).
>> > Default target: x86_64-redhat-linux-gnu
>> > Host CPU: x86-64'
>>
>> This is a pretty old version of clang. Maybe this is the problem?
>>
>
> Yes. That's what I suspected too. Trying to get repos for the upgrade.
>
But, what's surprising is that script exits.
>
>
>>
>> >
>> >>
>> >> ```
>> >>>
>> >>> diff --git a/rfc.sh b/rfc.sh
>> >>> index 607fd7528f..4ffef26ca1 100755
>> >>> --- a/rfc.sh
>> >>> +++ b/rfc.sh
>> >>> @@ -321,21 +321,21 @@ main()
>> >>> fi
>> >>>
>> >>> # TODO: add clang-format command here. It will after the changes
>> are done everywhere else
>> >>> +set +e
>> >>> clang_format=$(clang-format --version)
>> >>> if [ ! -z "${clang_format}" ]; then
>> >>> # Considering git show may not give any files as output
>> matching the
>> >>> # criteria, good to tell script not to fail on error
>> >>> -set +e
>> >>> list_of_files=$(git show --pretty="format:" --name-only |
>> >>> grep -v "contrib/" | egrep --color=never
>> "*\.[ch]$");
>> >>> if [ ! -z "${list_of_files}" ]; then
>> >>> echo "${list_of_files}" | xargs clang-format -i
>> >>> fi
>> >>> -set -e
>> >>> else
>> >>> echo "High probability of your patch not passing smoke due
>> to coding standard check"
>> >>> echo "Please install 'clang-format' to format the patch
>> before submitting"
>> >>> fi
>> >>> +set -e
>> >>>
>> >>> if [ "$DRY_RUN" = 1 ]; then
>> >>> drier='echo -e Please use the following command to send your
>> commits to review:\n\n'
>> >>
>> >> ```
>> >> -Amar
>> >>
>> >> On Fri, Oct 5, 2018 at 8:09 AM Raghavendra Gowdappa <
>> rgowd...@redhat.com> wrote:
>> >>>
>> >>> All,
>> >>>
>> >>> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
>> >>> + rebase_changes
>> >>> + GIT_EDITOR=./rfc.sh
>> >>> + git rebase -i origin/master
>> >>> [detached HEAD 34fabdd] cluster/dht: clang-format dht-common.c
>> >>> 1 file changed, 10674 insertions(+), 11166 deletions(-)
>> >>> rewrite xlators/cluster/dht/src/dht-common.c (88%)
>> >>> [detached HEAD 4bbcbf9] cluster/dht: fixes to unlinking invalid
>> linkto file
>> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>> [detached HEAD c5583ea] rfc.sh: test - DO NOT MERGE
>> >>> 1 file changed, 8 insertions(+), 3 deletions(-)
>> >>> Successfully rebased and updated refs/heads/1635145.
>> >>> + check_backport
>> >>> + moveon=N
>> >>> + '[' master = master ']'
>> >>> + return
>> >>> + assert_diverge
>> >>> + git diff origin/master..HEAD
>> >>> + grep -q .
>> >>> ++ git log -n1 --format=%b
>> >>> ++ grep -ow -E
>> '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
>> >>> ++ awk -F '#' '{print $2}'
>> >>> + reference=1635145
>> >>> + '[' -z 1635145 ']'
>> >>> ++ clang-format --version
>> >>> + clang_format='LLVM (http://llvm.org/):
>> >>> LLVM version 3.4.2
>> >>> Optimized build.
>> >>> Built Dec 7 2015 (09:37:36).
>> >>> Default target: x86_64-redhat-linux-gnu
>> >>> Host CPU: x86-64'
>> >>>
>> >>> Looks like the script is exiting right after it completes
>> clang-format --version. Nothing after that statement gets executed (did it
>> crash? I don't see any cores). Any help is appreciated
>> >>>
>> >>> regards,
>> >>> Raghavendra
>> >>>
>> >>> ___
>> >>>
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
On Fri, Oct 5, 2018 at 9:11 AM Kaushal M wrote:
> On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa
> wrote:
> >
> >
> >
> > On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi
> wrote:
> >>
> >> Can you try below diff in your rfc, and let me know if it works?
> >
> >
> > No. it didn't. I see the same error.
> > [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
> > + rebase_changes
> > + GIT_EDITOR=./rfc.sh
> > + git rebase -i origin/master
> > [detached HEAD e50667e] cluster/dht: clang-format dht-common.c
> > 1 file changed, 10674 insertions(+), 11166 deletions(-)
> > rewrite xlators/cluster/dht/src/dht-common.c (88%)
> > [detached HEAD 0734847] cluster/dht: fixes to unlinking invalid linkto
> file
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > [detached HEAD 7aeba07] rfc.sh: test - DO NOT MERGE
> > 1 file changed, 8 insertions(+), 3 deletions(-)
> > Successfully rebased and updated refs/heads/1635145.
> > + check_backport
> > + moveon=N
> > + '[' master = master ']'
> > + return
> > + assert_diverge
> > + git diff origin/master..HEAD
> > + grep -q .
> > ++ git log -n1 --format=%b
> > ++ grep -ow -E
> '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
> > ++ awk -F '#' '{print $2}'
> > + reference=1635145
> > + '[' -z 1635145 ']'
> > ++ clang-format --version
> > + clang_format='LLVM (http://llvm.org/):
> > LLVM version 3.4.2
> > Optimized build.
> > Built Dec 7 2015 (09:37:36).
> > Default target: x86_64-redhat-linux-gnu
> > Host CPU: x86-64'
>
> This is a pretty old version of clang. Maybe this is the problem?
>
Yes. That's what I suspected too. Trying to get repos for the upgrade.
>
> >
> >>
> >> ```
> >>>
> >>> diff --git a/rfc.sh b/rfc.sh
> >>> index 607fd7528f..4ffef26ca1 100755
> >>> --- a/rfc.sh
> >>> +++ b/rfc.sh
> >>> @@ -321,21 +321,21 @@ main()
> >>> fi
> >>>
> >>> # TODO: add clang-format command here. It will after the changes
> are done everywhere else
> >>> +set +e
> >>> clang_format=$(clang-format --version)
> >>> if [ ! -z "${clang_format}" ]; then
> >>> # Considering git show may not give any files as output
> matching the
> >>> # criteria, good to tell script not to fail on error
> >>> -set +e
> >>> list_of_files=$(git show --pretty="format:" --name-only |
> >>> grep -v "contrib/" | egrep --color=never
> "*\.[ch]$");
> >>> if [ ! -z "${list_of_files}" ]; then
> >>> echo "${list_of_files}" | xargs clang-format -i
> >>> fi
> >>> -set -e
> >>> else
> >>> echo "High probability of your patch not passing smoke due to
> coding standard check"
> >>> echo "Please install 'clang-format' to format the patch
> before submitting"
> >>> fi
> >>> +set -e
> >>>
> >>> if [ "$DRY_RUN" = 1 ]; then
> >>> drier='echo -e Please use the following command to send your
> commits to review:\n\n'
> >>
> >> ```
> >> -Amar
> >>
> >> On Fri, Oct 5, 2018 at 8:09 AM Raghavendra Gowdappa <
> rgowd...@redhat.com> wrote:
> >>>
> >>> All,
> >>>
> >>> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
> >>> + rebase_changes
> >>> + GIT_EDITOR=./rfc.sh
> >>> + git rebase -i origin/master
> >>> [detached HEAD 34fabdd] cluster/dht: clang-format dht-common.c
> >>> 1 file changed, 10674 insertions(+), 11166 deletions(-)
> >>> rewrite xlators/cluster/dht/src/dht-common.c (88%)
> >>> [detached HEAD 4bbcbf9] cluster/dht: fixes to unlinking invalid linkto
> file
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>> [detached HEAD c5583ea] rfc.sh: test - DO NOT MERGE
> >>> 1 file changed, 8 insertions(+), 3 deletions(-)
> >>> Successfully rebased and updated refs/heads/1635145.
> >>> + check_backport
> >>> + moveon=N
> >>> + '[' master = master ']'
> >>> + return
> >>> + assert_diverge
> >>> + git diff origin/master..HEAD
> >>> + grep -q .
> >>> ++ git log -n1 --format=%b
> >>> ++ grep -ow -E
> '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
> >>> ++ awk -F '#' '{print $2}'
> >>> + reference=1635145
> >>> + '[' -z 1635145 ']'
> >>> ++ clang-format --version
> >>> + clang_format='LLVM (http://llvm.org/):
> >>> LLVM version 3.4.2
> >>> Optimized build.
> >>> Built Dec 7 2015 (09:37:36).
> >>> Default target: x86_64-redhat-linux-gnu
> >>> Host CPU: x86-64'
> >>>
> >>> Looks like the script is exiting right after it completes clang-format
> --version. Nothing after that statement gets executed (did it crash? I
> don't see any cores). Any help is appreciated
> >>>
> >>> regards,
> >>> Raghavendra
> >>>
> >>> ___
> >>> Gluster-devel mailing list
> >>> Gluster-devel@gluster.org
> >>> https://lists.gluster.org/mailman/listinfo/gluster-devel
> >>
> >>
> >>
> >> --
> >> Amar Tumballi (amarts)
> >
> > ___
> > Gluster-devel mailing list
> >
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa wrote:
>
>
>
> On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi wrote:
>>
>> Can you try below diff in your rfc, and let me know if it works?
>
>
> No. it didn't. I see the same error.
> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
> + rebase_changes
> + GIT_EDITOR=./rfc.sh
> + git rebase -i origin/master
> [detached HEAD e50667e] cluster/dht: clang-format dht-common.c
> 1 file changed, 10674 insertions(+), 11166 deletions(-)
> rewrite xlators/cluster/dht/src/dht-common.c (88%)
> [detached HEAD 0734847] cluster/dht: fixes to unlinking invalid linkto file
> 1 file changed, 1 insertion(+), 1 deletion(-)
> [detached HEAD 7aeba07] rfc.sh: test - DO NOT MERGE
> 1 file changed, 8 insertions(+), 3 deletions(-)
> Successfully rebased and updated refs/heads/1635145.
> + check_backport
> + moveon=N
> + '[' master = master ']'
> + return
> + assert_diverge
> + git diff origin/master..HEAD
> + grep -q .
> ++ git log -n1 --format=%b
> ++ grep -ow -E
> '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
> ++ awk -F '#' '{print $2}'
> + reference=1635145
> + '[' -z 1635145 ']'
> ++ clang-format --version
> + clang_format='LLVM (http://llvm.org/):
> LLVM version 3.4.2
> Optimized build.
> Built Dec 7 2015 (09:37:36).
> Default target: x86_64-redhat-linux-gnu
> Host CPU: x86-64'
This is a pretty old version of clang. Maybe this is the problem?
>
>>
>> ```
>>>
>>> diff --git a/rfc.sh b/rfc.sh
>>> index 607fd7528f..4ffef26ca1 100755
>>> --- a/rfc.sh
>>> +++ b/rfc.sh
>>> @@ -321,21 +321,21 @@ main()
>>> fi
>>>
>>> # TODO: add clang-format command here. It will after the changes are
>>> done everywhere else
>>> +set +e
>>> clang_format=$(clang-format --version)
>>> if [ ! -z "${clang_format}" ]; then
>>> # Considering git show may not give any files as output matching
>>> the
>>> # criteria, good to tell script not to fail on error
>>> -set +e
>>> list_of_files=$(git show --pretty="format:" --name-only |
>>> grep -v "contrib/" | egrep --color=never
>>> "*\.[ch]$");
>>> if [ ! -z "${list_of_files}" ]; then
>>> echo "${list_of_files}" | xargs clang-format -i
>>> fi
>>> -set -e
>>> else
>>> echo "High probability of your patch not passing smoke due to
>>> coding standard check"
>>> echo "Please install 'clang-format' to format the patch before
>>> submitting"
>>> fi
>>> +set -e
>>>
>>> if [ "$DRY_RUN" = 1 ]; then
>>> drier='echo -e Please use the following command to send your
>>> commits to review:\n\n'
>>
>> ```
>> -Amar
>>
>> On Fri, Oct 5, 2018 at 8:09 AM Raghavendra Gowdappa
>> wrote:
>>>
>>> All,
>>>
>>> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
>>> + rebase_changes
>>> + GIT_EDITOR=./rfc.sh
>>> + git rebase -i origin/master
>>> [detached HEAD 34fabdd] cluster/dht: clang-format dht-common.c
>>> 1 file changed, 10674 insertions(+), 11166 deletions(-)
>>> rewrite xlators/cluster/dht/src/dht-common.c (88%)
>>> [detached HEAD 4bbcbf9] cluster/dht: fixes to unlinking invalid linkto file
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> [detached HEAD c5583ea] rfc.sh: test - DO NOT MERGE
>>> 1 file changed, 8 insertions(+), 3 deletions(-)
>>> Successfully rebased and updated refs/heads/1635145.
>>> + check_backport
>>> + moveon=N
>>> + '[' master = master ']'
>>> + return
>>> + assert_diverge
>>> + git diff origin/master..HEAD
>>> + grep -q .
>>> ++ git log -n1 --format=%b
>>> ++ grep -ow -E
>>> '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
>>> ++ awk -F '#' '{print $2}'
>>> + reference=1635145
>>> + '[' -z 1635145 ']'
>>> ++ clang-format --version
>>> + clang_format='LLVM (http://llvm.org/):
>>> LLVM version 3.4.2
>>> Optimized build.
>>> Built Dec 7 2015 (09:37:36).
>>> Default target: x86_64-redhat-linux-gnu
>>> Host CPU: x86-64'
>>>
>>> Looks like the script is exiting right after it completes clang-format
>>> --version. Nothing after that statement gets executed (did it crash? I
>>> don't see any cores). Any help is appreciated
>>>
>>> regards,
>>> Raghavendra
>>>
>>> ___
>>> Gluster-devel mailing list
>>> Gluster-devel@gluster.org
>>> https://lists.gluster.org/mailman/listinfo/gluster-devel
>>
>>
>>
>> --
>> Amar Tumballi (amarts)
>
> ___
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> https://lists.gluster.org/mailman/listinfo/gluster-devel
___
Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi wrote:
> Can you try below diff in your rfc, and let me know if it works?
>
No. it didn't. I see the same error.
[rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
+ rebase_changes
+ GIT_EDITOR=./rfc.sh
+ git rebase -i origin/master
[detached HEAD e50667e] cluster/dht: clang-format dht-common.c
1 file changed, 10674 insertions(+), 11166 deletions(-)
rewrite xlators/cluster/dht/src/dht-common.c (88%)
[detached HEAD 0734847] cluster/dht: fixes to unlinking invalid linkto file
1 file changed, 1 insertion(+), 1 deletion(-)
[detached HEAD 7aeba07] rfc.sh: test - DO NOT MERGE
1 file changed, 8 insertions(+), 3 deletions(-)
Successfully rebased and updated refs/heads/1635145.
+ check_backport
+ moveon=N
+ '[' master = master ']'
+ return
+ assert_diverge
+ git diff origin/master..HEAD
+ grep -q .
++ git log -n1 --format=%b
++ grep -ow -E
'([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
++ awk -F '#' '{print $2}'
+ reference=1635145
+ '[' -z 1635145 ']'
++ clang-format --version
+ clang_format='LLVM (http://llvm.org/):
LLVM version 3.4.2
Optimized build.
Built Dec 7 2015 (09:37:36).
Default target: x86_64-redhat-linux-gnu
Host CPU: x86-64'
> ```
>
>> diff --git a/rfc.sh b/rfc.sh
>> index 607fd7528f..4ffef26ca1 100755
>> --- a/rfc.sh
>> +++ b/rfc.sh
>> @@ -321,21 +321,21 @@ main()
>> fi
>>
>> # TODO: add clang-format command here. It will after the changes are
>> done everywhere else
>> +set +e
>> clang_format=$(clang-format --version)
>> if [ ! -z "${clang_format}" ]; then
>> # Considering git show may not give any files as output matching
>> the
>> # criteria, good to tell script not to fail on error
>> -set +e
>> list_of_files=$(git show --pretty="format:" --name-only |
>> grep -v "contrib/" | egrep --color=never
>> "*\.[ch]$");
>> if [ ! -z "${list_of_files}" ]; then
>> echo "${list_of_files}" | xargs clang-format -i
>> fi
>> -set -e
>> else
>> echo "High probability of your patch not passing smoke due to
>> coding standard check"
>> echo "Please install 'clang-format' to format the patch before
>> submitting"
>> fi
>> +set -e
>>
>> if [ "$DRY_RUN" = 1 ]; then
>> drier='echo -e Please use the following command to send your
>> commits to review:\n\n'
>
> ```
> -Amar
>
> On Fri, Oct 5, 2018 at 8:09 AM Raghavendra Gowdappa
> wrote:
>
>> All,
>>
>> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
>> + rebase_changes
>> + GIT_EDITOR=./rfc.sh
>> + git rebase -i origin/master
>> [detached HEAD 34fabdd] cluster/dht: clang-format dht-common.c
>> 1 file changed, 10674 insertions(+), 11166 deletions(-)
>> rewrite xlators/cluster/dht/src/dht-common.c (88%)
>> [detached HEAD 4bbcbf9] cluster/dht: fixes to unlinking invalid linkto
>> file
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> [detached HEAD c5583ea] rfc.sh: test - DO NOT MERGE
>> 1 file changed, 8 insertions(+), 3 deletions(-)
>> Successfully rebased and updated refs/heads/1635145.
>> + check_backport
>> + moveon=N
>> + '[' master = master ']'
>> + return
>> + assert_diverge
>> + git diff origin/master..HEAD
>> + grep -q .
>> ++ git log -n1 --format=%b
>> ++ grep -ow -E
>> '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
>> ++ awk -F '#' '{print $2}'
>> + reference=1635145
>> + '[' -z 1635145 ']'
>> ++ clang-format --version
>> + clang_format='LLVM (http://llvm.org/):
>> LLVM version 3.4.2
>> Optimized build.
>> Built Dec 7 2015 (09:37:36).
>> Default target: x86_64-redhat-linux-gnu
>> Host CPU: x86-64'
>>
>> Looks like the script is exiting right after it completes clang-format
>> --version. Nothing after that statement gets executed (did it crash? I
>> don't see any cores). Any help is appreciated
>>
>> regards,
>> Raghavendra
>>
>> ___
>> Gluster-devel mailing list
>> Gluster-devel@gluster.org
>> https://lists.gluster.org/mailman/listinfo/gluster-devel
>
>
>
> --
> Amar Tumballi (amarts)
>
___
Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] ./rfc.sh not pushing patch to gerrit
Can you try below diff in your rfc, and let me know if it works?
```
> diff --git a/rfc.sh b/rfc.sh
> index 607fd7528f..4ffef26ca1 100755
> --- a/rfc.sh
> +++ b/rfc.sh
> @@ -321,21 +321,21 @@ main()
> fi
>
> # TODO: add clang-format command here. It will after the changes are
> done everywhere else
> +set +e
> clang_format=$(clang-format --version)
> if [ ! -z "${clang_format}" ]; then
> # Considering git show may not give any files as output matching
> the
> # criteria, good to tell script not to fail on error
> -set +e
> list_of_files=$(git show --pretty="format:" --name-only |
> grep -v "contrib/" | egrep --color=never
> "*\.[ch]$");
> if [ ! -z "${list_of_files}" ]; then
> echo "${list_of_files}" | xargs clang-format -i
> fi
> -set -e
> else
> echo "High probability of your patch not passing smoke due to
> coding standard check"
> echo "Please install 'clang-format' to format the patch before
> submitting"
> fi
> +set -e
>
> if [ "$DRY_RUN" = 1 ]; then
> drier='echo -e Please use the following command to send your
> commits to review:\n\n'
```
-Amar
On Fri, Oct 5, 2018 at 8:09 AM Raghavendra Gowdappa
wrote:
> All,
>
> [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
> + rebase_changes
> + GIT_EDITOR=./rfc.sh
> + git rebase -i origin/master
> [detached HEAD 34fabdd] cluster/dht: clang-format dht-common.c
> 1 file changed, 10674 insertions(+), 11166 deletions(-)
> rewrite xlators/cluster/dht/src/dht-common.c (88%)
> [detached HEAD 4bbcbf9] cluster/dht: fixes to unlinking invalid linkto file
> 1 file changed, 1 insertion(+), 1 deletion(-)
> [detached HEAD c5583ea] rfc.sh: test - DO NOT MERGE
> 1 file changed, 8 insertions(+), 3 deletions(-)
> Successfully rebased and updated refs/heads/1635145.
> + check_backport
> + moveon=N
> + '[' master = master ']'
> + return
> + assert_diverge
> + git diff origin/master..HEAD
> + grep -q .
> ++ git log -n1 --format=%b
> ++ grep -ow -E
> '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
> ++ awk -F '#' '{print $2}'
> + reference=1635145
> + '[' -z 1635145 ']'
> ++ clang-format --version
> + clang_format='LLVM (http://llvm.org/):
> LLVM version 3.4.2
> Optimized build.
> Built Dec 7 2015 (09:37:36).
> Default target: x86_64-redhat-linux-gnu
> Host CPU: x86-64'
>
> Looks like the script is exiting right after it completes clang-format
> --version. Nothing after that statement gets executed (did it crash? I
> don't see any cores). Any help is appreciated
>
> regards,
> Raghavendra
>
> ___
> Gluster-devel mailing list
> Gluster-devel@gluster.org
> https://lists.gluster.org/mailman/listinfo/gluster-devel
--
Amar Tumballi (amarts)
___
Gluster-devel mailing list
Gluster-devel@gluster.org
https://lists.gluster.org/mailman/listinfo/gluster-devel
