Re: [Gluster-users] trashcan file size limit

2016-10-20 Thread Jackie Tung 
Thanks for the quick response here.

How does this make it to a release?  Should I hope for it in 3.8.6?

> On Oct 20, 2016, at 11:48 AM, Jiffin Tony Thottan  wrote:
> 
> 
> 
> On 19/10/16 20:54, Jackie Tung wrote:
>> Thanks Jiffin, filed https://bugzilla.redhat.com/show_bug.cgi?id=1386766 
>> 
>> 
>> In my limited knowledge of the original reasons for 1GB hardcode, either 
>> removing the limit altogether, or an additional “override" option parameter 
>> would be preferable in my humble opinion.
>> 
> 
> 
> Thanks for filing the bug, patch posted for addressing this issue 
> http://review.gluster.org/15689 
> --
> Jiffin
> 
>>> On Oct 19, 2016, at 2:02 AM, Jiffin Tony Thottan >> > wrote:
>>> 
>>> Hi Jackie,
>>> 
>>> On 18/10/16 23:48, Jackie Tung wrote:
 Hi all,
 
 Documentation says:  
 https://gluster.readthedocs.io/en/latest/Administrator%20Guide/Trash/ 
 
 
 gluster volume set  features.trash-max-filesize 
 
 This command can be used to filter files entering trash directory based on 
 their size. Files above trash_max_filesize are deleted/truncated 
 directly.Value for size may be followed by multiplicative suffixes as 
 KB(=1024 bytes), MB(=1024*1024 bytes) and GB(=1024*1024*1024 bytes). 
 Default size is set to 5MB. Considering the fact that trash directory is 
 consuming the glusterfs volume space, trash feature is implemented to 
 function in such a way that it directly deletes/truncates files with size 
 > 1GB even if this option is set to some value greater than 1GB.
 
 Is there any workaround (short of changing source code and rebuilding) 
 that can allow me to override this 1GB hard limit?  We store a lot of 
 large files, and having a limit of 1GB greatly reduces the value of this 
 trashcan feature for us.
 
>>> 
>>> 
>>> I don't remember exactly reason behind having a hard coded value for upper 
>>> boundary, one reason may be to limit space used 
>>> by trash directory and for truncate operation it result in performance hit. 
>>> The hard coded value can be found at 
>>> xlators/features/trash/src/trash.h:32 (GF_ALLOWED_MAX_FILE_SIZE) . If you 
>>> are interested , then change value(according to 
>>> your preference) in the code and send out a patch to 
>>> http://review.gluster.org/  as well.
>>> 
>>> As first step please file a bug https://bugzilla.redhat.com/ 
>>>  under community->glusterfs->trash xlator.
>>> 
>>> Regards,
>>> Jiffin
>>> 
 Many thanks,
 Jackie
 
 
 
 
 
 The information in this email is confidential and may be legally 
 privileged. It is intended solely for the addressee. Access to this email 
 by anyone else is unauthorized. If you are not the intended recipient, any 
 disclosure, copying, distribution or any action taken or omitted to be 
 taken in reliance on it, is prohibited and may be unlawful.
 
 
 
 ___
 Gluster-users mailing list
 Gluster-users@gluster.org 
 http://www.gluster.org/mailman/listinfo/gluster-users 
 
>> 
>> 
>> The information in this email is confidential and may be legally privileged. 
>> It is intended solely for the addressee. Access to this email by anyone else 
>> is unauthorized. If you are not the intended recipient, any disclosure, 
>> copying, distribution or any action taken or omitted to be taken in reliance 
>> on it, is prohibited and may be unlawful.
>> 
> 


-- 
 

The information in this email is confidential and may be legally 
privileged. It is intended solely for the addressee. Access to this email 
by anyone else is unauthorized. If you are not the intended recipient, any 
disclosure, copying, distribution or any action taken or omitted to be 
taken in reliance on it, is prohibited and may be unlawful.
___
Gluster-users mailing list
Gluster-users@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-users

Re: [Gluster-users] trashcan file size limit

2016-10-20 Thread Jiffin Tony Thottan 



On 19/10/16 20:54, Jackie Tung wrote:

Thanks Jiffin, filed https://bugzilla.redhat.com/show_bug.cgi?id=1386766

In my limited knowledge of the original reasons for 1GB hardcode, 
either removing the limit altogether, or an additional “override" 
option parameter would be preferable in my humble opinion.





Thanks for filing the bug, patch posted for addressing this issue 
http://review.gluster.org/15689

--
Jiffin

On Oct 19, 2016, at 2:02 AM, Jiffin Tony Thottan > wrote:


Hi Jackie,


On 18/10/16 23:48, Jackie Tung wrote:

Hi all,

Documentation says: 
https://gluster.readthedocs.io/en/latest/Administrator%20Guide/Trash/


*/gluster volume set  features.trash-max-filesize /*

This command can be used to filter files entering trash directory 
based on their size. Files above trash_max_filesize are 
deleted/truncated directly.Value for size may be followed by 
multiplicative suffixes as KB(=1024 bytes), MB(=1024*1024 bytes) and 
GB(=1024*1024*1024 bytes). Default size is set to 5MB. Considering 
the fact that trash directory is consuming the glusterfs volume 
space, trash feature is implemented to function in such a way 
that*it directly deletes/truncates files with size > 1GB even if 
this option is set to some value greater than 1GB.*


Is there any workaround (short of changing source code and 
rebuilding) that can allow me to override this 1GB hard limit?  We 
store a lot of large files, and having a limit of 1GB greatly 
reduces the value of this trashcan feature for us.





I don't remember exactly reason behind having a hard coded value for 
upper boundary, one reason may be to limit space used
by trash directory and for truncate operation it result in 
performance hit. The hard coded value can be found at
xlators/features/trash/src/trash.h:32 (GF_ALLOWED_MAX_FILE_SIZE) . If 
you are interested , then change value(according to
your preference) in the code and send out a patch to 
http://review.gluster.org/ as well.


As first step please file a bug https://bugzilla.redhat.com/ under 
community->glusterfs->trash xlator.


Regards,
Jiffin


Many thanks,
Jackie





The information in this email is confidential and may be legally 
privileged. It is intended solely for the addressee. Access to this 
email by anyone else is unauthorized. If you are not the intended 
recipient, any disclosure, copying, distribution or any action taken 
or omitted to be taken in reliance on it, is prohibited and may be 
unlawful.




___
Gluster-users mailing list
Gluster-users@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-users





The information in this email is confidential and may be legally 
privileged. It is intended solely for the addressee. Access to this 
email by anyone else is unauthorized. If you are not the intended 
recipient, any disclosure, copying, distribution or any action taken 
or omitted to be taken in reliance on it, is prohibited and may be 
unlawful.




___
Gluster-users mailing list
Gluster-users@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-users

Re: [Gluster-users] trashcan file size limit

2016-10-19 Thread Jackie Tung 
Thanks Jiffin, filed https://bugzilla.redhat.com/show_bug.cgi?id=1386766 


In my limited knowledge of the original reasons for 1GB hardcode, either 
removing the limit altogether, or an additional “override" option parameter 
would be preferable in my humble opinion.

> On Oct 19, 2016, at 2:02 AM, Jiffin Tony Thottan  wrote:
> 
> Hi Jackie,
> 
> On 18/10/16 23:48, Jackie Tung wrote:
>> Hi all,
>> 
>> Documentation says:  
>> https://gluster.readthedocs.io/en/latest/Administrator%20Guide/Trash/ 
>> 
>> 
>> gluster volume set  features.trash-max-filesize 
>> 
>> This command can be used to filter files entering trash directory based on 
>> their size. Files above trash_max_filesize are deleted/truncated 
>> directly.Value for size may be followed by multiplicative suffixes as 
>> KB(=1024 bytes), MB(=1024*1024 bytes) and GB(=1024*1024*1024 bytes). Default 
>> size is set to 5MB. Considering the fact that trash directory is consuming 
>> the glusterfs volume space, trash feature is implemented to function in such 
>> a way that it directly deletes/truncates files with size > 1GB even if this 
>> option is set to some value greater than 1GB.
>> 
>> Is there any workaround (short of changing source code and rebuilding) that 
>> can allow me to override this 1GB hard limit?  We store a lot of large 
>> files, and having a limit of 1GB greatly reduces the value of this trashcan 
>> feature for us.
>> 
> 
> 
> I don't remember exactly reason behind having a hard coded value for upper 
> boundary, one reason may be to limit space used 
> by trash directory and for truncate operation it result in performance hit. 
> The hard coded value can be found at 
> xlators/features/trash/src/trash.h:32 (GF_ALLOWED_MAX_FILE_SIZE) . If you are 
> interested , then change value(according to 
> your preference) in the code and send out a patch to 
> http://review.gluster.org/  as well.
> 
> As first step please file a bug https://bugzilla.redhat.com/ 
>  under community->glusterfs->trash xlator.
> 
> Regards,
> Jiffin
> 
>> Many thanks,
>> Jackie
>> 
>> 
>> 
>> 
>> 
>> The information in this email is confidential and may be legally privileged. 
>> It is intended solely for the addressee. Access to this email by anyone else 
>> is unauthorized. If you are not the intended recipient, any disclosure, 
>> copying, distribution or any action taken or omitted to be taken in reliance 
>> on it, is prohibited and may be unlawful.
>> 
>> 
>> 
>> ___
>> Gluster-users mailing list
>> Gluster-users@gluster.org 
>> http://www.gluster.org/mailman/listinfo/gluster-users 
>> 


-- 
 

The information in this email is confidential and may be legally 
privileged. It is intended solely for the addressee. Access to this email 
by anyone else is unauthorized. If you are not the intended recipient, any 
disclosure, copying, distribution or any action taken or omitted to be 
taken in reliance on it, is prohibited and may be unlawful.
___
Gluster-users mailing list
Gluster-users@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-users

Re: [Gluster-users] trashcan file size limit

2016-10-19 Thread Jiffin Tony Thottan 

Hi Jackie,


On 18/10/16 23:48, Jackie Tung wrote:

Hi all,

Documentation says: 
https://gluster.readthedocs.io/en/latest/Administrator%20Guide/Trash/


*/gluster volume set  features.trash-max-filesize /*

This command can be used to filter files entering trash directory 
based on their size. Files above trash_max_filesize are 
deleted/truncated directly.Value for size may be followed by 
multiplicative suffixes as KB(=1024 bytes), MB(=1024*1024 bytes) and 
GB(=1024*1024*1024 bytes). Default size is set to 5MB. Considering the 
fact that trash directory is consuming the glusterfs volume space, 
trash feature is implemented to function in such a way that*it 
directly deletes/truncates files with size > 1GB even if this option 
is set to some value greater than 1GB.*


Is there any workaround (short of changing source code and rebuilding) 
that can allow me to override this 1GB hard limit?  We store a lot of 
large files, and having a limit of 1GB greatly reduces the value of 
this trashcan feature for us.





I don't remember exactly reason behind having a hard coded value for 
upper boundary, one reason may be to limit space used
by trash directory and for truncate operation it result in performance 
hit. The hard coded value can be found at
xlators/features/trash/src/trash.h:32 (GF_ALLOWED_MAX_FILE_SIZE) . If 
you are interested , then change value(according to
your preference) in the code and send out a patch to 
http://review.gluster.org/ as well.


As first step please file a bug https://bugzilla.redhat.com/ under 
community->glusterfs->trash xlator.


Regards,
Jiffin


Many thanks,
Jackie





The information in this email is confidential and may be legally 
privileged. It is intended solely for the addressee. Access to this 
email by anyone else is unauthorized. If you are not the intended 
recipient, any disclosure, copying, distribution or any action taken 
or omitted to be taken in reliance on it, is prohibited and may be 
unlawful.




___
Gluster-users mailing list
Gluster-users@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-users


___
Gluster-users mailing list
Gluster-users@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-users

Re: [Gluster-users] trashcan file size limit

2016-10-18 Thread Gandalf Corvotempesta 
2016-10-18 20:18 GMT+02:00 Jackie Tung :
> Considering the fact that trash directory is consuming
> the glusterfs volume space, trash feature is implemented to function in such
> a way that it directly deletes/truncates files with size > 1GB even if this
> option is set to some value greater than 1GB.

Why adding "features.trash-max-filesize" option if this option can't
be used totally?
Cluster administrator should be able to choose the max size on it's
own and also be able to choose 40GB as max size.

Is not possible to remove this hard-coded limit ?
___
Gluster-users mailing list
Gluster-users@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-users

[Gluster-users] trashcan file size limit

2016-10-18 Thread Jackie Tung 
Hi all,

Documentation says:  
https://gluster.readthedocs.io/en/latest/Administrator%20Guide/Trash/ 


gluster volume set  features.trash-max-filesize 

This command can be used to filter files entering trash directory based on 
their size. Files above trash_max_filesize are deleted/truncated directly.Value 
for size may be followed by multiplicative suffixes as KB(=1024 bytes), 
MB(=1024*1024 bytes) and GB(=1024*1024*1024 bytes). Default size is set to 5MB. 
Considering the fact that trash directory is consuming the glusterfs volume 
space, trash feature is implemented to function in such a way that it directly 
deletes/truncates files with size > 1GB even if this option is set to some 
value greater than 1GB.

Is there any workaround (short of changing source code and rebuilding) that can 
allow me to override this 1GB hard limit?  We store a lot of large files, and 
having a limit of 1GB greatly reduces the value of this trashcan feature for us.

Many thanks,
Jackie





-- 
 

The information in this email is confidential and may be legally 
privileged. It is intended solely for the addressee. Access to this email 
by anyone else is unauthorized. If you are not the intended recipient, any 
disclosure, copying, distribution or any action taken or omitted to be 
taken in reliance on it, is prohibited and may be unlawful.
___
Gluster-users mailing list
Gluster-users@gluster.org
http://www.gluster.org/mailman/listinfo/gluster-users