Re: Bug found in nightbuilds

2014-02-16 Thread Torbjorn Granlund
bodr...@mail.dm.unipi.it writes: Code says: if (d GMP_NUMB_HIGHBIT) { /* Normalized case */ uh = up[--n]; /* Here n goes to 0 */ ... if (BELOW_THRESHOLD (n, DIV_QR_1_NORM_THRESHOLD)) { while (n 0) udiv_qrnnd (...);

Re: Bug found in nightbuilds

2014-02-16 Thread Niels Möller
Torbjorn Granlund t...@gmplib.org writes: Also, keeping DIV_QR_1_UNNORM_THRESHOLD = 1 surely does the job, but it puts another test it the critical path. Perhaps that's unavoidable, I haven't checked. I'm not entirely sure I follow you, but I guess the alternative is something like if (nn

Re: Bug found in nightbuilds

2014-02-16 Thread bodrato
Ciao, Il Dom, 16 Febbraio 2014 5:45 pm, Torbjorn Granlund ha scritto: bodr...@mail.dm.unipi.it writes: I disallowed zero DIV_QR_1_NORM_THRESHOLD with this patch: Since we control these thresholds at the source level, if it is desirable to keep DIV_QR_1_UNNORM_THRESHOLD = 1, that should be

Re: Bug found in nightbuilds

2014-02-16 Thread Niels Möller
Torbjorn Granlund t...@gmplib.org writes: Since we control these thresholds at the source level, if it is desirable to keep DIV_QR_1_UNNORM_THRESHOLD = 1, that should be done in tuneup. It uses DIV_1_PARAMS settings, which includes param.min_size = 2. So it should get zero only to indicate