Re: Move -DNO_ASM to config.h?

2016-03-22 Thread Vincent Lefevre
On 2016-03-21 16:01:25 +0100, Marc Glisse wrote: > In https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69134 ( > https://gcc.gnu.org/ml/gcc-patches/2016-01/msg00127.html ), users > specifically wanted to disable MPFR's copy ;-) That's because they're using a very old MPFR version (2.4.2). Normally,

Re: Move -DNO_ASM to config.h?

2016-03-21 Thread Marc Glisse
On Mon, 21 Mar 2016, Vincent Lefevre wrote: On 2016-03-20 12:14:49 +0100, Marc Glisse wrote: but it seems likely that a user who went to the trouble of disabling assembly for GMP doesn't want to use that same assembly in MPFR. I'm not so sure about that. AFAIK, longlong.h has far less asm

Re: Move -DNO_ASM to config.h?

2016-03-21 Thread Vincent Lefevre
On 2016-03-20 12:14:49 +0100, Marc Glisse wrote: > I am guessing that, just like they want to use the exact same flags as GMP > to compile (__GMP_CFLAGS), they also want to mimic this part of the build > process. I don't know if their version of longlong.h is kept in sync with > GMP's, We try to

Re: Move -DNO_ASM to config.h?

2016-03-20 Thread Torbjörn Granlund
Marc Glisse writes: I currently think I'll go with just config.h (no CFLAGS). sgtm -- Torbjörn Please encrypt, key id 0xC8601622 ___ gmp-devel mailing list gmp-devel@gmplib.org https://gmplib.org/mailman/listinfo/gmp-devel

Re: Move -DNO_ASM to config.h?

2016-03-20 Thread Marc Glisse
On Sun, 20 Mar 2016, Torbjörn Granlund wrote: Marc Glisse writes: One issue with changing it is MPFR: src/mpfr-longlong.h tests for NO_ASM, but there is no code to define it. As far as I understand, MPFR uses __GMP_CFLAGS by default, in which GMP may have included

Re: Move -DNO_ASM to config.h?

2016-03-20 Thread Torbjörn Granlund
Marc Glisse writes: One issue with changing it is MPFR: src/mpfr-longlong.h tests for NO_ASM, but there is no code to define it. As far as I understand, MPFR uses __GMP_CFLAGS by default, in which GMP may have included -DNO_ASM. If we move NO_ASM to config.h, that

Re: Move -DNO_ASM to config.h?

2016-03-20 Thread Marc Glisse
On Sun, 20 Mar 2016, Niels Möller wrote: Marc Glisse writes: when configure wants to define a macro, it usually puts it in config.h. We do have one exception: NO_ASM, which ends up defined in CFLAGS. Was there a particular reason for this choice? I'm greping for its

Re: Move -DNO_ASM to config.h?

2016-03-20 Thread Niels Möller
Marc Glisse writes: > when configure wants to define a macro, it usually puts it in > config.h. We do have one exception: NO_ASM, which ends up defined in > CFLAGS. Was there a particular reason for this choice? I'm greping for its uses, and it is used only in C files as