Re: TODO for 5.2 v3

2014-01-16 Thread Torbjorn Granlund
ni...@lysator.liu.se (Niels Möller) writes: Question is, when is it useful for our purposes? First example, mpn_sec_add_1: mp_limb_t mpn_sec_add_1 (mp_limb_t *rp, mp_limb_t *ap, mp_size_t n, mp_limb_t b, mp_ptr scratch) { scratch[0] = b; MPN_ZERO

Re: TODO for 5.2 v3

2014-01-15 Thread Marc Glisse
On Wed, 15 Jan 2014, Niels Möller wrote: Torbjorn Granlund t...@gmplib.org writes: The volatile qualifier makes sure the number of memory reads and memory writes remain unchanged from the source code. Question is, when is it useful for our purposes? First example, mpn_sec_add_1: mp_limb_t

Re: TODO for 5.2 v3

2014-01-13 Thread Niels Möller
bodr...@mail.dm.unipi.it writes: Ciao, Il Mar, 7 Gennaio 2014 4:58 pm, Niels Möller ha scritto: Here's a first patch adding a couple of other functions. Benchmarking and testing is missing (except that the sec_minvert tests still pass). Interesting... Another thing I was about to ask, but

Re: TODO for 5.2 v3

2014-01-07 Thread Niels Möller
Torbjorn Granlund t...@gmplib.org writes: * Make some other sec functions from Niels' list public? Here's a first patch adding a couple of other functions. Benchmarking and testing is missing (except that the sec_minvert tests still pass). One interface question: Return value of cnd_neg.

Re: TODO for 5.2 v3

2014-01-07 Thread Torbjorn Granlund
ni...@lysator.liu.se (Niels Möller) writes: Torbjorn Granlund t...@gmplib.org writes: * Make some other sec functions from Niels' list public? Here's a first patch adding a couple of other functions. Benchmarking and testing is missing (except that the sec_minvert tests still

Re: TODO for 5.2

2014-01-02 Thread Marc Glisse
Hello, on my machine, I am getting: doc/gmp.texi:5807: must be after `@deftypefun' to use `@deftypefunx' (that's mpn_sec_minvert_itch) though it looks like it works fine on shell. It is happier if we remove the newline in the middle of the @deftypefun. -- Marc Glisse

Re: TODO for 5.2

2013-12-30 Thread Torbjorn Granlund
ni...@lysator.liu.se (Niels Möller) writes: Torbjorn Granlund t...@gmplib.org writes: I notice you make this non-public. Is it premature to make it part of the public interface? Pushed now, with declarations moved to gmp-h.in. And now some 450 nightly builds have run

Re: TODO for 5.2

2013-12-29 Thread Torbjorn Granlund
ni...@lysator.liu.se (Niels Möller) writes: * Finalise and commit mpn_sec_minvert. Here's a new version, including tests. Seems to work. I'll try to get this committed fairly soon. Nice! I notice you make this non-public. Is it premature to make it part of the public interface?

Re: TODO for 5.2

2013-12-29 Thread Niels Möller
Torbjorn Granlund t...@gmplib.org writes: I notice you make this non-public. Is it premature to make it part of the public interface? I just put the declarations together with the other mpn_sec_* functions. I think it makes sense to make mpn_sec_div_*, mpn_sec_minvert and mpn_sec_powm public

Re: TODO for 5.2

2013-12-29 Thread Torbjorn Granlund
ni...@lysator.liu.se (Niels Möller) writes: I just put the declarations together with the other mpn_sec_* functions. I think it makes sense to make mpn_sec_div_*, mpn_sec_minvert and mpn_sec_powm public together. Does mpn_sec_powm need more work (besides the rename) before made public?

TODO for 5.2

2013-12-28 Thread Torbjorn Granlund
This is what I want to fix before the 5.2 release. Please remind me if I have forgotten something. * Strongly consider making mpn_sec_div_qr return high quotient limb and write just nn-dn quotient limbs to qp area. * Finalise and commit mpn_sec_minvert. * Add some other sec functions from