ni...@lysator.liu.se (Niels Möller) writes:
I plan to check this in fairly soon.
Checked in this renaming now.
Next, I'd like to make mpn_cnd_add_n, mpn_cnd_sub_n and mpn_zero_p
public (I guess that also implies some documentation...).
mpn_zero_p is an inline function. In gmp.h, setting up
plan to check this in fairly soon.
Regards,
/Niels
diff --git a/ChangeLog b/ChangeLog
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,32 @@
+2013-03-12 Niels Möller ni...@lysator.liu.se
+
+ New names mpn_cnd_add_n and mpn_cnd_sub_n.
+ * mpn/generic/cnd_add_n.c (mpn_cnd_add_n): Renamed
Torbjorn Granlund t...@gmplib.org writes:
OK with me, but either test on powerpc64 before checking in, or keep an
eye on nightbuild regressions and fix any problem there.
I checked it now, but darn, it did break on powerpc. Register r6 was
used instead of the symbolic name n in a couple of
Here's a patch that reorders the arguments for mpn_addcnd_n and
mpn_subcnd_n (I think it's best to keep this change separate from the
renaming, since the potential problems are quite different).
It's tested on x86_64, arm, and with --disable-assembly. I've run a
regular make check and
Torbjorn Granlund t...@gmplib.org writes:
And this. (I think I'd prefer
mp_limb_t
mpn_cnd_add_n (mp_limb_t cnd, mp_ptr rp, mp_srcptr ap, mp_srcptr bp,
mp_size_t n)
but that's a minor detail, and view the cnd_-prefix as a family of
functions. Some other potential
ni...@lysator.liu.se (Niels Möller) writes:
Torbjorn Granlund t...@gmplib.org writes:
And this. (I think I'd prefer
mp_limb_t
mpn_cnd_add_n (mp_limb_t cnd, mp_ptr rp, mp_srcptr ap, mp_srcptr bp,
mp_size_t n)
but that's a minor detail, and view the cnd_
Torbjorn Granlund t...@gmplib.org writes:
I didn't notice that. Ahum. That makes the change much harder, of
course.
Not much harder, I hope. There are three assembly implementations, as
far as I see, x86_64, powerpc64/mode64, and arm. x86_64 and powerpc64
should need just permuting the m4