Re: Symbol hiding and unit tests

2015-07-07 Thread bodrato
Ciao, Il Lun, 6 Luglio 2015 11:46 pm, Torbjörn Granlund ha scritto: Unfortunately, it has now become obvious to me that symbol hiding conflicts with unit testing. :-( This can be handled either by 1. hiding (much!) fewer internal symbols, or by I agree with starting to hide some symbols.

Re: Anomaly in mpn_sqrtrem and mpn_rootrem

2015-07-07 Thread bodrato
Ciao, Il Lun, 6 Luglio 2015 11:28 pm, Torbjörn Granlund ha scritto: bodr...@mail.dm.unipi.it writes: ... yes, I know, we really need to improve also odd sizes... Perhaps one could simply wrap the current function in code which appends a zero limbs, calls the current code, and then

Re: Anomaly in mpn_sqrtrem and mpn_rootrem

2015-07-07 Thread Torbjörn Granlund
bodr...@mail.dm.unipi.it writes: https://gmplib.org/repo/gmp/rev/87ba695c8878 But I do not really like it. We alloc-copy-shift to add a dummy limb, then we call a code that allocs-copies-shifts to (virtually) add two more dummy limbs... There is still a very noticeable difference