mp_bitcnt_signed_t

2015-08-21 Thread Marc Glisse
Hello, mpz_get_d_2exp and mpf_get_d_2exp currently take as argument a long*. Since we introduced a type mp_bitcnt_t, I guess it would make sense to add mp_bitcnt_signed_t and use it there. Any objection? For the mpz case, the answer should always be nonnegative, so we could use an unsigned t

Re: mpq_cmp_z

2015-08-21 Thread Marco Bodrato
Ciao, Sorry Vincent, you suggested a simple function and received back a technical discussion about casting in C... On Fri, August 21, 2015 8:56 am, Torbjörn Granlund wrote: > not, I've forgotten this level of detail of the C standard. I am not > too enthusiastic about passing the wrong type, bu

Re: mpq_cmp_z

2015-08-21 Thread Marc Glisse
On Fri, 21 Aug 2015, Torbjörn Granlund wrote: "Marco Bodrato" writes: Maybe we can "promise" the right type, by adding an explicit cast? SIZ((mpz_srcptr) NUM(op2)) Except that we should cast op2, not NUM(ops). I am not sure Marc's reasoning is accurate, nor am I suggesting it is not, I've