Re: Unused code in mpn_mul_fft_decompose?

2019-03-05 Thread Torbjörn Granlund
paul zimmermann writes: Anyway this code is now obsolete (see [1] and [2]). No, the current GMP code is not obsolete. We have improvements in various state of development, but it is unlikely that any of that will be ready for inclusion in GMP soon. -- Torbjörn Please encrypt, key id

Re: Unused code in mpn_mul_fft_decompose?

2019-03-05 Thread paul zimmermann
Dear Mikhail, > From: Mikhail Hogrefe > Date: Mon, 4 Mar 2019 21:44:50 -0500 > > I was digging around in the GMP 6.1.2 source, and I noticed something in > mpn/generic/mul_fft.c. > > In mpn_mul_fft_decompose, there is an if statement checking 'dif > Kl', > which is equivalent to 'nl > 2

Unused code in mpn_mul_fft_decompose?

2019-03-05 Thread Mikhail Hogrefe
I was digging around in the GMP 6.1.2 source, and I noticed something in mpn/generic/mul_fft.c. In mpn_mul_fft_decompose, there is an if statement checking 'dif > Kl', which is equivalent to 'nl > 2 * K * l'. But there is a comment above the function saying 'We must have nl <= 2*K*l.', suggesting

Re: Unused code

2012-04-14 Thread Torbjorn Granlund
ni...@lysator.liu.se (Niels Möller) writes: Torbjorn Granlund t...@gmplib.org writes: Are you aware if any more files or functions that are unused? I suspect quite a lot of the new (since a couple of years now...) division code is not used by any advertised mpn_function. *One* C

Unused code

2012-04-13 Thread Torbjorn Granlund
I'd like to locate unused code in GMP. Unused code adds size to the source, which is not too bad, but if it is compiled, it adds size to the compiled library, in particular to the shared library (which is always mapped in its entire when a process linked to it is running). My current list

Re: Unused code

2012-04-13 Thread Marc Glisse
On Fri, 13 Apr 2012, Torbjorn Granlund wrote: Are you aware if any more files or functions that are unused? It is a different information, but a code coverage tool run during the testsuite tells which functions are never called there (on one specific platform, with one set of options):

Re: Unused code

2012-04-13 Thread Niels Möller
Torbjorn Granlund t...@gmplib.org writes: Are you aware if any more files or functions that are unused? I suspect quite a lot of the new (since a couple of years now...) division code is not used by any advertised mpn_function. Regards, /Niels -- Niels Möller. PGP-encrypted email is

Re: Unused code

2012-04-13 Thread bodrato
Ciao, Il Ven, 13 Aprile 2012 10:53 am, Marc Glisse ha scritto: It is a different information, but a code coverage tool run during the testsuite tells which functions are never called there (on one specific platform, with one set of options):

Re: Unused code

2012-04-13 Thread Marc Glisse
On Fri, 13 Apr 2012, bodr...@mail.dm.unipi.it wrote: http://hydra.nixos.org/build/2398430/download/1/coverage/ Very interesting! Moreover you got the current code! It is the continuous build infratructure that Ludovic Courtès presented about a year ago:

Re: Unused code

2012-04-13 Thread Torbjorn Granlund
bodr...@mail.dm.unipi.it writes: It is a different information, but a code coverage tool run during the testsuite tells which functions are never called there (on one specific platform, with one set of options): http://hydra.nixos.org/build/2398430/download/1/coverage/ Very