Re: [PATCHv2 0/1] Enable PAC and BTI for AArch64

2024-11-11 Thread Bill Roberts


On 11/7/24 2:25 AM, Niels Möller wrote:

Bill Roberts  writes:


This moves the generation of the m4 defines into the autoconf system
(hats off to whomever built that for GMP)

I think much of the credit should go to Kevin Ryde and Linus Nordberg
(who aren't currently active in GMP development).

Instead of adding

   ADD_GNU_NOTES_IF_NEEDED

to all assembly files, you could use m4 divert. Something like adding

   divert(1)
   ADD_GNU_NOTES_IF_NEEDED
   divert

to mpn/arm64/arm64-defs.m4. (It could potentially also go in the more
general mpn/asm-defs.m4, if we want to use the same facility of other
kinds of notes). That's what I do in nettle, in this file:

   https://git.lysator.liu.se/nettle/nettle/-/blob/master/config.m4.in



Ahh cool, I did not know about that. I will spin a v3 shortly.




/nisse


___
gmp-devel mailing list
gmp-devel@gmplib.org
https://gmplib.org/mailman/listinfo/gmp-devel


Re: [PATCHv2 0/1] Enable PAC and BTI for AArch64

2024-11-07 Thread Niels Möller
Bill Roberts  writes:

> This moves the generation of the m4 defines into the autoconf system
> (hats off to whomever built that for GMP)

I think much of the credit should go to Kevin Ryde and Linus Nordberg
(who aren't currently active in GMP development).

Instead of adding 

  ADD_GNU_NOTES_IF_NEEDED

to all assembly files, you could use m4 divert. Something like adding

  divert(1)
  ADD_GNU_NOTES_IF_NEEDED
  divert

to mpn/arm64/arm64-defs.m4. (It could potentially also go in the more
general mpn/asm-defs.m4, if we want to use the same facility of other
kinds of notes). That's what I do in nettle, in this file:

  https://git.lysator.liu.se/nettle/nettle/-/blob/master/config.m4.in

/nisse

-- 
Niels Möller. PGP key CB4962D070D77D7FCB8BA36271D8F1FF368C6677.
Internet email is subject to wholesale government surveillance.
___
gmp-devel mailing list
gmp-devel@gmplib.org
https://gmplib.org/mailman/listinfo/gmp-devel