Re: Suggested tune/tuneup.c patch

2019-09-13 Thread Niels Möller
t...@gmplib.org (Torbjörn Granlund) writes:

> ni...@lysator.liu.se (Niels Möller) writes:
>
>   Below patch adds a helper function for tuning *_METHOD values,
>   evaluated at some fix size. What do you think?
>
> It helps with some function comments, outlining what a function does,
> and what its arguments mean.
>
> Please consider adding that before committing.

Done and pushed.

> And please take a screenshot of the affected parameters before and
> after this change, as a sanity check.

Looks reasonable to me:

Before:

size=1, mpn_hgcd2_1 0.01154
size=1, mpn_hgcd2_2 0.01552
size=1, mpn_hgcd2_3 0.01138
#define HGCD2_METHOD ...
#define HGCD2_METHOD 3  /* 1.38% faster than 1 */

After: 

size=1, mpn_hgcd2, method 1 0.01160
size=1, mpn_hgcd2, method 2 0.01548
size=1, mpn_hgcd2, method 3 0.01146
#define HGCD2_METHOD ...
#define HGCD2_METHOD 3  /* 1.20% faster than 1 */

I only get this _METHOD and JACOBI_BASE_METHOD on my machine, though.
DIV_QR_1N_PI1_METHOD and MOD_1_1P_METHOD which also use the new helper
are both skipped.

Regards,
/Niels

-- 
Niels Möller. PGP-encrypted email is preferred. Keyid 368C6677.
Internet email is subject to wholesale government surveillance.
___
gmp-devel mailing list
gmp-devel@gmplib.org
https://gmplib.org/mailman/listinfo/gmp-devel


Re: Suggested tune/tuneup.c patch

2019-09-11 Thread Torbjörn Granlund
  And please take a screenshot of the affected parameters before and
  after this change, as a sanity check.

I added a history preservation feature to the .../devel/thres/ pages.  At
23:59 each night, all pages are copied to .../devel/thres/-MM-DD.

(There is no index, one needs to type in the wanted date manually.)

-- 
Torbjörn
Please encrypt, key id 0xC8601622
___
gmp-devel mailing list
gmp-devel@gmplib.org
https://gmplib.org/mailman/listinfo/gmp-devel


Re: Suggested tune/tuneup.c patch

2019-09-11 Thread Torbjörn Granlund
ni...@lysator.liu.se (Niels Möller) writes:

  Below patch adds a helper function for tuning *_METHOD values,
  evaluated at some fix size. What do you think?

It helps with some function comments, outlining what a function does,
and what its arguments mean.

Please consider adding that before committing.  And please take a
screenshot of the affected parameters before and after this change, as a
sanity check.


-- 
Torbjörn
Please encrypt, key id 0xC8601622
___
gmp-devel mailing list
gmp-devel@gmplib.org
https://gmplib.org/mailman/listinfo/gmp-devel