Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2008-01-29 Thread zou lunkai
> string_table::key > -string_table::find(const std::string& to_find, bool insert_unfound, > - bool case_insensitive) > +string_table::find(const std::string& t_f, bool insert_unfound) > { > - std::size_t ckey = 0; > + std::string t_fcase; > + const std::string *to_find =

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2008-01-24 Thread Sandro Santilli
On Thu, Jan 24, 2008 at 04:48:17PM +0800, zou lunkai wrote: > FYI, misc-ming.all/case.as, line 212: xcheck_equals(propRecorder[0], 'A') > That check fails because variable 'A' was converted to lower case at > definition time(right?) at swf version lower than 7. Correct. We discussed a more corre

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2008-01-24 Thread zou lunkai
> > Add case-insensitive support for string_table. More work is needed to > > enable it where appropriate. > > A suggestion could be not make sensitive-insensitive a per-call setting > but a permanent setting in string_table. > Currently, the only call to lower_next_group is at initiali

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2008-01-24 Thread strk
On Thu, Jan 24, 2008 at 03:41:59AM +, Chad Musick wrote: > CVSROOT: /sources/gnash > Module name: gnash > Changes by: Chad Musick08/01/24 03:41:59 > > Modified files: > . : ChangeLog > libbase: string_table.cpp string_table.h > server

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2007-10-24 Thread zou lunkai
> -- Is the property in B completely masked, or only for Setter? C = new Object(); B = new Object(); B.__proto__ = C; A = new Object(); A.__proto__ = B; mGetter = function() { return this._m }; mSetter = function (x) { check(this == _root.A); }; B.m = 100; C.addProperty("m", mGet

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2007-10-24 Thread strk
On Thu, Oct 25, 2007 at 12:26:39AM +0900, Chad Musick wrote: > What is the result of the following change to the code? > > mGetter = function() { > check(this == _root.A); > }; > > ... > > d:Number = A.m > > > -- Is the property in B completely masked, or only for Setter? My experience

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2007-10-24 Thread Chad Musick
What is the result of the following change to the code? mGetter = function() { check(this == _root.A); }; ... d:Number = A.m -- Is the property in B completely masked, or only for Setter? On Wed, 2007-10-24 at 10:36 +0800, zou lunkai wrote: > > > class A : B : C > > > > > > C.m

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2007-10-23 Thread strk
On Wed, Oct 24, 2007 at 07:11:55AM +0900, Chad Musick wrote: > > Chad, it seems this change broke something, see my new test in > > actionscript.all/Object.as > > > > This is the problem: > > > > class A : B : C > > > > C.m is a getter-setter > > B.m is a normal property > > A.m doe

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2007-10-23 Thread zou lunkai
> > class A : B : C > > > > C.m is a getter-setter > > B.m is a normal property > > A.m doesn't exist > > > > When setting A.m, the getter-setter should be invoked. Tried the above tests, confrimed that the setter should be invoked. See testing code below: C = new Object(); B =

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2007-10-23 Thread Chad Musick
> Chad, it seems this change broke something, see my new test in > actionscript.all/Object.as > > This is the problem: > > class A : B : C > > C.m is a getter-setter > B.m is a normal property > A.m doesn't exist > > When setting A.m, the getter-setter should be invoked. > fi

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2007-10-23 Thread strk
On Tue, Oct 23, 2007 at 07:39:41PM +0200, strk wrote: > On Thu, Oct 18, 2007 at 11:47:57AM +, Chad Musick wrote: > > > http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_object.cpp?cvsroot=gnash&r1=1.68&r2=1.69 > > > > - // found a getter/setter property in the inheritance chain > > - /

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2007-10-23 Thread strk
On Thu, Oct 18, 2007 at 11:47:57AM +, Chad Musick wrote: > http://cvs.savannah.gnu.org/viewcvs/gnash/server/as_object.cpp?cvsroot=gnash&r1=1.68&r2=1.69 > - // found a getter/setter property in the inheritance chain > - // so set that and return > - Property* prop = findGetterSett

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2007-10-18 Thread Chad Musick
Did you run ./autogen.sh ? This was removed from Makefiles. On Thu, 2007-10-18 at 15:20 +0200, Udo Giacomozzi wrote: > Hello Chad, > > Thursday, October 18, 2007, 1:47:57 PM, you wrote: > CM> Removed files: > CM> server : GetterSetter.cpp GetterSetter.h > CM> testsuite/se

Re: [Gnash-commit] gnash ChangeLog libbase/string_table.cpp libbas...

2007-10-18 Thread Udo Giacomozzi
Hello Chad, Thursday, October 18, 2007, 1:47:57 PM, you wrote: CM> Removed files: CM> server : GetterSetter.cpp GetterSetter.h CM> testsuite/server: GetterSetterTest.cpp Build fails now: make[3]: Entering directory `/home/indunet/gnash-pc104/gnash/server' make[3]: *** N